From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AD6203858D35 for ; Fri, 8 Sep 2023 17:05:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD6203858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694192751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4phteWtTnFKQ4wTkDPzKiRd7wxC0rXfwrkYWkDzXow=; b=VMryWi0vnwRr9UgnZkQi3mryVRIhTr/sMqNsvxNpCppLqn2DbArXc7iHvo3/6VtKmFKfeZ 2n8Qb0p1k4Bcb0mKZouJwSinuo1jXp4qcWQpu8tTEBbJpuORCdJL9jQs/WqDx03BR9OxYI 8D8jpRaQ1W0PX0ZXOPX3s21Nas9qLBg= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-iY-biHXvPiq4ux8m6j4FQg-1; Fri, 08 Sep 2023 13:05:49 -0400 X-MC-Unique: iY-biHXvPiq4ux8m6j4FQg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2bcec24e8f8so27691811fa.1 for ; Fri, 08 Sep 2023 10:05:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694192748; x=1694797548; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q4phteWtTnFKQ4wTkDPzKiRd7wxC0rXfwrkYWkDzXow=; b=EGUzlu4e5sp0qxvEfq0SCVEJaMOnEJSThB18wZrYj1vEl3bYildxjtaVt9LLOPyAPX +vEK4pfT8zpbWuWLahHh9Cgh3J+DwyhR26l99jp4xd/hc6WCypuprNktHLd+QfS2eyZr Cj5Z6C824aYBSkDwtXmaUz3LWjuGMSbA9fNdKzIPuvW/w625i0oKTTkkCu4fQHHsKtOe Wh/A4k8N3jcccl10eu78AaOzMVgSLtIEQm5I3nZYk3l2AWYeG3Ps1oQDJFM2bkGx7CAv A/UKO5/bOgyRgQ5ZlCVWoT+cBn3syQfgywSoMiW+hB2pFFLxwmgvPMLkqnrvq0xmqCCb YOJQ== X-Gm-Message-State: AOJu0YzqUwqXYnCNOfRLe69av9v+oyo/HbNdGuJzYtL87n/gyE0JxZ8Q jmmhHwjRu7S6DQ6MdDRCxQAL9aLJ9vzwFl/zvnELG4Jcwz+itWG1Ml56iRraBmEvs7+L6gsAyEt 8Jakp+SpwH0GiKI7tvwu599/sNoSDXpI= X-Received: by 2002:a2e:9d08:0:b0:2b6:e618:b5a0 with SMTP id t8-20020a2e9d08000000b002b6e618b5a0mr2209418lji.6.1694192748371; Fri, 08 Sep 2023 10:05:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCX4eZVp8LFJ8Kfkni6Z5u6obtyuSfA+cA4MckeO5Er/gucPxvv9YrcZ09yaiePWMl8noXV5NjWSsuzqxIdzM= X-Received: by 2002:a2e:9d08:0:b0:2b6:e618:b5a0 with SMTP id t8-20020a2e9d08000000b002b6e618b5a0mr2209396lji.6.1694192747947; Fri, 08 Sep 2023 10:05:47 -0700 (PDT) MIME-Version: 1.0 References: <0784b8c8a8149b672e01ad9da657f6cbf9df7227.camel@espressif.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 8 Sep 2023 18:05:36 +0100 Message-ID: Subject: Re: [PATCH] libbacktrace: Fix unconditional -Werror To: Jonathan Wakely Cc: Alexey Lapshin , "libstdc++" , Hans-Peter Nilsson , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 8 Sept 2023 at 11:10, Jonathan Wakely wrote: > > The patch looks good, thanks. I noticed the unconditional -Werror the other day when testing a build on avr. > > N.B. All patches should go to gcc-patches (as well as a more specific list like libstdc++ when appropriate). > > OK for trunk I've pushed this now - thanks again. > > > > On Fri, 8 Sept 2023, 10:49 Alexey Lapshin via Libstdc++, wrote: >> >> Added to CC: jwakely@redhat.com, hp@axis.com >> >> >> On Fri, 2023-09-08 at 12:39 +0400, Alexey Lapshin wrote: >> > -Werror flag should depend on --enable-werror configure option >> > >> > --- >> > libstdc++-v3/src/libbacktrace/Makefile.am | 2 +- >> > libstdc++-v3/src/libbacktrace/Makefile.in | 2 +- >> > 2 files changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.am b/libstdc++-v3/src/libbacktrace/Makefile.am >> > index 9abf9dd64a1..27c1ea570e0 100644 >> > --- a/libstdc++-v3/src/libbacktrace/Makefile.am >> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.am >> > @@ -45,7 +45,7 @@ libstdc___libbacktrace_la_CPPFLAGS = \ >> > $(BACKTRACE_CPPFLAGS) >> > >> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \ >> > - -Wcast-qual -Werror >> > + -Wcast-qual >> > C_WARN_FLAGS = $(WARN_FLAGS) -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wno-unused-but-set-variable >> > CXX_WARN_FLAGS = $(WARN_FLAGS) -Wno-unused-parameter >> > AM_CFLAGS = $(C_WARN_FLAGS) >> > diff --git a/libstdc++-v3/src/libbacktrace/Makefile.in b/libstdc++-v3/src/libbacktrace/Makefile.in >> > index 1c1242d8827..b78c8443751 100644 >> > --- a/libstdc++-v3/src/libbacktrace/Makefile.in >> > +++ b/libstdc++-v3/src/libbacktrace/Makefile.in >> > @@ -368,7 +368,7 @@ VTV_CXXFLAGS = @VTV_CXXFLAGS@ >> > VTV_CXXLINKFLAGS = @VTV_CXXLINKFLAGS@ >> > VTV_PCH_CXXFLAGS = @VTV_PCH_CXXFLAGS@ >> > WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \ >> > - -Wcast-qual -Werror >> > + -Wcast-qual >> > >> > XMLCATALOG = @XMLCATALOG@ >> > XMLLINT = @XMLLINT@ >>