From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E597E3858433 for ; Wed, 22 Mar 2023 19:53:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E597E3858433 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679514805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k9HfH6cL1YWmTXXrRCVtnGMpfe5ShdAOUkY/LmcedeI=; b=NEWDb4QSOVsWCpMMR03XEWfGnF0pMHZKYeAwSp67d4NnlSwiczn3BtzsX4IUAt9Izv4x3g 4Kosr7/u5c5tLXuYJRbShezIHzsvZC+TCq7mpvdBsyJ1FW7nDWqIWybZMnW0oc96FsfOyA WDykZoVfXkjABwX0EaH6IIefJMBpLRM= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-SGVPApkSMsSr0BJsINSsWg-1; Wed, 22 Mar 2023 15:53:23 -0400 X-MC-Unique: SGVPApkSMsSr0BJsINSsWg-1 Received: by mail-lj1-f197.google.com with SMTP id f16-20020a05651c03d000b0029bebfa766dso3414418ljp.11 for ; Wed, 22 Mar 2023 12:53:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679514802; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k9HfH6cL1YWmTXXrRCVtnGMpfe5ShdAOUkY/LmcedeI=; b=WvA1JnI+2sCLoy/L7j3J3Ez/Os34VbNA+aBLKCvT6jk210DGu25Ju+jQLBeDZ6rYtZ nBcfhI+0YxEXekj+RAbIzIFRmF74vLe7xwthalfRmNQOGSxxlZqs3GlfFc9DFzYvevdn smcCpEpT22ILh2FoQBVJcsQ59pENTwnbgzhZyUkk/LdMWERYX4jDGJWDa7JocsbZrcT4 4L11VrSMLrO2n9RcVjXPImOkVTqEJOqT4IpAsTVIOVtF3XcXQhu4N2hIx1gQkCjMTevh pW4E6C87xSPbxDvm1xV5GYjNhLTT8A7/me0RVbK9oSPg5i3njFYthF5p3f6FhI39nxoX QEjw== X-Gm-Message-State: AO0yUKXL/HzPCSBvvXxlBNVuMlkMlFFlNcLQBEx9udR0Cro0IiY44QuV aS9NxVCuR+hOdeTtj2vM0Ays4H/wKsqUw5n9WYZRIML81tybxWlCGlLCA9nHXWdmMCJv6eskeD/ CcVe41bwzVnmeHNYo1gD+dBOfJI82J+s= X-Received: by 2002:ac2:46fa:0:b0:4db:173e:812a with SMTP id q26-20020ac246fa000000b004db173e812amr2301320lfo.8.1679514802356; Wed, 22 Mar 2023 12:53:22 -0700 (PDT) X-Google-Smtp-Source: AK7set+fv1GSqs/nPRWk/a4n0smBM3qmbahUbYfUf9f8i/5jDMSspskw0nfmQ/g//QlnJrZhHxPJqYu78ku1wtWSImg= X-Received: by 2002:ac2:46fa:0:b0:4db:173e:812a with SMTP id q26-20020ac246fa000000b004db173e812amr2301311lfo.8.1679514801982; Wed, 22 Mar 2023 12:53:21 -0700 (PDT) MIME-Version: 1.0 References: <20230322175003.408005-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 22 Mar 2023 19:53:10 +0000 Message-ID: Subject: Re: [committed] libstdc++: Add missing __cpp_lib_format macro to To: =?UTF-8?Q?Daniel_Kr=C3=BCgler?= Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000002ae19c05f78283e3" X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002ae19c05f78283e3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 22 Mar 2023 at 19:46, Jonathan Wakely wrote: > > > On Wed, 22 Mar 2023 at 17:59, Daniel Kr=C3=BCgler > wrote: > >> Am Mi., 22. M=C3=A4rz 2023 um 18:53 Uhr schrieb Jonathan Wakely via >> Libstdc++ : >> > >> > Tested powerpc64le-linux, pushed to trunk. >> > >> > -- >8-- >> > >> > libstdc++-v3/ChangeLog: >> > >> > * include/std/version (__cpp_lib_format): Define. >> > * testsuite/std/format/functions/format.cc: Check it. >> > --- >> > libstdc++-v3/include/std/version | 1 + >> > .../testsuite/std/format/functions/format.cc | 15 +++++++++++++++ >> > 2 files changed, 16 insertions(+) >> > >> > diff --git a/libstdc++-v3/include/std/version >> b/libstdc++-v3/include/std/version >> > index 25ebfc3e512..a19c39c6cdd 100644 >> > --- a/libstdc++-v3/include/std/version >> > +++ b/libstdc++-v3/include/std/version >> > @@ -277,6 +277,7 @@ >> > #define __cpp_lib_constexpr_utility 201811L >> > #define __cpp_lib_constexpr_vector 201907L >> > #define __cpp_lib_erase_if 202002L >> > +#define __cpp_lib_format 202106L >> >> Shouldn't the value be 202207L? (This of-course of your conforming >> completeness) >> >> > Well spotted! > > The historical values listed in SD-6 are included in a comment in : > > // 201907 Text Formatting, Integration of chrono, printf corner cases. > // 202106 std::format improvements. > // 202110 Fixing locale handling in chrono formatters, generator-like > types. > // 202207 Encodings in localized formatting of chrono, basic-format-strin= g. > #define __cpp_lib_format 202106L > > The libstdc++ support only got as far as 202106 so far :-) > > (We actually do implement the support for generator-like types from > P2418R2 and the std::basic_format_string change from P2508R1, but can't > bump the value to 202207 until the other changes are supported too.) > > I might still find time to finish P2372R3 and P2419R2 for GCC 13, but no > promises. > Hmm, actually maybe I already did all of P2372R3 as part of the formatting, so it should be 202110. And for P2419R2 we could say that the implementation-defined set of locales is empty ... but that's pretty poor QoI. There are also some more changes in C++23 (P2572 and P2675) which aren't done yet. --0000000000002ae19c05f78283e3--