From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B55833858D35 for ; Mon, 14 Nov 2022 10:17:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B55833858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668421023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FCQ9M4T44lTPWZFU8KE+A43S/hMqheyufUm2qnqc1Lk=; b=QhDWe19lDfW860CpsyhDeBUpGiFlIbZEO+SgVQe88+QPHZA50mKSTBeNekDyMBK9EIbv5z NyyD3gJz4GuaUKhkH5AxAr3KefyYGq+OJoWaZ6bggibkatEFyH0ctwKG2/RgSAZV7fbHg/ 3TP30ydaRxjuSa4OZIx2jTjAA/C0SYE= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-198-M3vIAcSVPN-sGIsE-oHATQ-1; Mon, 14 Nov 2022 05:17:02 -0500 X-MC-Unique: M3vIAcSVPN-sGIsE-oHATQ-1 Received: by mail-ej1-f72.google.com with SMTP id qw20-20020a1709066a1400b007af13652c92so367192ejc.20 for ; Mon, 14 Nov 2022 02:17:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FCQ9M4T44lTPWZFU8KE+A43S/hMqheyufUm2qnqc1Lk=; b=yMVZe8NUeY9LP42lvm+RFJjxzuQrwJ3wD3Zug/sFJ1hd3MhTYVjuhG4lIGzJoLbq+/ wcxkOrvwvAPAluvgYmNRFYrbxVKHAO6FgshosWnXrAYDMOzh+EyJTvSF/6Ld5i52JGeN m7oRcbxu7d26wmjjx6uA2v4ASQQIX45jaxFzRImHaZaaGbQMJ9hit+RI2mVuDeu/sHOt iILDMU4BKj4LM31pCziKQMuYNlC3rO3sb5sB9RnkfsfIr6bOpagD8lmgTswBomYBfl2C +J95Rr7HbLdVkyuLJ2PquB69Mdj7SEa0h87sAbyQ6NJTmh+7XnYdCqjeGGOyTNWvXtTN RpKg== X-Gm-Message-State: ANoB5pnA1/4Vuu4lqAiNADQKwsme+jPFdFgCC3O6SO2Uj1uZwgtB8y05 2yh9CsRZA3EML6RX60tiR7ab1Nk5jQ3cVePt9VYVK5ZhQ0EoWf+bcVEd6yEu6dAhjDSLYEIkiat 0vq6os+P0SGWAaBgx0AYMIYY0SBC1EWA= X-Received: by 2002:a17:906:1ed0:b0:78d:9e77:1f8c with SMTP id m16-20020a1709061ed000b0078d9e771f8cmr9648437ejj.236.1668421021074; Mon, 14 Nov 2022 02:17:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf7gGVgDddpyHLj+Wzi1kJUXK7JLCcIwJHKDx4dIiJIhC6uer2vMRaaxOTLhm2yiSO5j65fIM0yZvkA31TGBDrs= X-Received: by 2002:a17:906:1ed0:b0:78d:9e77:1f8c with SMTP id m16-20020a1709061ed000b0078d9e771f8cmr9648425ejj.236.1668421020839; Mon, 14 Nov 2022 02:17:00 -0800 (PST) MIME-Version: 1.0 References: <20221113180527.2907744-1-arsen@aarsen.me> <20221113212952.66bbe897@nbbrfq> In-Reply-To: <20221113212952.66bbe897@nbbrfq> From: Jonathan Wakely Date: Mon, 14 Nov 2022 10:16:50 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories To: Bernhard Reutner-Fischer Cc: Jonathan Wakely via Gcc-patches , Jonathan Wakely , =?UTF-8?Q?Arsen_Arsenovi=C4=87?= , "libstdc++" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 13 Nov 2022 at 20:30, Bernhard Reutner-Fischer via Libstdc++ wrote: > > On Sun, 13 Nov 2022 19:42:52 +0000 > Jonathan Wakely via Gcc-patches wrote: > > > On Sun, 13 Nov 2022, 18:06 Arsen Arsenovi=C4=87 via Libstdc++, < > > libstdc++@gcc.gnu.org> wrote: > > > > > I'm unsure why this issue only started manifesting now with how old t= his > > > code is, but this should fix it. > > > > > > > I just pushed a change to how the debug build makefiles are generated, > > which presumably uncovered this latent bug. I'll review the patch in th= e > > morning. > > Ah, you removed debugdir everywhere but in the install-debug rule :) Doh! I'll get your fix below committed in a few minutes, thanks. > I.e.: > > $ git diff > diff --git a/libstdc++-v3/src/Makefile.am b/libstdc++-v3/src/Makefile.am > index b545ebf0dcf..bfa031ea395 100644 > --- a/libstdc++-v3/src/Makefile.am > +++ b/libstdc++-v3/src/Makefile.am > @@ -422,5 +422,5 @@ build-debug: stamp-debug $(debug_backtrace_supported_= h) > > # Install debug library. > install-debug: build-debug > - (cd ${debugdir} && $(MAKE) CXXFLAGS=3D'$(DEBUG_FLAGS)' \ > - toolexeclibdir=3D$(glibcxx_toolexeclibdir)/debug install) ; > + $(MAKE) -C debug CXXFLAGS=3D'$(DEBUG_FLAGS)' \ > + toolexeclibdir=3D$(glibcxx_toolexeclibdir)/debug install > diff --git a/libstdc++-v3/src/Makefile.in b/libstdc++-v3/src/Makefile.in > index f54ee282fb0..8479d297389 100644 > --- a/libstdc++-v3/src/Makefile.in > +++ b/libstdc++-v3/src/Makefile.in > @@ -1142,8 +1142,8 @@ build-debug: stamp-debug $(debug_backtrace_supporte= d_h) > > # Install debug library. > install-debug: build-debug > - (cd ${debugdir} && $(MAKE) CXXFLAGS=3D'$(DEBUG_FLAGS)' \ > - toolexeclibdir=3D$(glibcxx_toolexeclibdir)/debug install) ; > + $(MAKE) -C debug CXXFLAGS=3D'$(DEBUG_FLAGS)' \ > + toolexeclibdir=3D$(glibcxx_toolexeclibdir)/debug install > > # Tell versions [3.59,3.63) of GNU make to not export all variables. > # Otherwise a system limit (for SysV at least) may be exceeded. > > I personally did not experience the gdb.py install bug Arsen seems to > have encountered though. > > thanks! > > > > > > > > > libstdc++-v3/ChangeLog: > > > > > > * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA > > > when installing gdb scripts. > > > * python/Makefile.in: Regenerate. > > > --- > > > Hi, > > > > > > Someone spotted on IRC spotted an error: if trying to install to a fr= esh > > > prefix/sysroot with --enable-libstdcxx-debug, the install fails since= it's > > > intended target directories don't exist. I could replicate this on > > > r13-3944-g43435c7eb0ff60 using > > > > > > $ ../gcc/configure --disable-bootstrap \ > > > --enable-libstdcxx-debug \ > > > --enable-languages=3Dc,c++ \ > > > --prefix=3D$(pwd)/pfx >