From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4EF1B3858C20 for ; Thu, 8 Jun 2023 13:13:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EF1B3858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686230034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8chGmNPO1T3Axd6X8TbN3KCkWEV3Q4yG3E9ke3Ety6s=; b=Yhyj+0CfI7VgpBIYP+n5ucaagGkPh4lLaEbEM7c+irBrC0zXKU8wTnKYH6Z7iViqpqe3OP BbqRYgsOM326c2Beop9ERSCh6HNOuFNs6Rz/jbDaP9YYIpfhJHtCS9tfwDRkksZCSNM1ff xhAv+IDVT/kj56PusJmd2fKbEnzB4nY= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-iPz_5WTqNlaIsQvWBxDpKQ-1; Thu, 08 Jun 2023 09:13:51 -0400 X-MC-Unique: iPz_5WTqNlaIsQvWBxDpKQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2b1abdb8ef9so3066001fa.2 for ; Thu, 08 Jun 2023 06:13:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686230030; x=1688822030; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8chGmNPO1T3Axd6X8TbN3KCkWEV3Q4yG3E9ke3Ety6s=; b=euDtr15ME7afDFQBvCc1Ma0R88CRYrUjibAEPVX/ymB7A4MzQib/tdfnVp61tufAm0 O+kQcOmlLrq7CXhEq5ENgQpuwutOQjHtDa+nZbB6YMyh60TUslMa7Ebl+VAkKnapHMs2 n5rrDGx14gpVQoJUAvrI2ylSZ7A7q/V26WmpJzYHdJaEI2O6Hui9ku4i0tmWtMTzGOQj pAzpNrvecTRjEbtKMYKlmaR0jrw9BFYkH982ExTSr5Aa9hcrhEBtzzHGAQaSqEp02X8S 5tJCbmoyC4NNWhzohM5t2Q5QdURRc9sNMCQmi/AFO3qENpZVN7aA2wIugY6xXMIQUC4P IPhw== X-Gm-Message-State: AC+VfDwRO1vmyPxtbWWyKVZeawsRDu/MlAxcHMRa59hP+G42J9g+N7ZV bbN1xRZXaJS4NONESpOD0CNK0LnCVnB3KVJ00P24xpzh1JVaxYaLucovvhXV3gCcfWeLTBgkMXF XKHpvrtujeozIQv84742gVwCzFtrKlow= X-Received: by 2002:a2e:7813:0:b0:2a8:b27f:b721 with SMTP id t19-20020a2e7813000000b002a8b27fb721mr3444210ljc.29.1686230030402; Thu, 08 Jun 2023 06:13:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7CEQvxWjLacQmQ2b888VNFzzl0qVODakjmcUfzFFIGO5lCQNCIy9Fwf0jfIoF/D2djw4laE/jPNwoAMajeUiE= X-Received: by 2002:a2e:7813:0:b0:2a8:b27f:b721 with SMTP id t19-20020a2e7813000000b002a8b27fb721mr3444204ljc.29.1686230030097; Thu, 08 Jun 2023 06:13:50 -0700 (PDT) MIME-Version: 1.0 References: <20230524185559.1285583-1-jason@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Thu, 8 Jun 2023 14:13:38 +0100 Message-ID: Subject: Re: [PATCH RFC] c++: use __cxa_call_terminate for MUST_NOT_THROW [PR97720] To: Jason Merrill Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000f432dc05fd9e057a" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f432dc05fd9e057a Content-Type: text/plain; charset="UTF-8" On Fri, 26 May 2023 at 10:58, Jonathan Wakely wrote: > > > On Wed, 24 May 2023 at 19:56, Jason Merrill via Libstdc++ < > libstdc++@gcc.gnu.org> wrote: > >> Middle-end folks: any thoughts about how best to make the change >> described in >> the last paragraph below? >> >> Library folks: any thoughts on the changes to __cxa_call_terminate? >> > > I see no harm in exporting it (with the adjusted signature). The "looks > standard but isn't" name is a little unfortunate, but not a big deal. > Jason, do you have any objection to exporting __cxa_call_terminate for GCC 13.2 as well, even though the FE won't use it? Currently both gcc-13 and trunk are at the same library version, libstdc++.so.6.0.32 But with this addition to trunk we need to bump that .32 to .33, meaning that gcc-13 and trunk diverge. If we want to backport any new symbols from trunk to gcc-13 that gets trickier once they've diverged. If we added __cxa_call_terminate to gcc-13, making it another new addition to libstdc++.so.6.0.32, then it would simplify a few things. In theory it could be a problem for distros already shipping gcc-13.1.1 with that new libstdc++.so.6.0.32 version, but since the __cxa_call_terminate symbol won't actually be used by the gcc-13.1.1 compilers, I don't think it will be a problem. --000000000000f432dc05fd9e057a--