From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EF0343858C53 for ; Thu, 4 Jan 2024 22:11:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF0343858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF0343858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704406303; cv=none; b=t3KCfmGanP2AVdy0UdcwtoTEs6w+a93WezYF12Mpwnb3El/SDCeSTKhYWckavpEzuG1wEk5IANoZ72eNJhI5lyirfu8rslhT4QtVWTkJmQrvSmoHn1wkwGxljISLs4XS5vUI6fnb2TtrF+rEMphNDkum4xOh1OEDxCIyZPLN5DU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704406303; c=relaxed/simple; bh=AFh5zDb6xejdolMqBHBCvAMBkaI/1tcwQk4svRBwpVE=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=CJ9+D8876hOt2GTTJA6T21mPxtRV644slvF3iwG1TRp7eR+kmGi73XofvGdgBWsYs4ZVZlQ6ylOB7sQDmqwGeWsitYxz4jXlYKA1F8gldoGg3KoKksys74uZg/86S1gskDChWf5qeN25CxdBmb2SGH3VFhqVkVl255nxF3pVsrY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704406301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yT1vRHQaiPsfRwNGw+DezwTZT846WVLSUeJ1z/nKTQU=; b=OGvdoH2e3thiikgPKVn1iZpckGY6qNPEtQBuDE5j094OAJSPJCaruvjvv5rcDbwsNj2zat RwTmDqLyoskFm3uqcT0eHY+XDse3RK61NLv2DMU1UaA1afWkofJvQG6gI4MwrbvqNB6WVa bF2/MTGADf76ynXIkrcElfRWpEeXfBQ= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-hCax-swiMmqsrVFQZdFy8A-1; Thu, 04 Jan 2024 17:11:35 -0500 X-MC-Unique: hCax-swiMmqsrVFQZdFy8A-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5e744f7ca3bso15922537b3.2 for ; Thu, 04 Jan 2024 14:11:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704406295; x=1705011095; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yT1vRHQaiPsfRwNGw+DezwTZT846WVLSUeJ1z/nKTQU=; b=ntytCKEHKIxiZ7JiCvNFO1Ofed6UePpSefacwdP2gc7/FC5r+n76MA5A+oBAVBGFmz tA7okcWCzNZxTKziZA7F72ixLEB37TbueGd3JZUYuFJImqB/Gcrl/ucZvVRislyE/EiO RfyKcetKsdy4WZC0D6tN3MIvO2nlMQUguWgkD9Yk1r5qw+nz2Rd9bkhNxHBqa3e9312x C4MgH5m/M830gmBcE2ToJoXRoKpMkzbZokW8yEQdE9SG3gkJHciIAu5BoUiFwXt6T35+ CsHt8De+OKGLhAUvEuSabKoAI10SUALwZX+8busGJ7sB1jBBNnWBHbgMhCsykZ9NopXF 3xnQ== X-Gm-Message-State: AOJu0Ywnn+nX7wZ47Sze0Gkxy2UNmDp9f0+dwyXBfGFbULQLevGYjtIh yZO3liyjsmkBW8z5d/cFPYiaK+nrPQaFT0plWVdDkqsRDaw8MoGmeszlZEuaHhtSSqYQgnX38Aa 8XS50AqUUkpZm/ZAYK5Ucltst+Lp1jf+E7pa0Dm7aa66alMM= X-Received: by 2002:a0d:f406:0:b0:5d7:50ef:263c with SMTP id d6-20020a0df406000000b005d750ef263cmr1491109ywf.34.1704406294767; Thu, 04 Jan 2024 14:11:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdf8ZwCQ+3RKbo1Dhu6rslFadPyW64Lo69arC+0Sw0L7hvLBNp1ZZjZru1Wd1EGfQIFla3Kx3Q9qizfg5mF5E= X-Received: by 2002:a0d:f406:0:b0:5d7:50ef:263c with SMTP id d6-20020a0df406000000b005d750ef263cmr1491103ywf.34.1704406294525; Thu, 04 Jan 2024 14:11:34 -0800 (PST) MIME-Version: 1.0 References: <20230911152703.22436-1-kmatsui@gcc.gnu.org> <20231223230558.849031-1-kmatsui@gcc.gnu.org> In-Reply-To: <20231223230558.849031-1-kmatsui@gcc.gnu.org> From: Jonathan Wakely Date: Thu, 4 Jan 2024 22:11:18 +0000 Message-ID: Subject: Re: [PATCH v2] libstdc++: Use _GLIBCXX_USE_BUILTIN_TRAIT To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, Patrick Palka X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 23 Dec 2023 at 23:06, Ken Matsui wrote: > > This patch uses _GLIBCXX_USE_BUILTIN_TRAIT macro instead of __has_builtin > in the type_traits header for traits that have a corresponding fallback > non-built-in implementation. This macro supports to toggle the use of > built-in traits in the type_traits header through > _GLIBCXX_DO_NOT_USE_BUILTIN_TRAITS macro, without needing to modify the > source code. OK for trunk, thanks. +Reviewed-by: Jonathan Wakely > > libstdc++-v3/ChangeLog: > > * include/std/type_traits: Use _GLIBCXX_USE_BUILTIN_TRAIT. > > Signed-off-by: Ken Matsui > Reviewed-by: Patrick Palka > --- > libstdc++-v3/include/std/type_traits | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index f00c07f94f9..ba35ffb27fa 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -1481,7 +1481,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > : public __bool_constant<__is_base_of(_Base, _Derived)> > { }; > > -#if __has_builtin(__is_convertible) > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_convertible) > template > struct is_convertible > : public __bool_constant<__is_convertible(_From, _To)> > @@ -1531,7 +1531,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > > #ifdef __cpp_lib_is_nothrow_convertible // C++ >= 20 > > -#if __has_builtin(__is_nothrow_convertible) > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_nothrow_convertible) > /// is_nothrow_convertible_v > template > inline constexpr bool is_nothrow_convertible_v > @@ -1606,7 +1606,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > { using type = _Tp; }; > > /// remove_cv > -#if __has_builtin(__remove_cv) > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__remove_cv) > template > struct remove_cv > { using type = __remove_cv(_Tp); }; > @@ -1672,7 +1672,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > // Reference transformations. > > /// remove_reference > -#if __has_builtin(__remove_reference) > +#if _GLIBCXX_USE_BUILTIN_TRAIT(__remove_reference) > template > struct remove_reference > { using type = __remove_reference(_Tp); }; > @@ -3537,7 +3537,7 @@ template > * @{ > */ > #ifdef __cpp_lib_remove_cvref // C++ >= 20 > -# if __has_builtin(__remove_cvref) > +# if _GLIBCXX_USE_BUILTIN_TRAIT(__remove_cvref) > template > struct remove_cvref > { using type = __remove_cvref(_Tp); }; > -- > 2.43.0 >