* Minor nit in tzdb.cc
@ 2023-01-26 15:42 Michael Welsh Duggan
2023-01-26 16:01 ` Jonathan Wakely
0 siblings, 1 reply; 2+ messages in thread
From: Michael Welsh Duggan @ 2023-01-26 15:42 UTC (permalink / raw)
To: libstdc++
In tzdb.cc, the constant "/tzdata.zi" is used in the tzdata_stream
constructor, but the tzdata_file constant probably was meant to be used
instead (currently unused).
Should I have created a bugzilla issue rather than sending this here?
It's not really a bug, per se. It feels more like a style question.
--
Michael Welsh Duggan
(md5i@md5i.com)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Minor nit in tzdb.cc
2023-01-26 15:42 Minor nit in tzdb.cc Michael Welsh Duggan
@ 2023-01-26 16:01 ` Jonathan Wakely
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2023-01-26 16:01 UTC (permalink / raw)
To: libstdc++
On Thu, 26 Jan 2023 at 15:45, Michael Welsh Duggan wrote:
>
> In tzdb.cc, the constant "/tzdata.zi" is used in the tzdata_stream
> constructor, but the tzdata_file constant probably was meant to be used
> instead (currently unused).
Ah yes, good catch. I initially put the tzdata_stream in a separate
file, where the constant wasn't visible. When I moved it back into
tzdb.cc I forgot to reconcile that.
> Should I have created a bugzilla issue rather than sending this here?
> It's not really a bug, per se. It feels more like a style question.
Raising it like this is fine, I will push the fix shortly. Thanks for
spotting it!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-26 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-26 15:42 Minor nit in tzdb.cc Michael Welsh Duggan
2023-01-26 16:01 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).