From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EE9AC3858D38 for ; Thu, 26 Jan 2023 16:01:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE9AC3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674748908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9mNBARjLfEzTl6A5N44M3MKXc10rgS8yJ9BdsTXKn/M=; b=PeeMN5g15q3i77oUdQQ7SOs7fLjngyWmxtFux+Ns/FF6/zxB74WtL0HsKYQelLrafruF7V JCEIPjaz4aGsHJR+d/jNz/kClBUxo553eSc9kzgWNOdwaIi57Yplhs61lWeMfCL72gyHFG qATBYIvtZArgAxSfIQdgU2siJ8waiWc= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-615-q7y6TCb0MXiY97lAi8Dj7w-1; Thu, 26 Jan 2023 11:01:47 -0500 X-MC-Unique: q7y6TCb0MXiY97lAi8Dj7w-1 Received: by mail-lf1-f71.google.com with SMTP id f17-20020ac25091000000b004b565e69540so987999lfm.12 for ; Thu, 26 Jan 2023 08:01:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9mNBARjLfEzTl6A5N44M3MKXc10rgS8yJ9BdsTXKn/M=; b=Cr2PAHz5I9akxbNL+FiGT6uSxAoWmaCXsBkOhOJuW9L8+7y16QxAVE68xsTpL6M3ZD oZoz8p0KBhIBDgIRb0tMs2uowpFpcZoxZWiYkEkXE+6BSpG1t3rdz2rOAqwxEiwPWKe8 IdvMN/g1PkT6tusmL4w3QC0e1IBj6DqskBuA0j7E/RyAPDWwXdAi2zichZAOcGaUy2yH TzAa5F00QwQUMsVLYlW9ktL4rh6R8kE9YCR4J14RfnMIl+G83J5upvX87K9SUfXqsl5+ 4cmnW7N4HQ4GO0466IQkFP6GWFdPe0FF6ORWvp1ZuqwFmfPS9vzfRcfn6Byb3gZOwcj2 HbRA== X-Gm-Message-State: AFqh2kq7rsll/0U62d2lgt7ImTAKu8de7bgCFH7+PY+57bdtJhlzft3f OexuGMuELahZswzGQBxPUF4Oc3ybvTWWqGYhebeITrnFcqEeSDnLsyWuZnhyDhkyiSddZy5UegK KzlBC0rBpVWX72fwNJOXEnt1iSjKbCuM= X-Received: by 2002:a2e:99d3:0:b0:27f:b473:f5c3 with SMTP id l19-20020a2e99d3000000b0027fb473f5c3mr1868474ljj.180.1674748905603; Thu, 26 Jan 2023 08:01:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXubKz9mreJd52YDUotB5H7+6tgywAm9isqWvkSfl2BsSpjo3ycARGzxROCl4Ad02WO62xmE5vo2rv3U+MoxK0I= X-Received: by 2002:a2e:99d3:0:b0:27f:b473:f5c3 with SMTP id l19-20020a2e99d3000000b0027fb473f5c3mr1868459ljj.180.1674748903748; Thu, 26 Jan 2023 08:01:43 -0800 (PST) MIME-Version: 1.0 References: <87v8kts3ol.fsf@md5i.com> In-Reply-To: <87v8kts3ol.fsf@md5i.com> From: Jonathan Wakely Date: Thu, 26 Jan 2023 16:01:32 +0000 Message-ID: Subject: Re: Minor nit in tzdb.cc To: libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 26 Jan 2023 at 15:45, Michael Welsh Duggan wrote: > > In tzdb.cc, the constant "/tzdata.zi" is used in the tzdata_stream > constructor, but the tzdata_file constant probably was meant to be used > instead (currently unused). Ah yes, good catch. I initially put the tzdata_stream in a separate file, where the constant wasn't visible. When I moved it back into tzdb.cc I forgot to reconcile that. > Should I have created a bugzilla issue rather than sending this here? > It's not really a bug, per se. It feels more like a style question. Raising it like this is fine, I will push the fix shortly. Thanks for spotting it!