On Thu, 26 Oct 2023 at 06:18, François Dumont <frs.dumont@gmail.com> wrote:

>      libstdc++: [_Hashtable] Use RAII type to manage rehash functor state
>
>      Replace usage of __try/__catch with a RAII type to restore rehash
> functor
>      state when needed.
>

I'm reviewing this now, but could I request that you attach patches as .txt
files in gmail please?

When you attach a .patch file gmail decides to give it content-type
text/x-patch and base64 encode it, and set content-disposition: attachment,
which mean it looks like this when received:

https://inbox.sourceware.org/libstdc++/7f61df18-dd99-4ff5-9fcd-8ca7820403d4@gmail.com/raw

It's hard to reply inline when the patch needs to be downloaded separately.

If you name the file .txt then gmail just shows it in the mail body
(conetnt-disposition: inline) and it's much easier to reply.

Anyway, I'll finish reviewing this one now that I've downloaded it and
manually pasted the patch into my reply.



>
>      libstdc++-v3/ChangeLog:
>
>              * include/bits/hashtable_policy.h (_RehashStateGuard): New.
>              (_Insert_base<>::_M_insert_range(_IIt, _IIt, const
> _NodeGet&, false_type)):
>              Adapt.
>              * include/bits/hashtable.h (__rehash_guard_t): New.
>              (__rehash_state): Remove.
>              (_M_rehash): Remove.
>              (_M_rehash_aux): Rename into _M_rehash.
>              (_M_assign_elements, _M_insert_unique_node,
> _M_insert_multi_node): Adapt.
>              (rehash): Adapt.
>
>
> Tested under Linux x64.
>
> Ok to commit ?
>
> François
>