From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 99C7939A002B for ; Fri, 4 Jun 2021 20:30:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99C7939A002B Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-yxxkpwo6PiK95wo1qZ89zQ-1; Fri, 04 Jun 2021 16:30:28 -0400 X-MC-Unique: yxxkpwo6PiK95wo1qZ89zQ-1 Received: by mail-wr1-f69.google.com with SMTP id g14-20020a5d698e0000b0290117735bd4d3so4455395wru.13 for ; Fri, 04 Jun 2021 13:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UG4qbh422JDPZPH9/+zV8aU1r/3s1KpaIig5ZNrO8sk=; b=bQiAgrmq10iFOmqcOHURQQjt/azUprJXQ7P/YeTXHBLJ5LtL2szQXLsWONS9ud9yJ/ +rFUN0OfVDkdNTBdEYwAkqI/N9YiUPm3inMzZ47oMw4SYC/Ms8BUPCSuDIwOGuKLMNVj +J9E5IVp/4B6IDQici/1gJwKN3dt5gs5YJO7SAx+W/yq7nUeRcWZP0glVNYC4C3MF6C/ 3Trd7imZpRQJVXegZ/c4PmTHZg9sRtpRIdZDzIWzpDxYoloZwuGuQbGHzF8ok8eWW0wW /qZE6fmGd8B0HvqligPHy3Xd++8ZH6liPtxDt7KP4H0iIh3Z3bu7WASL0o0RoIfEzb11 rptg== X-Gm-Message-State: AOAM533nQAQs1SD4CRC4eQ8pmnHfU5hoD8em3WxBytVhbIDifEsJsIuS pNhHRQyNxA4ZH2hQc6uYy9TUM52jXUbuxpMB+FqCT79nRF7pBxvs7orjlGYINAPDJpGXQpjsdAu W+w6SHrUO/W95k/P/eKv4dwwOuoXEyrU= X-Received: by 2002:adf:eed2:: with SMTP id a18mr5548533wrp.147.1622838627153; Fri, 04 Jun 2021 13:30:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz66JjvqBoEXpGxynhQINfKY4Xqe9xzDyRxT4ZAYam49r9Y31ZUIkdYwDlwuRPioph9J0zTZ0969clNb5RQ+g= X-Received: by 2002:adf:eed2:: with SMTP id a18mr5548510wrp.147.1622838626896; Fri, 04 Jun 2021 13:30:26 -0700 (PDT) MIME-Version: 1.0 References: <20210604195156.706986-1-rodgert@appliantology.com> In-Reply-To: <20210604195156.706986-1-rodgert@appliantology.com> From: Jonathan Wakely Date: Fri, 4 Jun 2021 21:30:15 +0100 Message-ID: Subject: Re: [PATCH] [libstdc++] Remove unused hasher instance. To: Thomas Rodgers Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, Thomas Rodgers X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 20:30:33 -0000 On Fri, 4 Jun 2021 at 20:54, Thomas Rodgers wrote: > This is a remnant of poorly executed refactoring. > OK for trunk and gcc-11, thanks. > libstdc++-v3/ChangeLog: > > * include/std/barrier (__tree_barrier::_M_arrive): Remove > unnecessary hasher instantiation. > --- > libstdc++-v3/include/std/barrier | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libstdc++-v3/include/std/barrier > b/libstdc++-v3/include/std/barrier > index fd61fb4f9da..4210e30d1ce 100644 > --- a/libstdc++-v3/include/std/barrier > +++ b/libstdc++-v3/include/std/barrier > @@ -103,7 +103,6 @@ It looks different from literature pseudocode for two > main reasons: > static_cast<__barrier_phase_t>(__old_phase_val > + 2); > > size_t __current_expected = _M_expected; > - std::hash __hasher; > __current %= ((_M_expected + 1) >> 1); > > for (int __round = 0; ; ++__round) > -- > 2.26.2 > >