From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by sourceware.org (Postfix) with ESMTPS id 741CB3858280
 for <libstdc++@gcc.gnu.org>; Tue,  5 Jul 2022 18:02:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 741CB3858280
Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com
 [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-393-An42Z0VGM-m5vx-YhtCdSw-1; Tue, 05 Jul 2022 14:02:46 -0400
X-MC-Unique: An42Z0VGM-m5vx-YhtCdSw-1
Received: by mail-qt1-f198.google.com with SMTP id
 e14-20020ac8010e000000b00316edc1a792so9974920qtg.18
 for <libstdc++@gcc.gnu.org>; Tue, 05 Jul 2022 11:02:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=WK0lqLP44YHNGQlL7+okCCkSfznddO/T3OjJjDvxBZk=;
 b=qELuevdhEZjJZcWFB7dViUxbl840bii0C5h3WlDqfNCcKovphZJAkIMObaAbsmUCVw
 GOj2X9J8c4Byuo2Pz7HtmDeq/ieNws5aUlCXREjW9PAaDAncADOc4gAn3/XcO8SA7rqr
 3ZilUX2kIcQVs2BxoyoGeJKwzMlLLvSA4W0Pg4ldMRbBufQyVJ3XCQValXHg+OimzEpI
 v+JFrxtePx07VObW1+ltcgnqEhX+wtuzCNgspOL5dlw36AvLJxCrqhenvD6LyfgJ3vmu
 ufBYPgHfS46moCg5ZPMgVGL7mh5rxQKjmqRHT3NqxU7ms3UjerKMOKiwhcx18A5mQxJi
 Mnug==
X-Gm-Message-State: AJIora9C0//uUq3y0c99YcTZbEvt4NkpsLLak/5tRpJ9FdPXxY8emqUF
 XAok93fvGr/5LwWjjE6PMt7z5BAmMh7DmWRpL5U6V3zPspaMe+F/nl8R8vF2G0oSeIXmEfd6Nk7
 qVGzgNrvATw4RcrPpOZEw5Lmk63cvYU0=
X-Received: by 2002:ac8:5cd3:0:b0:31d:3adc:bd00 with SMTP id
 s19-20020ac85cd3000000b0031d3adcbd00mr18355122qta.594.1657044165427; 
 Tue, 05 Jul 2022 11:02:45 -0700 (PDT)
X-Google-Smtp-Source: AGRyM1uWQp62erVJh+NAitrgUwryrZuYzHpdseayc/233RzoT/quuUaE8D2ZaegINUBKEbK+v8fue8ukOtlzbKrNF50=
X-Received: by 2002:ac8:5cd3:0:b0:31d:3adc:bd00 with SMTP id
 s19-20020ac85cd3000000b0031d3adcbd00mr18355087qta.594.1657044165183; Tue, 05
 Jul 2022 11:02:45 -0700 (PDT)
MIME-Version: 1.0
References: <orv8st9qt6.fsf@lxoliva.fsfla.org>
 <CACb0b4mTtAWt0LVqw88iuJ5teY0-6RyKAB6krHYRWKABPPSZ8Q@mail.gmail.com>
 <or5ykr4nj5.fsf@lxoliva.fsfla.org>
 <CACb0b4nWjuStDVMPjGGEOeej52QsG5Ubf7TwhASSne=zgq+j6Q@mail.gmail.com>
 <orr13azc3e.fsf@lxoliva.fsfla.org> <ory1x8orgh.fsf@lxoliva.fsfla.org>
 <CACb0b4n6n_aj_0_YUrZH51+6qFbVDesC_tGEVps9QYsmCOcyUQ@mail.gmail.com>
 <or4jzvpi5m.fsf@lxoliva.fsfla.org>
In-Reply-To: <or4jzvpi5m.fsf@lxoliva.fsfla.org>
From: Jonathan Wakely <jwakely@redhat.com>
Date: Tue, 5 Jul 2022 19:02:34 +0100
Message-ID: <CACb0b4nEVAs+pPr=DcuvPYLomc_+isYayQGWyfGj1jjNuxdWww@mail.gmail.com>
Subject: Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp
To: Alexandre Oliva <oliva@adacore.com>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>, gcc Patches <gcc-patches@gcc.gnu.org>,
 Joel Brobecker <brobecker@adacore.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2022 18:02:48 -0000

On Tue, 5 Jul 2022 at 18:46, Alexandre Oliva <oliva@adacore.com> wrote:
>
> On Jul  5, 2022, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> > The cast itself is fine, but I'd like a comment like "N.B. pid_t is a
> > pointer on vxworks" so I don't "simplify" it again.
>
>
> libstdc++: testsuite: why cast getpid result
>
> Add a comment next to the getpid call to explain why the typecast is
> needed.
>
> Regstrapped on x86_64-linux-gnu, will install later today if there's no
> objection.


Thanks.