From: Jonathan Wakely <jwakely@redhat.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH v2 2/2] libstdc++: implement std::generator
Date: Thu, 4 Jan 2024 12:57:31 +0000 [thread overview]
Message-ID: <CACb0b4nEyzdNuyuBbQEu1mNyHBs55eXs8FGkQ2NJ_NT9MtOyZA@mail.gmail.com> (raw)
In-Reply-To: <877ckpgvef.fsf@aarsen.me>
On Thu, 4 Jan 2024 at 12:01, Arsen Arsenović <arsen@aarsen.me> wrote:
>
>
> Jonathan Wakely <jwakely@redhat.com> writes:
>
> > On Thu, 21 Dec 2023 at 21:26, Arsen Arsenović wrote:
> >> +
> >> + template<typename _A>
> >> + concept _Stateless_alloc = (allocator_traits<_A>::is_always_equal::value
> >> + && default_initializable<_A>);
> >
> > The _A here is a BADNAME and needs to be more than one letter.
> >
> > FAIL: 17_intro/badnames.cc -std=gnu++23 (test for excess errors)
> > Excess errors:
> > /home/test/src/gcc/libstdc++-v3/testsuite/17_intro/badnames.cc:61:
> > error: expected nested-name-specifier before '_A'
>
> Ah - my bad, will fix, and push along with that typo fix that Will
> Hawkins mentioned.
Thanks (and thanks, Will).
prev parent reply other threads:[~2024-01-04 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 20:01 [PATCH v2 0/2] libstdc++: generators v2 Arsen Arsenović
2023-12-21 20:01 ` [PATCH v2 1/2] libstdc++: add missing include in ranges_util.h Arsen Arsenović
2023-12-21 21:37 ` Jonathan Wakely
2023-12-21 20:01 ` [PATCH v2 2/2] libstdc++: implement std::generator Arsen Arsenović
2023-12-21 21:51 ` Jonathan Wakely
2023-12-26 20:28 ` Will Hawkins
2023-12-26 23:04 ` Arsen Arsenović
2024-01-04 10:30 ` Jonathan Wakely
2024-01-04 12:00 ` Arsen Arsenović
2024-01-04 12:57 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4nEyzdNuyuBbQEu1mNyHBs55eXs8FGkQ2NJ_NT9MtOyZA@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).