From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2CC993857022 for ; Mon, 12 Sep 2022 09:25:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2CC993857022 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662974703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mwmRhwUF7qEspWnXx8ppH7Amou1lKKujI6n4XdMlc7w=; b=P6bGVOEtL9ocyA2hjmU6iUJ+W6/C32ft1dbz23gqaprL5eIFzvTQ4PozK4Rs1qNsrB4Nb9 YS3WYGJ5n5JQq05DbMoW7xg4pMxpcQc+c9oKe/yX7Z5rYBSF5GRqeu/HetEBGVXozaIqV3 5e1tpl6eeCFmTeAsCloGFCtGmt3/aCU= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-478-GWLMMilvO8GtV_IiKS7_CA-1; Mon, 12 Sep 2022 05:25:02 -0400 X-MC-Unique: GWLMMilvO8GtV_IiKS7_CA-1 Received: by mail-qk1-f197.google.com with SMTP id bk21-20020a05620a1a1500b006be9f844c59so6810219qkb.9 for ; Mon, 12 Sep 2022 02:25:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=mwmRhwUF7qEspWnXx8ppH7Amou1lKKujI6n4XdMlc7w=; b=Jj2omE9zUvE55cD+cuZRJV/n8pzeUyw1q+Bm1kS3hJqvL4CiK7XtLXwLfARZG2BU9+ Hl0FvVpuhqbQCB57bnH7cISturW2ATQmDhMOsFwEjUwzNBCWTnnvm/hBhzUu9Ml4H6pk ndhnPYnup9cni3vHIYBytWSQYXFklqoj59fHj8QU4M5K7Tmi1AEpT7KFnH7i+qrzOWDy THh0nxiSx4j6nTPSzfrygjL1GB/8XOxm8Xm4q6St5nAuoJea8H851rFwgGsHkjEkgQws +OOVlMsVS2aoPNnLfcY7+7me9Th28j9chMcOnfZAYGf9JOogoMk6G+ezQRhlp/VILLiO hCHQ== X-Gm-Message-State: ACgBeo3KRvPIe51P93cMML3WnqRsj0ZrkbU6LMXNEfW3rgFn3ICkWVZc gZOgIyHAc/orX9nCVNz/+YSbJx+rMwQ1qM5NRATCak5Khkk24C0lgq9weySduhqd3ZKRmj7Df4n xb3AGhrZ6cEf/qkyOx6OMeXYHMEVOx74= X-Received: by 2002:a05:620a:c9b:b0:6cb:cde2:27b5 with SMTP id q27-20020a05620a0c9b00b006cbcde227b5mr12997881qki.293.1662974701696; Mon, 12 Sep 2022 02:25:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR7HN3vKRHTjvlpNeBLisJIXuG8nFskgOHImDj6cYuBV+/BefoDQPO9tsNkrjGQms0veB5eHoPx37AVneOYpCZ8= X-Received: by 2002:a05:620a:c9b:b0:6cb:cde2:27b5 with SMTP id q27-20020a05620a0c9b00b006cbcde227b5mr12997879qki.293.1662974701523; Mon, 12 Sep 2022 02:25:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 12 Sep 2022 10:24:50 +0100 Message-ID: Subject: Re: Patch ping^3 ([PATCH] libstdc++: Outline the overlapping case of string _M_replace into a separate function [PR105329]) To: Jakub Jelinek Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 12 Sept 2022 at 10:16, Jakub Jelinek wrote: > > On Wed, Aug 31, 2022 at 11:38:58AM +0200, Jakub Jelinek via Gcc-patches wrote: > > On Wed, Aug 10, 2022 at 01:27:51PM +0200, Jakub Jelinek via Gcc-patches wrote: > > > On Wed, Jul 27, 2022 at 11:33:29AM +0200, Jakub Jelinek via Gcc-patches wrote: > > > > The following patch is partially a workaround for bogus warnings > > > > when the compiler isn't able to fold _M_disjunct call into constant > > > > false, but also an optimization attempt - assuming _M_disjunct (__s) > > > > is rare, the patch should shrink code size for the common case and > > > > use library or for non-standard instantiations an out of line > > > > function to handle the rare case. > > > > > > I'd like to ping this patch. > > > > I'd like to ping this patch again. > > https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598896.html > > Ping again. OK for trunk, sorry for the slow review.