From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 329503835E23 for ; Wed, 7 Dec 2022 20:07:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 329503835E23 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670443630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aOmOgUQ+lZKjrkTEjDclVV8c6cqnqRjn6PjFMu930wg=; b=BUzosKkMw3Blqg5Vfyc8P/hab730rdlsWwgukyoXEPA6eS+xW5gqYeDFPJHcz9KbhuQnLd 7mXGe3Up/Y01fxr4GGHxvmu5/XiqhiXtgLwYSIHvbPLkNW5/rOe+G2RgoTUb/IUHqYYgTp TsOkirpEnKeVGQeVLg98XmaaQCP+cc4= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-250-x_8XyXPyMwmuROH-JFC3zg-1; Wed, 07 Dec 2022 15:07:09 -0500 X-MC-Unique: x_8XyXPyMwmuROH-JFC3zg-1 Received: by mail-ej1-f69.google.com with SMTP id sh37-20020a1709076ea500b007c09b177cd1so3932230ejc.12 for ; Wed, 07 Dec 2022 12:07:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aOmOgUQ+lZKjrkTEjDclVV8c6cqnqRjn6PjFMu930wg=; b=8G0/ZvCqEFTrQHAjMsB2IXDOuxJRVzjW+2csWFpqT+Je6PlYYOYiKShFN2PVRbESFb tigy0X2P4xQRIZK3KDqm7u8XKQ5w7WQqWwd4dOzbLlEk002B1M4VzdfnPNK7PYr/867c XJ9i2LGpErodeQgOyAkQ/6mR9sEckTfNSNXo5ncNYwsZFSWYodPXd6rUlR0qwshPlSgS MH71BzbnXVe1hpNtVn4HEOCvsrH2UQr4oIREg3owuxMkVxChEkPMKXDSTFPvkq4fgKME u14qqbJOUPCKdBjsTZUMFX8DtuiguzXAVze0o2De316ONSfTC7lFiH/uHDuzRJPhMIk4 yQ3A== X-Gm-Message-State: ANoB5pmn/f7MBV6x/fqnc9W4le6piJUOT5wsGkmu5NLNdfvFC8U8OAN0 zBd7k4tv3yljtQT/hY+A/QQv/ApXNByXvKxSCpcZUoTHFWYdLQ6QfXigb551OjvwP/4X/EiFaEi iKDq/QNTXwySjoKtWI/XR98+W3UBjVSM= X-Received: by 2002:a17:907:c719:b0:7ae:31a0:e22f with SMTP id ty25-20020a170907c71900b007ae31a0e22fmr37373515ejc.248.1670443628686; Wed, 07 Dec 2022 12:07:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf6ExRaeVM9ovxHdi9b4R4M1BBAVV2FvUDpzzx+BUJe+kkx9XPeFNkT8+kk3PFycwCAsQuWedWRrTGcGk364Z1E= X-Received: by 2002:a17:907:c719:b0:7ae:31a0:e22f with SMTP id ty25-20020a170907c71900b007ae31a0e22fmr37373502ejc.248.1670443628412; Wed, 07 Dec 2022 12:07:08 -0800 (PST) MIME-Version: 1.0 References: <20221129214107.25572-1-gcc@hazardy.de> <830aca53-fd19-2556-28b0-30ebff17df8c@gmail.com> <53263b31-c704-78ff-4cba-212c9a18a3c6@gmail.com> In-Reply-To: <53263b31-c704-78ff-4cba-212c9a18a3c6@gmail.com> From: Jonathan Wakely Date: Wed, 7 Dec 2022 20:06:57 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Add error handler for To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: =?UTF-8?B?QmrDtnJuIFNjaMOkcGVycw==?= , libstdc++@gcc.gnu.org, gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 7 Dec 2022 at 17:58, Fran=C3=A7ois Dumont wr= ote: > > Looks perfect to me, thanks. OK thanks, it's pushed to trunk now. > > On 06/12/22 22:44, Jonathan Wakely wrote: > > On Wed, 30 Nov 2022 at 18:00, Fran=C3=A7ois Dumont wrote: > >> On 30/11/22 14:07, Jonathan Wakely wrote: > >>> On Wed, 30 Nov 2022 at 11:57, Jonathan Wakely wr= ote: > >>>> > >>>> On Wed, 30 Nov 2022 at 11:54, Jonathan Wakely w= rote: > >>>>> > >>>>> On Wed, 30 Nov 2022 at 06:04, Fran=C3=A7ois Dumont via Libstdc++ wrote: > >>>>>> Good catch, then we also need this patch. > >>>>> Is it worth printing an error? If we can't show the backtrace becau= se of an error, we can just print nothing there. > >> No strong opinion on that but if we do not print anything the output > >> will be: > >> > >> Backtrace: > >> > >> Error: ... > >> > >> I just considered that it did not cost much to report the issue to the > >> user that defined _GLIBCXX_DEBUG_BACKTRACE and so is expecting a backt= race. > >> > >> Maybe printing "Backtrace:\n" could be done in the normal callback > >> leaving the user with the feeling that _GLIBCXX_DEBUG_BACKTRACE does n= ot > >> work. > > OK, how's this? > > > > Tested x86_64-linux. > >