public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Michael Levine <mlevine55@bloomberg.net>
Cc: libstdc++@gcc.gnu.org, gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: std/ranges - Remove a duplicate define directive
Date: Thu, 11 Jan 2024 20:17:10 +0000	[thread overview]
Message-ID: <CACb0b4nWhS_tjiJZYPw5_1X1CJ_Fp9QV68M+y_f=Zgk1V6EuXQ@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4=0RxAY66+BtntisUnSx7vuk0cUDta+1tHsRtcvLtfZLA@mail.gmail.com>

On Wed, 10 Jan 2024 at 23:31, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On Wed, 10 Jan 2024 at 21:28, Michael Levine (BLOOMBERG/ 120 PARK)
> <mlevine55@bloomberg.net> wrote:
> >
> > From a67cfd07ce27a62f764b381268502acb68b6bad9 Mon Sep 17 00:00:00 2001
> > From: Michael Levine <mlevine55@bloomberg.net>
> > Date: Wed, 10 Jan 2024 15:48:46 -0500
> > Subject: [PATCH 1/2] Removed a duplicate define directive for
> > __glibcxx_want_ranges_iota
> >
> > Signed-off-by: Michael Levine <mlevine55@bloomberg.net>
> > ---
> > libstdc++-v3/include/std/ranges | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges
> > index 81a857502e3..ae857f8c7fc 100644
> > --- a/libstdc++-v3/include/std/ranges
> > +++ b/libstdc++-v3/include/std/ranges
> > @@ -59,7 +59,6 @@
> > #define __glibcxx_want_ranges_chunk_by
> > #define __glibcxx_want_ranges_enumerate
> > #define __glibcxx_want_ranges_iota
> > -#define __glibcxx_want_ranges_iota
> > #define __glibcxx_want_ranges_join_with
> > #define __glibcxx_want_ranges_repeat
> > #define __glibcxx_want_ranges_slide
>
> Thanks for the patch, this looks obviously correct.
>
> Please note that all patches need to go to the gcc-patches list (as
> well as the more specific list, like this one, so e.g. add both to the
> email's To: header, or CC one of them).
>
> Also please don't touch the ChangeLog file in patches. We have been
> auto-generating the ChangeLog files nightly for some years now, so you
> should not edit them manually (and including it in the patch just
> means the patch won't apply cleanly after the next time the file is
> regen'd).
>
> But I can take care of that and apply the patch, there's no need for a
> corrected patch. Thanks again for the contribution.

Pushed to trunk now, thanks again.


      reply	other threads:[~2024-01-11 20:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10 21:23 Michael Levine (BLOOMBERG/ 120 PARK)
2024-01-10 23:31 ` Jonathan Wakely
2024-01-11 20:17   ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACb0b4nWhS_tjiJZYPw5_1X1CJ_Fp9QV68M+y_f=Zgk1V6EuXQ@mail.gmail.com' \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=mlevine55@bloomberg.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).