From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C63EC3858D1E for ; Thu, 11 Jan 2024 20:17:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C63EC3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C63EC3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705004250; cv=none; b=oXXq2V+ITrUx8I7Jzxm0VCbOEvIMBlCcf1lueMNSDGo9VrdSjPCL5rav31KFzgB84mfwMVAZo3y/e+VFv6btkT+L0bb0U1Hwf7aZXaI+5e+jvYenYgYG0ElaJ31VGoidqiWKNUJJbncAqF8lfrXpgkx8mxLJOcleL/1jB4oLSh8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705004250; c=relaxed/simple; bh=GVxA8SOLNfgxaf2AKiFpNvBp8CSr/z5ZzC0pIwOWN+I=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=nQQ1mEIuJdrxm7IeMtYaFgLdTj47aqcnr/RAjBTNEBZQdw6U2o/qiO/AkAsI+m5mU7pRX0pb8eQVdeLysJnPKt9Zu+bHQl/Ph4AJkQ2agvhErEu0J0EMgjZFtaI+P1AEZOq0V1469e/b4u1e74Uw9BvRh8hgZHDvPiZmebBckXY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705004248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GVxA8SOLNfgxaf2AKiFpNvBp8CSr/z5ZzC0pIwOWN+I=; b=Ewvam+UbsiSnkEAEP9W8YEnO/xnhcKi1G3puYzR+QGVwazm6uJd8u8TTbz+FTzrwV7vAwo Q6tbU0TGb9U1Sbq7jWz3izacigmLnWFXGHKDfalOEYueVdFvySfksbKOJSNR1068xGElSa L7g7kGdYJrfuBhi9swd0G9BSyLEaFjU= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-ormf3lahMtO8A7yiewBHqg-1; Thu, 11 Jan 2024 15:17:27 -0500 X-MC-Unique: ormf3lahMtO8A7yiewBHqg-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5eb6dba1796so108111057b3.1 for ; Thu, 11 Jan 2024 12:17:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705004246; x=1705609046; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GVxA8SOLNfgxaf2AKiFpNvBp8CSr/z5ZzC0pIwOWN+I=; b=vRbOkjfSWRoTJB0ff2K7l20405Ii5WDAL05GSgH5ymF2Q1JLcW5pDju03T5L6mMCCZ tpvAfmaG6IXmog6hA05VRCqeXlge8bXdVCsFer0AhFMkUCuqfD1y1NvyWou0rwjsK/u7 /2QRvAEh/Q6XaZmspswGAh6dabDfzYUOL4nLJLrigDzN4Mc0W7iPcS9wz686vgGFKPjC nOSmGmpvCvcCrV1r/vvqtd+EqS+QsZNHmTYtt4Iyhcm8ngSeD/E0zSrRJiYlTZFn4w2i rax7MlldO7v/ByleIACA4msNdDZWy3cJjNmEs8PcYi8XwuhVUFblbdP6nIzxfa8cMPdS RI4w== X-Gm-Message-State: AOJu0YyiWAdZVOJrkdP8egHRJbz0seF9sdF2mtRKYurcbRjWrIWSFsuu 3+3HCMMpVzXJ1fbLGub/04KgPKzLSDi/HyUpClgOG2axiMplifKBcsLufviyRx+bBpn8mWFthod GjC91b6iCcHHhSVlcsYAkSARR8OrE3VjyHky4NNQ= X-Received: by 2002:a25:c754:0:b0:dae:8e90:e3d5 with SMTP id w81-20020a25c754000000b00dae8e90e3d5mr192014ybe.23.1705004246637; Thu, 11 Jan 2024 12:17:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHTq/h76W/Qxnzy6NnUQn3y8spStorKoGg5RVBCHM6MqbIZjSzK9mdLegWWE4kIG9uIDwJIVjPTRfSSDl8h5Ow= X-Received: by 2002:a25:c754:0:b0:dae:8e90:e3d5 with SMTP id w81-20020a25c754000000b00dae8e90e3d5mr192007ybe.23.1705004246344; Thu, 11 Jan 2024 12:17:26 -0800 (PST) MIME-Version: 1.0 References: <659F0AD8000248DD0C340001@message.bloomberg.net> In-Reply-To: From: Jonathan Wakely Date: Thu, 11 Jan 2024 20:17:10 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: std/ranges - Remove a duplicate define directive To: Michael Levine Cc: libstdc++@gcc.gnu.org, gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 10 Jan 2024 at 23:31, Jonathan Wakely wrote: > > On Wed, 10 Jan 2024 at 21:28, Michael Levine (BLOOMBERG/ 120 PARK) > wrote: > > > > From a67cfd07ce27a62f764b381268502acb68b6bad9 Mon Sep 17 00:00:00 2001 > > From: Michael Levine > > Date: Wed, 10 Jan 2024 15:48:46 -0500 > > Subject: [PATCH 1/2] Removed a duplicate define directive for > > __glibcxx_want_ranges_iota > > > > Signed-off-by: Michael Levine > > --- > > libstdc++-v3/include/std/ranges | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges > > index 81a857502e3..ae857f8c7fc 100644 > > --- a/libstdc++-v3/include/std/ranges > > +++ b/libstdc++-v3/include/std/ranges > > @@ -59,7 +59,6 @@ > > #define __glibcxx_want_ranges_chunk_by > > #define __glibcxx_want_ranges_enumerate > > #define __glibcxx_want_ranges_iota > > -#define __glibcxx_want_ranges_iota > > #define __glibcxx_want_ranges_join_with > > #define __glibcxx_want_ranges_repeat > > #define __glibcxx_want_ranges_slide > > Thanks for the patch, this looks obviously correct. > > Please note that all patches need to go to the gcc-patches list (as > well as the more specific list, like this one, so e.g. add both to the > email's To: header, or CC one of them). > > Also please don't touch the ChangeLog file in patches. We have been > auto-generating the ChangeLog files nightly for some years now, so you > should not edit them manually (and including it in the patch just > means the patch won't apply cleanly after the next time the file is > regen'd). > > But I can take care of that and apply the patch, there's no need for a > corrected patch. Thanks again for the contribution. Pushed to trunk now, thanks again.