From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5F5033861009 for ; Fri, 13 Jan 2023 16:40:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F5033861009 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673628014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OlEBsCY0lC25JsBORKTex/DnST97HuEY3fSmb4RKq3k=; b=S+TOUvTtFLoxhH5oky9guCJje5+VPs4luo0BnLmNOIA5FwHm4ekcYClIIoouX+KKNNYU1M H9i5PpDC6ohZuYAKYK0uewqbKh8vJamnr1Q7HL4Skjq1dvSVK8ZuJWfaQEs2DRjuaVsGEi AY8PxjX0OaxkwHqe2gB6Lk06rNz1wG8= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-453-j6mTfe8sObOJ042MRRr96A-1; Fri, 13 Jan 2023 11:40:12 -0500 X-MC-Unique: j6mTfe8sObOJ042MRRr96A-1 Received: by mail-lj1-f200.google.com with SMTP id y9-20020a05651c154900b0028571631915so4386437ljp.18 for ; Fri, 13 Jan 2023 08:40:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OlEBsCY0lC25JsBORKTex/DnST97HuEY3fSmb4RKq3k=; b=TokU9CP5pZHezVNRHvxY/tCFjA3wNH6byapMeIWt4u0tMDbU+YY4comXJEdC7iEtIb L3ZMlDJBXLMATqKZGenz9elobjbAFrkwFehW2MGCGvQjSr9CxAbTWkblu+RaJDZL8Lhs qNp8/kwX9MR9Zk8Yy9k4wbwGNaVihcbztY5I475Q2d3uib/c/CJB4xfLOn1mRAZjcfV0 UEegWmP7ZHiV8FXgsgBDPBTQps2xEh4kDChdfUWvV7q5BWdZfJC52w2F+/+deeQCHN9Q 2j8+mDdwq6w3ku7pfCofFHvPB6w+XKghp9JFf+wmjpo+uL6/SYN+hIge8/iyFrzocul/ fiog== X-Gm-Message-State: AFqh2krqGYoi5ZqI8aaP7RrE9Amiu5s5IXCVulhJtRzIgWjx/LA7VDIM 2gh69Au74OSixVIXvZ5C/h8Dm3XK1y0CZ9Ohp4Nc8y/NySWrPu/Yx7wUO+V9yih+gkeE7oaE3Lh G1U4489x/lex6YMj9i37Xsk0tQQZQhbw= X-Received: by 2002:ac2:5b41:0:b0:4b5:5f2b:ddf6 with SMTP id i1-20020ac25b41000000b004b55f2bddf6mr3168710lfp.17.1673627979956; Fri, 13 Jan 2023 08:39:39 -0800 (PST) X-Google-Smtp-Source: AMrXdXu+Zuk7w8KCr1GsDuqLyF1DnKwxGMvodvqQEvmQNstlPqzaBsKXX1FzPNWWqtW79wMY1YGRp6V4J6Mrce/+ovI= X-Received: by 2002:ac2:5b41:0:b0:4b5:5f2b:ddf6 with SMTP id i1-20020ac25b41000000b004b55f2bddf6mr3168708lfp.17.1673627979734; Fri, 13 Jan 2023 08:39:39 -0800 (PST) MIME-Version: 1.0 References: <20230113001546.944147-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 13 Jan 2023 16:39:28 +0000 Message-ID: Subject: Re: [committed] libstdc++: Do not include in concurrency headers To: Rainer Orth Cc: Jonathan Wakely via Gcc-patches , libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000038115e05f227e1fd" X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000038115e05f227e1fd Content-Type: text/plain; charset="UTF-8" On Fri, 13 Jan 2023 at 15:08, Rainer Orth wrote: > > Hi Jonathan, > > > The , , and headers use > > std::errc constants, but don't use std::system_error itself. They only > > use the __throw_system_error(int) function, which is defined in > > . > > > > By including the header for the errc constants instead of the whole of > > we avoid depending on the whole std::string definition. > > it seems this patch broke many tests on Solaris, e.g. > > FAIL: 29_atomics/atomic/requirements/types_neg.cc (test for excess errors) > Excess errors: > /var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/libstdc++-v3/include/bits/std_mutex.h:157: error: 'EBUSY' was not declared in this scope > Oops, testing this patch now. --00000000000038115e05f227e1fd Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lcuqvl330 Y29tbWl0IDU4ZTZmZTMzNGU1NWY1NmVlYjAyMTFjMTA2OTdiZTRkNGE4YzUyYjYKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBGcmkgSmFuIDEzIDE2 OjM3OjU3IDIwMjMKCiAgICBsaWJzdGRjKys6IEFkZCA8ZXJybm8uaD4gdG8gPGJpdHMvc3RkX211 dGV4Lmg+CiAgICAKICAgIFRoaXMgbmVlZHMgdG8gYmUgaW5jbHVkZWQgZXhwbGljaXRseSBub3cg dGhhdCB3ZSBkb24ndCBpbmNsdWRlIGFsbCBvZgogICAgPHN5c3RlbV9lcnJvcj4gaGVyZS4KICAg IAogICAgbGlic3RkYysrLXYzL0NoYW5nZUxvZzoKICAgIAogICAgICAgICAgICAqIGluY2x1ZGUv Yml0cy9zdGRfbXV0ZXguaDogSW5jbHVkZSA8ZXJybm8uaD4uCgpkaWZmIC0tZ2l0IGEvbGlic3Rk YysrLXYzL2luY2x1ZGUvYml0cy9zdGRfbXV0ZXguaCBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL2Jp dHMvc3RkX211dGV4LmgKaW5kZXggYmM1MTUzNThkMjMuLmY3NGRkYzQxMjNhIDEwMDY0NAotLS0g YS9saWJzdGRjKystdjMvaW5jbHVkZS9iaXRzL3N0ZF9tdXRleC5oCisrKyBiL2xpYnN0ZGMrKy12 My9pbmNsdWRlL2JpdHMvc3RkX211dGV4LmgKQEAgLTM2LDYgKzM2LDcgQEAKICMgaW5jbHVkZSA8 Yml0cy9jKysweF93YXJuaW5nLmg+CiAjZWxzZQogCisjaW5jbHVkZSA8ZXJybm8uaD4gLy8gRUJV U1kKICNpbmNsdWRlIDxiaXRzL2Z1bmN0ZXhjZXB0Lmg+CiAjaW5jbHVkZSA8Yml0cy9ndGhyLmg+ CiAK --00000000000038115e05f227e1fd--