From: Jonathan Wakely <jwakely@redhat.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org>,
libstdc++@gcc.gnu.org
Subject: Re: [committed] libstdc++: Do not include <system_error> in concurrency headers
Date: Fri, 13 Jan 2023 17:38:20 +0000 [thread overview]
Message-ID: <CACb0b4ncLt4oc_D6v_tY+qoWPjjMCGMDLzNC5EyyynqA1uxT4w@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4nZdOEUugsbXNEg_b==h3xaK_wB=zoaMGEAN7JQtKrvKA@mail.gmail.com>
On Fri, 13 Jan 2023 at 16:39, Jonathan Wakely wrote:
>
> On Fri, 13 Jan 2023 at 15:08, Rainer Orth wrote:
> >
> > Hi Jonathan,
> >
> > > The <condition_variable>, <mutex>, and <shared_mutex> headers use
> > > std::errc constants, but don't use std::system_error itself. They only
> > > use the __throw_system_error(int) function, which is defined in
> > > <bits/functexcept.h>.
> > >
> > > By including the header for the errc constants instead of the whole of
> > > <system_error> we avoid depending on the whole std::string definition.
> >
> > it seems this patch broke many tests on Solaris, e.g.
> >
> > FAIL: 29_atomics/atomic/requirements/types_neg.cc (test for excess errors)
> > Excess errors:
> > /var/gcc/regression/master/11.4-gcc/build/i386-pc-solaris2.11/libstdc++-v3/include/bits/std_mutex.h:157: error: 'EBUSY' was not declared in this scope
> >
>
> Oops, testing this patch now.
Pushed to trunk - thanks for the report!
next prev parent reply other threads:[~2023-01-13 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 0:15 Jonathan Wakely
2023-01-13 15:08 ` Rainer Orth
2023-01-13 16:39 ` Jonathan Wakely
2023-01-13 17:38 ` Jonathan Wakely [this message]
2023-01-16 13:21 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACb0b4ncLt4oc_D6v_tY+qoWPjjMCGMDLzNC5EyyynqA1uxT4w@mail.gmail.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).