From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 29113385842C for ; Mon, 6 Nov 2023 23:29:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29113385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29113385842C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699313347; cv=none; b=Hza50FIlpylsj1Xfq3Jn15d5lfDGJmoC9X20ghQVINiRUZfQPekpgUHqnaql7+MpEBJqm+bhtgBg0+eO11e6Ggs4r+npmKVd17L2GHPpW8dt+FWvfz+HuyUOXyMmUQk6wqpITkKuQnG/M9wDGr9mKds83N+sdSP3VN5FiIywch8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699313347; c=relaxed/simple; bh=jklRyOxHb1UtI+Y95DdhRWXHq6TUIRa77WV50BnNIZA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=E71zlG6xDAp8r9QaCVsjZBfvLkTlZA77HGAPHTKdFjkLPr3Jc4JxszKO7aN00TIWf6y6sq8N9E4DPOrfPapfyPLa4WhWp23i4GryXgSBI6Bz1zj/U7ddgA21pJy/l9fP3ENkBEOisO0inRhU4c2hBfzsdTyCF4OuCA7MzLU0bvk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699313345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zroHCtNYkiL6kGTmu2/mITHW7wqH/Yz5WXMi4xNTKoU=; b=YljpoomXb19LkGNt5SgAt2mXm3pawZkrnyBIDaZzHDjr6JufxIGHjwBLAmFhuhLPx8KOdC JA015ZAjliFLT4gwWrwDwrNoPynH4uu8XZ2ls1w/lHHGgcSOO3HeHCxv281W2+oUZxkzdm NcnsiotnvDfVL/j34/fccJnvuq6PgKA= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-PQfsM_4gMZyoh4W-8K_y5w-1; Mon, 06 Nov 2023 18:29:02 -0500 X-MC-Unique: PQfsM_4gMZyoh4W-8K_y5w-1 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-d81e9981ff4so4915321276.3 for ; Mon, 06 Nov 2023 15:29:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699313342; x=1699918142; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zroHCtNYkiL6kGTmu2/mITHW7wqH/Yz5WXMi4xNTKoU=; b=g2ACMsQVsHgEghKimk9xxLytXkdz5PlhBeC/EM9x7eNsQ9EKIRRfnpBftKNxbecnAg /EXtf6GgX8CuthcqG0fRqle61AMZjhTYVjM0ic1sypHd+DEmmq9Rx8MJS9VrT0aZOCZ0 lvAqnDlpBV9hjYzbGMm8IQvDj1TgVgZrpRHdmUlMBe3WXA3RxI3PtxEJROq5bGTsTZFS C3DkoaDLRhadc24K/MFjDr8RFfNGsBRZPeyrpkIryxqIovVFzBU7rd122vbHda2UKVmR n5KQgtH+obfFEyUiJJPSvnrXmv5TOdfVz/s4FVY+nApD6kdeHXb5nE7NWLH61a+j54Rc 0d4Q== X-Gm-Message-State: AOJu0YzAWB0LE2UzWsjuWqmqt891iOLPLH6aI8i3XXnf1+li02gIRkQL FiF0Dw3ptVBCYzATiTQlvjU9ijJvsCsGjnJ90APotySoQ+nuSwo1+sFc3mxvw/vM1mweLjgZD47 5mfZer4HcL2OmQnGmyV8NL6p8tX0WFEs= X-Received: by 2002:a25:d816:0:b0:da0:5e86:32f8 with SMTP id p22-20020a25d816000000b00da05e8632f8mr24258852ybg.4.1699313342130; Mon, 06 Nov 2023 15:29:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxuBthYU2Gx8Fvu80NAP0kw/U4citC5NQIBn6MDGZ7RgamyegR3tzS8hWoBlaTbZjDlCDBtfY48Kc30goUWK0= X-Received: by 2002:a25:d816:0:b0:da0:5e86:32f8 with SMTP id p22-20020a25d816000000b00da05e8632f8mr24258845ybg.4.1699313341924; Mon, 06 Nov 2023 15:29:01 -0800 (PST) MIME-Version: 1.0 References: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com> In-Reply-To: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com> From: Jonathan Wakely Date: Mon, 6 Nov 2023 23:28:51 +0000 Message-ID: Subject: Re: [PATCH][_Hashtable] Add missing destructor call To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 6 Nov 2023 at 21:39, Fran=C3=A7ois Dumont wr= ote: > > Noticed looking for other occasion to replace __try/__catch with RAII > helper. > > libstdc++: [_Hashtable] Add missing node destructor call > > libstdc++-v3/ChangeLog: > > * include/bits/hashtable_policy.h > (_Hashtable_alloc<>::_M_allocate_node): Add missing call to > node destructor > on construct exception. > > Tested under Linux x64, ok to commit ? OK. Is this missing on any branches too? I don't think it's actually a problem, since it's a trivial destructor anyw= ay. > > I hope gmail appli will appreciate .diff instead of .patch. .txt are not > in .gitignore so annoying to use for patches. > > Fran=C3=A7ois