From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 91A423858C27 for ; Thu, 17 Aug 2023 17:22:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91A423858C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692292940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=89/F0xkTHrKIf6Yz4eH0tb4lsq4Te2sr+6VFwA/hHgA=; b=KE3m8izBkPHMlZgMlHJfFsdUNxC0zlWtxGAwBckIngj1PTe5QfrJuf6xOQyoPJfnEVUQ4m bwV5O6MwO8WFyo2R451TKw+v/Qh08aBPQQRIXmWamjl+FXhttTUymMYS/mvLEplqI2FFJz /FcLeZSt0KeQZd2qigA7lpn7lOGs6H0= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-xVGjjs2iMQaioA0TyTDCIw-1; Thu, 17 Aug 2023 13:22:18 -0400 X-MC-Unique: xVGjjs2iMQaioA0TyTDCIw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2b9bee2d344so208011fa.1 for ; Thu, 17 Aug 2023 10:22:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692292937; x=1692897737; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=89/F0xkTHrKIf6Yz4eH0tb4lsq4Te2sr+6VFwA/hHgA=; b=hchGt//OXVgPDo/UYCL08XOwPHirQqnKrukiKbTJTQyXAqJQ9FqPFzflq2SwPcjq6w 8LEqs8Z11s+uRf25YK3uhxl/B+ZWs7xDs9Kt08ILTg25tAmImlXSIZ2A7kRRiW+RSJBp Iqemaz69Z3AabliOP/LE8jufrHlWErVikZ3HIkLFVYtEZCS8dfQxh6t2GOgZlEdAhTAz R3bjtMEaedZrVcA04KQQzNkunz1kMsPtpHmpwR3Gt/msOc4aQpavp8p/om62UckEzoAl Arf/ZWEcij6ACeBQGohZuPqe1FUd1t4nkZlJSWuvGwwDg/dRZdZ6RtMFGcogmP2z1GR3 0dow== X-Gm-Message-State: AOJu0YwVPVjr0aFZLEQ2+BMdpMBnJ2r/3oZZTUNMpHRvrnV8iLs7hO5u oUmM8etbaHJJ7+hQc3s8J5Zr2YXU8o1c8c3D+f8ODYE6uz1pFXc5284nyB4R4MR/8VGhVMEjUGJ A5uNRxqJeJq4iprpX2DIjCj9fAbWdNsw= X-Received: by 2002:a2e:95d7:0:b0:2b9:b27c:f727 with SMTP id y23-20020a2e95d7000000b002b9b27cf727mr11106ljh.8.1692292937340; Thu, 17 Aug 2023 10:22:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEL79wstrBjQZ0Dn7MTXyqHvo3oEq0czxtrd7W5FCJGH/gjgkHknwxH+GVaTrce8Vy8BdIcX2jwTx0Ml0OX88s= X-Received: by 2002:a2e:95d7:0:b0:2b9:b27c:f727 with SMTP id y23-20020a2e95d7000000b002b9b27cf727mr11086ljh.8.1692292937026; Thu, 17 Aug 2023 10:22:17 -0700 (PDT) MIME-Version: 1.0 References: <1dc681f4-41b7-d171-02ac-b0194617bdee@gmail.com> <91dc6383-6bff-ce6c-b24d-81cd2ab2dce8@gmail.com> In-Reply-To: <91dc6383-6bff-ce6c-b24d-81cd2ab2dce8@gmail.com> From: Jonathan Wakely Date: Thu, 17 Aug 2023 18:22:06 +0100 Message-ID: Subject: Re: [PATCH] sso-string@gnu-versioned-namespace [PR83077] To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: Jonathan Wakely , "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 13 Aug 2023 at 14:27, Fran=C3=A7ois Dumont via Libstdc++ wrote: > > Here is the fixed patch tested in all 3 modes: > > - _GLIBCXX_USE_DUAL_ABI > > - !_GLIBCXX_USE_DUAL_ABI && !_GLIBCXX_USE_CXX11_ABI > > - !_GLIBCXX_USE_DUAL_ABI && _GLIBCXX_USE_CXX11_ABI > > I don't know what you have in mind for the change below but I wanted to > let you know that I tried to put COW std::basic_string into a nested > __cow namespace when _GLIBCXX_USE_CXX11_ABI. But it had more impact on > string-inst.cc so I preferred the macro substitution approach. I was thinking of implementing the necessary special members functions of __cow_string directly, so they are ABI compatible with the COW std::basic_string but don't actually reuse the code. That would mean we don't need to compile and instantiate the whole COW string just to use a few members from it. But that can be done later, the macro approach seems OK for now. > > There are some test failing when !_GLIBCXX_USE_CXX11_ABI that are > unrelated with my changes. I'll propose fixes in coming days. Which tests? I run the entire testsuite with -D_GLIBCXX_USE_CXX11_ABI=3D0 several times per day and I'm not seeing failures. I'll review the patch ASAP, thanks for working on it.