From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 599623857023 for ; Fri, 17 Jun 2022 12:32:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 599623857023 Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-446-2JrHzhjKMZ2MAAZXfiS3yg-1; Fri, 17 Jun 2022 08:32:24 -0400 X-MC-Unique: 2JrHzhjKMZ2MAAZXfiS3yg-1 Received: by mail-yb1-f198.google.com with SMTP id e85-20020a25e758000000b00668ad2fcfdcso2812899ybh.8 for ; Fri, 17 Jun 2022 05:32:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n3GHOd2Qhk+Pa5Q+VVyfmtAomniEN8Ey++Z9GEw1OOc=; b=b6seuNVCv8C9dEGfXsSNBe00/UkGTGz8nBhFtevujuMcQqgsevaT6NBOjvN8Y1yiaK JWKHN3JgSCBB0zziycnrXZwjcQiX3CQKiLfNEF9P+eBdMFzdeb6/HUSLrR9Qqse+oFcy 1vVWzVeLiL4VZ2arNTmDoS2kpp7vmIHb5PXpUh9zv4IfIgu0QzkUPgUfTU+fvFPLBQHJ hN6nG5fEmM6bBvkiEgDF46t02yKj/td637SXjxihzl1Knt7FXLKoagmoGW+5BbWUO+4c L+qtxOpALJavgdq1PW0rUjJiTYxoZI6LZbfJEQN/Poi44kUApYJVvAYiwUIa8V6LlI5u 4YFg== X-Gm-Message-State: AJIora9fMJUdMES9la74OSVSmLFNWisogNLpiIiA4dIr04W3LqY+NLVw XweDz5o8nt/W2TTktfhlJy8i8IZ/ZwAYd2/Ss+OBRt21UX228qwoqBbNeUTeTbGYo2Z6S28TUg/ rpKbeuXKYD+45cRvPNokajFet3d025RI= X-Received: by 2002:a25:bd41:0:b0:668:c259:f6c2 with SMTP id p1-20020a25bd41000000b00668c259f6c2mr1565762ybm.365.1655469144348; Fri, 17 Jun 2022 05:32:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tTMd9aiGCQxjJqvYYnCnBU1t81XgiJ9yGwKNcjkZtv4iAVVL8uuyztsl6Ke8weJGBJgCfcj5OCxbeamxH9V2s= X-Received: by 2002:a25:bd41:0:b0:668:c259:f6c2 with SMTP id p1-20020a25bd41000000b00668c259f6c2mr1565744ybm.365.1655469144127; Fri, 17 Jun 2022 05:32:24 -0700 (PDT) MIME-Version: 1.0 References: <20220616192111.1199662-1-jwakely@redhat.com> In-Reply-To: <20220616192111.1199662-1-jwakely@redhat.com> From: Jonathan Wakely Date: Fri, 17 Jun 2022 13:32:12 +0100 Message-ID: Subject: Re: [committed] libstdc++: Support constexpr global std::string for size < 15 [PR105995] To: Jonathan Wakely Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000045f3b805e1a3f2c0" X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, URI_HEX autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2022 12:32:27 -0000 --00000000000045f3b805e1a3f2c0 Content-Type: text/plain; charset="UTF-8" On Thu, 16 Jun 2022 at 20:23, Jonathan Wakely via Libstdc++ wrote: > > Tested x86_64-linux, pushed to trunk. Somehow I messed up the test in the commit I pushed (but not the one I tested ... weird). Fixed at r13-1151-g0f96ac43fa0a5f by the attached patch. -- >8 -- libstdc++: Add missing #include to new test Somehow I pushed a different version of this test to the one I actually tested. libstdc++-v3/ChangeLog: * testsuite/21_strings/basic_string/cons/char/105995.cc: Add missing #include. --00000000000045f3b805e1a3f2c0 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4ifk7zv0 Y29tbWl0IDBmOTZhYzQzZmEwYTVmZGJmY2UzMTdiMjc0MjMzODUyZDViNDZkMjMKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBGcmkgSnVuIDE3IDEz OjI5OjA1IDIwMjIKCiAgICBsaWJzdGRjKys6IEFkZCBtaXNzaW5nICNpbmNsdWRlIDxzdHJpbmc+ IHRvIG5ldyB0ZXN0CiAgICAKICAgIFNvbWVob3cgSSBwdXNoZWQgYSBkaWZmZXJlbnQgdmVyc2lv biBvZiB0aGlzIHRlc3QgdG8gdGhlIG9uZSBJIGFjdHVhbGx5CiAgICB0ZXN0ZWQuCiAgICAKICAg IGxpYnN0ZGMrKy12My9DaGFuZ2VMb2c6CiAgICAKICAgICAgICAgICAgKiB0ZXN0c3VpdGUvMjFf c3RyaW5ncy9iYXNpY19zdHJpbmcvY29ucy9jaGFyLzEwNTk5NS5jYzogQWRkCiAgICAgICAgICAg IG1pc3NpbmcgI2luY2x1ZGUuCgpkaWZmIC0tZ2l0IGEvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8y MV9zdHJpbmdzL2Jhc2ljX3N0cmluZy9jb25zL2NoYXIvMTA1OTk1LmNjIGIvbGlic3RkYysrLXYz L3Rlc3RzdWl0ZS8yMV9zdHJpbmdzL2Jhc2ljX3N0cmluZy9jb25zL2NoYXIvMTA1OTk1LmNjCmlu ZGV4IGFhOGJjYmEzZGNhLi40NzY0Y2VmZjcyYSAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYzL3Rl c3RzdWl0ZS8yMV9zdHJpbmdzL2Jhc2ljX3N0cmluZy9jb25zL2NoYXIvMTA1OTk1LmNjCisrKyBi L2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjFfc3RyaW5ncy9iYXNpY19zdHJpbmcvY29ucy9jaGFy LzEwNTk5NS5jYwpAQCAtMiw2ICsyLDggQEAKIC8vIHsgZGctZG8gY29tcGlsZSB7IHRhcmdldCBj KysyMCB9IH0KIC8vIHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IGN4eDExX2FiaSB9CiAK KyNpbmNsdWRlIDxzdHJpbmc+CisKIC8vIFBSIGxpYnN0ZGMrKy8xMDU5OTUKIC8vIE5vdCByZXF1 aXJlZCBieSB0aGUgc3RhbmRhcmQsIGJ1dCBzdXBwb3J0ZWQgZm9yIFFvSS4KIGNvbnN0ZXhwciBz dGQ6OnN0cmluZyBwcjEwNTk5NV9lbXB0eTsK --00000000000045f3b805e1a3f2c0--