From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id BD290395B803 for ; Tue, 8 Jun 2021 15:44:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD290395B803 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-wIrqgHzjO_agwy0A2i8a3g-1; Tue, 08 Jun 2021 11:44:25 -0400 X-MC-Unique: wIrqgHzjO_agwy0A2i8a3g-1 Received: by mail-wm1-f70.google.com with SMTP id w3-20020a1cf6030000b0290195fd5fd0f2so917896wmc.4 for ; Tue, 08 Jun 2021 08:44:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aVZ2E4oH4yIr2C2mT0Tow//5D5qdmwL1/rtovqencC8=; b=GmOct4W6ZnE+ZIeZPnQOTz+QT4SfEOMyhBtmVVrKdLy8KDT4XRidqzbFssaGkDRxkU adhzkS0TAbJQntJLYbexIcIdLz8Z4KnvyG8CMPKO8Qb+QtUnCpN96lG/vMa22OIx/PvW AdLSpG769ouQY6J1RRlfa1RoWke8OASujRWlXRXiu2dM+2dyXxnDQVV3eJ2EY3iz0bSS Bf24R+Joo/eJC+i4XL5ChBo9/N9SQ7nUNc/PlwYz+/EKSjUOmdLwNnXUAZr6DE7kVIRQ 2wb7uoPkLJLeslYStiwGSfdUFkkC/hb4L6uHQYHgLeUY7UzbuUibSk5Huyzb2nd+mXKy IrLw== X-Gm-Message-State: AOAM531w6PaZUfl9z9l1dAXQWTvgwBHSh/62xXl/3/cLLwavdVjlZawz TFgK+kjoQOwhgSbkZhPRNZnBCR/uaI5PSel/505YkBGWmoe0xMhGFcv98ZHSBRPMbFlEbsIFur/ tvL8VSOLICp981RJSMIKAVZJ0k/AbNrI= X-Received: by 2002:a05:6000:cb:: with SMTP id q11mr23827662wrx.13.1623167064603; Tue, 08 Jun 2021 08:44:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX1DKDakolXuWyc7YIlPI0b+JEpcq9yQjw1owKggOsSCb3lhNMuZ0YJgK9MTGMaA+a6FPChcPZ4HP2fRPqYYA= X-Received: by 2002:a05:6000:cb:: with SMTP id q11mr23827636wrx.13.1623167064112; Tue, 08 Jun 2021 08:44:24 -0700 (PDT) MIME-Version: 1.0 References: <20210607220207.944400-1-rodgert@appliantology.com> <20210608002843.945023-1-rodgert@appliantology.com> In-Reply-To: <20210608002843.945023-1-rodgert@appliantology.com> From: Jonathan Wakely Date: Tue, 8 Jun 2021 16:44:12 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889] To: Thomas Rodgers Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, Thomas Rodgers X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 15:44:29 -0000 On Tue, 8 Jun 2021 at 01:29, Thomas Rodgers wrote: > This time without the repeatred [PRnnnn] in the subject line. > > Fixes libstdc++/100889 > This should be part of the ChangeLog entry instead, preceded by PR so it updates bugzilla, i.e. > libstdc++-v3/ChangeLog: > PR libstdc++/100889 > * include/bits/atomic_base.h (atomic_ref<_Tp*>::wait): > Change parameter type from _Tp to _Tp*. > * testsuite/29_atomics/atomic_ref/wait_notify.cc: Extend > coverage of types tested. > OK for trunk and gcc-11 with that change, thanks.