From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B8FEC38515E4 for ; Wed, 12 Oct 2022 11:41:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8FEC38515E4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665574883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AUpLY6csKXU1a1yEKmcrc2FEkelVnArLGlGcHsGRwCI=; b=aXS15f4o96iresYwF3mH4vTP6BoGalEQORwXIU/wozx92I+LmOPDYitLrhJn38KADcrla2 IpXG6TSD4b95zVt/EBzE/rTedAhsxeUs38cd094oEpZLg1YnKyeW3FePYNsEVf1G5wAqZ+ NKIe0zBnNfCBF7FxBcG9K5yLDiVTl/U= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-594-qiNYX1TkPXSXfXN8SN32Cg-1; Wed, 12 Oct 2022 07:41:22 -0400 X-MC-Unique: qiNYX1TkPXSXfXN8SN32Cg-1 Received: by mail-qk1-f197.google.com with SMTP id n13-20020a05620a294d00b006cf933c40feso14133850qkp.20 for ; Wed, 12 Oct 2022 04:41:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AUpLY6csKXU1a1yEKmcrc2FEkelVnArLGlGcHsGRwCI=; b=AQXtDf5v3gnqF4J5qxf8u+oQBmgg4+HIByBvYIO3b5+bw0yhWnC94ICHVTVvotGfLO eNQogO3sWnUVH0Sx4YUC+IqLZLePQcRwbQuRT3G1s106E7yZiZoOFvsZkk+juRwvK7ZY lzuh2IO9Udk9ArJFSQ0zBq+9sEVkrbWwTNuqRb9etUFWpVvBlZVmWgJkda0aEkTSkkkL MJbXZvCxT70bsgoEVhxOd4IWDPIPIrRPwt2S5PPgWOwSYU5ZuaJ77+fOxnWPbLHARNXK 35t7qz9kjk+KMPcYXA824iEWmzJ5h6g8YrFaVEoDsP7aX/yATuYyDyIjWI6b8G1cSNG9 iGZg== X-Gm-Message-State: ACrzQf07wiPXgdI98PCTep2buJRuad2qbRj8BFuGKfw5Ch+VrYbIoJrv XMZ4WMxdI+POvO49kvdVf3+4MQfHHASSm5/jXqxjrhgQCgSeuVtYxai/aMMrSR96N+vQruuwiQk cFDqxUiicqwNomvhlJkpt2cgz7B5ys+4= X-Received: by 2002:a05:622a:653:b0:39c:289c:6dec with SMTP id a19-20020a05622a065300b0039c289c6decmr6846544qtb.165.1665574882086; Wed, 12 Oct 2022 04:41:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7M2puxnSogzvbmjKcB+wcLYgYP3GTLuHSxrzO3GI2sfYFuC8SFRzAxVTV5OXhU89tS7mMaAmCLcbKhxWheLy4= X-Received: by 2002:a05:622a:653:b0:39c:289c:6dec with SMTP id a19-20020a05622a065300b0039c289c6decmr6846531qtb.165.1665574881865; Wed, 12 Oct 2022 04:41:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 12 Oct 2022 12:41:11 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: async: tolerate slightly shorter sleep To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 23 Jun 2022 at 12:38, Alexandre Oliva via Libstdc++ wrote: > > On Jun 22, 2022, Alexandre Oliva wrote: > > > Regstrapped on x86_64-linux-gnu, also tested with a cross to > > aarch64-rtems6. Ok to install? > > The early wakeups are fixed for rtems6.1, so the same question raised at > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597102.html apply to > this one: Looks like I never reviewed this one, sorry. The patch to xfail this test for rtems is OK. > > libstdc++: xfail nanosleep tests on rtems > > From: Alexandre Oliva > > Since it has been determined that nanosleep may return slightly too > early on RTEMS, due to clock resolution differences, expect > 30_thread/async tests that have detected too-early wakeups to fail on > RTEMS targets. > > > for libstdc++-v3/ChangeLog > > * testsuite/30_threads/async/async.cc: xfail on RTEMS. > > TN: V608-048 > --- > libstdc++-v3/testsuite/30_threads/async/async.cc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libstdc++-v3/testsuite/30_threads/async/async.cc b/libstdc++-v3/testsuite/30_threads/async/async.cc > index 38943ff1a9a5e..e0b731186c459 100644 > --- a/libstdc++-v3/testsuite/30_threads/async/async.cc > +++ b/libstdc++-v3/testsuite/30_threads/async/async.cc > @@ -2,6 +2,7 @@ > // { dg-additional-options "-pthread" { target pthread } } > // { dg-require-effective-target c++11 } > // { dg-require-gthreads "" } > +// { dg-xfail-if "nanosleep may wake up too early" { *-*-rtems* } } > > // Copyright (C) 2010-2022 Free Software Foundation, Inc. > // > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about >