From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0AA123858D20 for ; Wed, 12 Jul 2023 09:52:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AA123858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689155528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aQ5E9BtILGmqwtfty+QZilk3dI2MJGFjOubZ1spLYRs=; b=FqybqxqZr/KYnlRSJ7kscUhZx7KvLOjY/99GCKVwnFtofg3OyOx3pyde5DGYLaQvFPukp3 ZeEN/8zU5wrvLXXF22vs58D0+BaDjFSPpJuKy89H1/Hw0MyRvmTJGsJVkulqhIcZqf/xQg Ic81rdSGqcyaZ11LswOFcXjZ2wnMGZo= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-6mDJdMadPkm_TchdDpAVPw-1; Wed, 12 Jul 2023 05:52:06 -0400 X-MC-Unique: 6mDJdMadPkm_TchdDpAVPw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2b6ff15946fso65609391fa.2 for ; Wed, 12 Jul 2023 02:52:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689155522; x=1691747522; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aQ5E9BtILGmqwtfty+QZilk3dI2MJGFjOubZ1spLYRs=; b=Sl5O6upGqbzvTaeJ6wWqaWeArJ47EVwGrZr14KVdoWVVaV7HWiJPgb+bPY1OWWnSMu IVeeXzaJtWvFsbCnn4RA/p0UB0/D/s/HNtb6xUvNd0m8fcj3YVWj5G1NmtqafOuiGQNW WoZTW1Qjcg9U9tQoI2qxJhZsgTYtNNqmPyGm0seUZ/8BcB0rN65L6OvOKtgAZS+PI48u Wnx7xoPcd3dR00juQPOc9Mv3M5QAcu6e0u1sv69MezWG5IXYT2ns+hcszhxvE0HmePDH K/QR4RPkD+4dBU0qB4praDb/VguFYM4MSZUiOjyzVdl0eQVoyQ0TAhxa03aG/cTghbUG sVwg== X-Gm-Message-State: ABy/qLb5YWYa2e5OQWNQyX7vzrxUFjghKbDiBGHDoI6RrtEhLdnmA/2E 2GmkWaJ1NXad0eJ/2Pzd6O72geXAjKW2Sdh5ggFm5DfD+oMNdq6xUWmntkVrh80gmyW67RgAfxv I8eylVCiqsr7rKRcbk9WT52q33oZlzDnD5DAMUfg= X-Received: by 2002:a2e:9d4d:0:b0:2b6:decf:5cbf with SMTP id y13-20020a2e9d4d000000b002b6decf5cbfmr13780183ljj.32.1689155522574; Wed, 12 Jul 2023 02:52:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlF7grvz4HUu5J/qnd3SuoPU+bqp5eFr3lcKl9r5D3rwj68RY01jdaOGAUeoiFl/PGSpnm1wf21cj0PsTel95dM= X-Received: by 2002:a2e:9d4d:0:b0:2b6:decf:5cbf with SMTP id y13-20020a2e9d4d000000b002b6decf5cbfmr13780168ljj.32.1689155522310; Wed, 12 Jul 2023 02:52:02 -0700 (PDT) MIME-Version: 1.0 References: <20230703011753.18876-1-kmatsui@cs.washington.edu> <20230708045005.61988-1-kmatsui@gcc.gnu.org> In-Reply-To: <20230708045005.61988-1-kmatsui@gcc.gnu.org> From: Jonathan Wakely Date: Wed, 12 Jul 2023 10:51:51 +0100 Message-ID: Subject: Re: [PATCH v2] libstdc++: use __is_enum built-in trait To: Ken Matsui Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 8 Jul 2023 at 05:50, Ken Matsui via Libstdc++ wrote: > > This patch replaces is_enum::value with __is_enum built-in trait in > the type_traits header. > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (__make_unsigned_selector): Use > __is_enum built-in trait. > (__make_signed_selector): Likewise. > (__underlying_type_impl): Likewise. > > Signed-off-by: Ken Matsui OK for trunk, thanks! > --- > libstdc++-v3/include/std/type_traits | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 0e7a9c9c7f3..9f086992ebc 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -1740,7 +1740,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > // Select between integral and enum: not possible to be both. > template bool _IsInt = is_integral<_Tp>::value, > - bool _IsEnum = is_enum<_Tp>::value> > + bool _IsEnum = __is_enum(_Tp)> > class __make_unsigned_selector; > > template > @@ -1900,7 +1900,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > // Select between integral and enum: not possible to be both. > template bool _IsInt = is_integral<_Tp>::value, > - bool _IsEnum = is_enum<_Tp>::value> > + bool _IsEnum = __is_enum(_Tp)> > class __make_signed_selector; > > template > @@ -2353,7 +2353,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION > struct __common_type_fold<_CTp, _Rp, void> > { }; > > - template::value> > + template > struct __underlying_type_impl > { > using type = __underlying_type(_Tp); > -- > 2.41.0 >