From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id D2BAB385800F for ; Tue, 6 Sep 2022 01:06:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2BAB385800F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr Received: by mail-lj1-x230.google.com with SMTP id x10so10729126ljq.4 for ; Mon, 05 Sep 2022 18:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=h8xJWGU43CQ9OATX3f2iJqZAPa0GnOPKW2+29wTYADU=; b=rG/lQGao3t9AeU2gE2FUFXyrEwYRVbfPhbE6aWrG6chyXeOvsCtR3Ye8OVa5xxwfii TlE1OSV6rAeDWkwddN22Eo8/RiI1zmKGLKKG126qVjccTU6NV1P4nBqEwI3yGL31Nwvc 3dlbhnKbbfDvx2K9PGu79jv7uxNW9JWw62u/CsOX57PvxQFTpak3834SFTYCiu40e4qx wgByRjGlyAKIlb2xrEHgakrHmsdbvpT4IOeeJEkqvpcwulbORwabXB4tni9PSN8fwKQQ gWxbWHY8gjEcl+7Fhtyy/wRRkB3xHNKYo5qB8XN5Xgk1DhweJ/qAgZN5ZlOAqyEozLyN Ey1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=h8xJWGU43CQ9OATX3f2iJqZAPa0GnOPKW2+29wTYADU=; b=g5NjlKHltZktb4dHzn0/V9mPUihkwumFsDxi+LwwB2fvLQTfGOP9lnKhyWbo7vmET2 ShA7v6cRVVAQMp/4Ipu3fuXnIeaFrH0SZmM45KBVWuBpv6AFze1kBOF/IfVcsdfOMmPs lTYPQr9Xotu3bE8CKOF+h33uGGt4e/UPajinGfPu6wpJOghnWujf37cW682cN5/1inmG rs0nJzThmrDwHG0xkUDBo0icsfP7I3bBClwuFiDynlh529CF8WCYnoWpfAr0rFpRAQ+G 3Ux6MboVBgnCfIZYc+5WeVfVYCEhPXaEnaipEYbKygzxljW4Urr1Y5wHth66+tAm8zeJ nxcg== X-Gm-Message-State: ACgBeo0Swa4k+JVDFMbj12gqNOC75zeK3B8Vzi8mbafdROhSMIYU+UNJ ISA23zEPsG//5I85WBH9yassX/3evk/9Is/ndykLAQ== X-Google-Smtp-Source: AA6agR7s8A111p7MglryLgEmAnIbf/5+InSssjUagJX5ywDifLDhGUkzR3upSVJGLsbkuM0AvKevWmtmA6n5pZPTcms= X-Received: by 2002:a05:651c:194e:b0:268:99f1:f17e with SMTP id bs14-20020a05651c194e00b0026899f1f17emr7129903ljb.140.1662426416171; Mon, 05 Sep 2022 18:06:56 -0700 (PDT) MIME-Version: 1.0 References: <20220904184735.177348-1-fent@in.tum.de> In-Reply-To: <20220904184735.177348-1-fent@in.tum.de> From: Will Hawkins Date: Mon, 5 Sep 2022 21:06:45 -0400 Message-ID: Subject: Re: [PATCH 1/2] libstdc++: Fix pretty printer tests of tuple indexes To: Philipp Fent Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Confirming that patch 1 of 2 *does* fix the failing tests here (x86-64). Will PS: Please tell me if emails like this are helpful or not. Just trying to help! On Sun, Sep 4, 2022 at 2:48 PM Philipp Fent via Libstdc++ wrote: > > Signed-off-by: Philipp Fent > --- > libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc | 2 +- > libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc b/libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc > index cc91803e247..af335d0d3c7 100644 > --- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc > +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/48362.cc > @@ -29,7 +29,7 @@ main() > // { dg-final { note-test t1 {empty std::tuple} } } > > std::tuple> t2{ "Johnny", 5, {} }; > -// { dg-final { regexp-test t2 {std::tuple containing = {\[1\] = "Johnny", \[2\] = 5, \[3\] = empty std::tuple}} } } > +// { dg-final { regexp-test t2 {std::tuple containing = {\[0\] = "Johnny", \[1\] = 5, \[2\] = empty std::tuple}} } } > > std::cout << "\n"; > return 0; // Mark SPOT > diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc > index f97640a0189..bc5978ee69d 100644 > --- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc > +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc > @@ -166,9 +166,9 @@ main() > // { dg-final { note-test runiq_ptr {std::unique_ptr = {get() = 0x0}} } } > > ExTuple tpl(6,7); > -// { dg-final { note-test tpl {std::tuple containing = {[1] = 6, [2] = 7}} } } > +// { dg-final { note-test tpl {std::tuple containing = {[0] = 6, [1] = 7}} } } > ExTuple &rtpl = tpl; > -// { dg-final { note-test rtpl {std::tuple containing = {[1] = 6, [2] = 7}} } } > +// { dg-final { note-test rtpl {std::tuple containing = {[0] = 6, [1] = 7}} } } > > std::error_code e0; > // { dg-final { note-test e0 {std::error_code = { }} } } > -- > 2.37.3 >