From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 72E4C3858D28 for ; Fri, 19 Aug 2022 20:06:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 72E4C3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr Received: by mail-lf1-x131.google.com with SMTP id m3so1780120lfg.10 for ; Fri, 19 Aug 2022 13:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=b6mgfT4RNnIW70XVNZMbY8uCFDYYYzell+hGf+BbzTY=; b=1Vw6Hlhn4R/bbTvsov60vvmc9WjY8J0wjINkSS935EKfL/nedb2YqnAmvwQisRUI0d XY7vl23MvwN5woqdQILN7NAGWtoPqYWv1UVRqwzOsaxAE8ZwheM52FI5k2T97AiVDe0j 1SX8y7TEUMst3/IwH3a5qOLRXNk+JmE0PRLjmIEmK++Oe7U2+FqSR7Dzz/oDAhJm1gCJ 8PPKG6ptc69bdReII7n1+vxiId7TJ8qD0zZpG5XpuNJdHoItwziq6DQSNkacmX3NEsJi BjKRc+/MvKZ6kIUfp0PK9DcJhZ8poD0+jQlOTsSScIej9NyF08LGj/Z9Q9PgCtkgS++Z b8Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=b6mgfT4RNnIW70XVNZMbY8uCFDYYYzell+hGf+BbzTY=; b=jVkc/mVzpoRtRYj/561ah2flsaFXpU60nLQC1eze7IMuGdNnAyqH/GE5OVA/inEuB5 /k8qsUMBt25zwOcksEawjO9n2htpDQBMnuWbAOWME36IWJCyIDezbGDGPFFxuLhYCGqR 8z0Vxe2CjZ+6MNXqblrIOeuYEpvSpHx6htr2fcYpW8xkQIetGKmKKr7mEmc3mj6ZPirx L3fqdPgwDPoojl737LVclYU7Y1YVDj/x8RX1gyUef9xiWFOr/kl7jb0xzpI3JPrqOD/d ci+rStcoy62lPSCAk7zHMIRNcf5roZuVLg2u2mibZyuCJjWxoS0DOPpNF0hc5bnKUiFX i8gw== X-Gm-Message-State: ACgBeo3KQHDq0FSuo0u/HGrAd2fUOVD//VJAJLMPmpJPWc7f02f3GLCl Yr6Fz4j3U/0LENNq6LxRLSL1Dr7hihFYnUdFwA+iU6lYCEK9dw== X-Google-Smtp-Source: AA6agR6IOR7hpjjGIALrtFy3b0wc/MeY4YpyxPtBtH6rYGfe3GznoFrcvNaQVsjj2KpM+vUFkfKy+noP65wnpFG5q2Q= X-Received: by 2002:a05:6512:a89:b0:48b:98ed:a146 with SMTP id m9-20020a0565120a8900b0048b98eda146mr2811798lfu.525.1660939572431; Fri, 19 Aug 2022 13:06:12 -0700 (PDT) MIME-Version: 1.0 References: <20220819180034.98441-1-whh8b@obs.cr> <20220819180034.98441-2-whh8b@obs.cr> In-Reply-To: From: Will Hawkins Date: Fri, 19 Aug 2022 16:06:01 -0400 Message-ID: Subject: Re: [PATCH] libstdc++: Add std:: prefix for forward_iterator_tag To: "libstdc++" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 20:06:16 -0000 Okay! Thank you! It was the only use of forward_iterator_tag in basic_string that did not have that qualification so I just thought that it would be good to have for consistency. Thanks again, Will On Fri, Aug 19, 2022 at 2:48 PM Jonathan Wakely wrote: > > > > On Fri, 19 Aug 2022, 20:01 , wrote: >> >> From: Will Hawkins >> >> libstdc++-v3/ChangeLog: >> >> * include/bits/basic_string (basic_string(const _CharT*, size_type _, const _Alloc&)): >> Add std:: prefix to forward_iterator_tag. > > > This qualification is not necessary, there is no ADL for that expression, so name lookup cannot possibly find anything except std::forward_iterator_tag. > > N.B. patches for libstdc++ need to be CC'd to gcc-patches as well as the libstdc++ list. > > > > >> --- >> libstdc++-v3/include/bits/basic_string.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libstdc++-v3/include/bits/basic_string.h b/libstdc++-v3/include/bits/basic_string.h >> index b04fba95678..e7d7833e002 100644 >> --- a/libstdc++-v3/include/bits/basic_string.h >> +++ b/libstdc++-v3/include/bits/basic_string.h >> @@ -639,7 +639,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11 >> std::__throw_logic_error(__N("basic_string: " >> "construction from null is not valid")); >> const _CharT* __end = __s + traits_type::length(__s); >> - _M_construct(__s, __end, forward_iterator_tag()); >> + _M_construct(__s, __end, std::forward_iterator_tag()); >> } >> >> /** >> -- >> 2.34.1 >>