From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 425A03858D1E; Sat, 24 Dec 2022 05:58:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 425A03858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x231.google.com with SMTP id c129so6316802oia.0; Fri, 23 Dec 2022 21:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3y+sK8z2sTpOaKXOofKM9jdHpDrxnBMjaP8dhFxG4q8=; b=g2vqsHXsVUHGsmthQzsDcTfrNVDNQQf7cunfGkn50k8RZP+T6l+sTIkawkis/KAYzs KSd2VRhhzBX7CrIGu2GmHYCkgBkQj2CDuLA05X6hX0/JcFlOODCaLtreu6CnjFcy4Nby vPWkOHb2mWiMSG/dGjxhtiQZcUUyxSDm/5EfChMoj9np8Lt9D9moaXqavRIGVN9PlhSB tlPA/qAeEODMgazdqkxWlB12GSyX3ZBeeYV8kqnnT1itNCHhIJcjhsyJXSQHJrxuPqXY j7K8gIU4mogqEZH6orpY4uhd63yUYM5cr4hBSlNITG+0MY/TFObCzFXOhOBv+88zfWae XMUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3y+sK8z2sTpOaKXOofKM9jdHpDrxnBMjaP8dhFxG4q8=; b=GFkAoTMlNK4UY4gMmK+VgyBSMoOTvnIQakA8fV6WSj737g27aEoXh61HbqAvTPTr7p IUphEFQ7CigSTMn4M7IbiCgmPuATEYK5j6OFP5VFSqNxumdZWpt7iuqlMzHZfWvsybJ1 rKx9wE7xvowZiboyexWI9Bm/aGGO8vj7w1OlNtxlBGVfOu0pv8gOJgyrMAoVAk7zkGJL lazaZAlwqxYuWtMrDtWEkYY3KUVFmKhRiuKvmuLi96qTwp6YhhEoG7trSXxVISUb5WDH ZrlMfjZqCtDHvBno1U7qPpeptXKyn4Tst9PpnY0I/lf33FUCLnwA8+ot3dnd6/8DBsuA kuMQ== X-Gm-Message-State: AFqh2kpbGp5Zfn6W6wOYRVAK5I25zYjK5s4tdbOwCvgaUTfiuf+ltDX4 UsXOl25yPBZsGjO5tsGr1dzg1hLXEU79Rccv1K4= X-Google-Smtp-Source: AMrXdXtdlw4kiy65AcKD30Hx00xy0SZV8EgQwbHyx1Lf4bUGFizKrfK0gLQhA2xe9K6HIr9foF7JF+NftYmVUm7QbhY= X-Received: by 2002:aca:705:0:b0:35a:56f5:8631 with SMTP id 5-20020aca0705000000b0035a56f58631mr506295oih.152.1671861484582; Fri, 23 Dec 2022 21:58:04 -0800 (PST) MIME-Version: 1.0 References: <0f1f223a-3756-1da3-bd1d-b87edd34e1f9@126.com> <21655510.EfDdHjke4D@fomalhaut> <2092961.OBFZWjSADL@fomalhaut> <45c84c01-74ca-3739-6482-2bbc94de0e9a@gmail.com> <00af136c637f5231670c0fb6f7906d42@autistici.org> In-Reply-To: From: NightStrike Date: Sat, 24 Dec 2022 00:58:01 -0500 Message-ID: Subject: Re: Adding a new thread model to GCC To: Jonathan Yong <10walls@gmail.com>, "fortran@gcc.gnu.org" Cc: i.nixman@autistici.org, libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Dec 23, 2022 at 7:00 PM Jonathan Yong via Gcc-patches wrote: > > On 12/22/22 12:28, i.nixman@autistici.org wrote: > > On 2022-12-22 12:21, Jonathan Yong wrote: > > > > hello, > > > >> On 12/16/22 19:20, Eric Botcazou wrote: > >>>> The libgcc parts look reasonable to me, but I can't approve them. > >>>> Maybe Jonathan Yong can approve those parts as mingw-w64 target > >>>> maintainer, or maybe a libgcc approver can do so. > >>> > >>> OK. > >>> > >>>> The libstdc++ parts are OK for trunk. IIUC they could go in > >>>> separately, they just wouldn't be very much use without the libgcc > >>>> changes. > >>> > >>> Sure thing. > >>> > >> > >> Ping, need help to commit it? > > > > yes, it would be great if we can merge the path into gcc-13! > > > > I've tested it on gcc-12-branch and gcc-master for i686/x86_64 windows, > > with msvcrt and ucrt runtime - works as it should! > > > > Eric ^^^ > > > > > > > > best! > > Done, pushed to master branch. Thanks Eric. I think this might have broken fortran. I'm assuming because the backtrace includes gthr.h, and I just did a git pull: In file included from /tmp/rtmingw/mingw/include/windows.h:71, from ../libgcc/gthr-default.h:606, from ../../../libgfortran/../libgcc/gthr.h:148, from ../../../libgfortran/io/io.h:33, from ../../../libgfortran/runtime/error.c:27: ../../../libgfortran/io/io.h:298:24: error: expected identifier before numeric constant 298 | { CC_LIST, CC_FORTRAN, CC_NONE, | ^~~~~~~