From: Ville Voutilainen <ville.voutilainen@gmail.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: std::variant with multiple identical types assignment fail to compile [PR91807]
Date: Wed, 1 Jul 2020 21:09:56 +0300 [thread overview]
Message-ID: <CAFk2RUazc0im61vAG+NdE2dtc=8YknURmWRtSDOa=7Pn0bFrTA@mail.gmail.com> (raw)
In-Reply-To: <CAFk2RUbYNFUtBa4e4-_FK1WNbpQpkq36mTZrMppxasL6Kn9HqA@mail.gmail.com>
On Wed, 1 Jul 2020 at 20:46, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
>
> Looks like just a small thinko. We construct a temporary and move-construct
> from it, but we should construct the temporary with the right index.
>
> OK for trunk and gcc-10 if full tests pass?
>
> 2020-07-01 Ville Voutilainen <ville.voutilainen@gmail.com>
>
> PR libstdc++/91807
> * include/std/variant
> (_Copy_assign_base::operator=(const _Copy_assign_base&):
> Do the move-construction from a temporary so that the temporary
> is constructed with an explicit index.
> * testsuite/20_util/variant/91807.cc: New.
And sure, s/move-construction/move-assignment/.
next prev parent reply other threads:[~2020-07-01 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 17:46 Ville Voutilainen
2020-07-01 18:09 ` Ville Voutilainen [this message]
2020-07-01 20:32 ` Ville Voutilainen
2020-07-01 20:53 ` Jonathan Wakely
2020-07-01 21:00 ` Ville Voutilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFk2RUazc0im61vAG+NdE2dtc=8YknURmWRtSDOa=7Pn0bFrTA@mail.gmail.com' \
--to=ville.voutilainen@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).