From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 608313858D35; Tue, 7 May 2024 13:51:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 608313858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 608313858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715089886; cv=none; b=gkn0yKMkf5etRP9RZObKMDJfNoAKfXcHhajIUjsttvhoDeMq1dlMECko2Sv4T+lnrTRm9l0xOrx63tYXOUBecMDdW+oMc8r1UseKebwzzQVH2UaacEnlPZ+NqDD08N3KL1OYQFCjQlqtSSPpMD5iDJv6zIlXFwk7ynE5q764SgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715089886; c=relaxed/simple; bh=gmstXhtzNMuo+N+d5PfcVWDHoy+i8eUs7eFcurCRmAI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=uBYolcHStD3wOhBf8yh1BJel/XlQJz4HewykXmvXiYTEYmDjsrEaV4so9RJy0KojCwh6MlAf1UIzjVtVVcKDTsoGyqtMjiSZruUW49qRIudjor9HZ07ViPGcwyaIDoPfBq/Zc14LrrKx6yTFxxwbhZyqKk0ejJhGg1jz34VJwdU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2e3e1ad0b19so12982391fa.0; Tue, 07 May 2024 06:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715089883; x=1715694683; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gmstXhtzNMuo+N+d5PfcVWDHoy+i8eUs7eFcurCRmAI=; b=hrph5Sp/I2IbORbN4sRBWTsmZ/5Xzsewgk47KoPKdKiRlcSXoGGPeTVnB/sfs1eIet COlXovuWs8/FIqkNQJ8gmdkjstvQ+TWnkGpuuSsNnCeTVYcTIYgrlZG1Odf9Wgc4BZ+/ c4mw5Uv28/Ye1U7wUrbkXP7hHz4jy+yL6RxJ7zsx6SpNStrVqknAvrvZjZjcR+uxwVZA 684bhygaSLN8ZtGagWNHTZNPVNiZelIByduiTJN3YWegT2u6GHPwcTfE3FZESLa8Xj+t itpUeEX1uVzBO0NYcZ2vKGa5/By45vIex+loXX/lnuqPVYNu9YOUf+2pHqTEki39ee5b znKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715089883; x=1715694683; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gmstXhtzNMuo+N+d5PfcVWDHoy+i8eUs7eFcurCRmAI=; b=WIIgoo6j0vWsEm+D71tPUl4pPyxi5+y2ks2FiwWtYCHYCfIvQ9r9D2lXv0CwSQeumI v444NaQqXXpU6dODnTBbdIMJF9Y1zv+GQ1I5imgrApEIV0P//HLcwVssatvFx9Evk/vq l4/X/4ckzDvi9DzWx+tXKDjJr4xqHTmnZHav6MYFPmg3v2F0fcmTY9sBPAyHZlQE1c7t 6/E6M3W60+6M0P+YilNhWIscLSnKJSvD3ZfQoDyRmbxbtkSvI8MCVOy8Wvb5TkNkd21W HLbDuSWiwHNt03DrzeSCJxFmI3fqdmf9PCyJz+zKcy6H4L/9YMIYXH9eaSkGSdrAbolA P2vA== X-Forwarded-Encrypted: i=1; AJvYcCWZBkdyGAI1qdiNkpda1zISOKVEW0hbXGzNm8z/dD3mcZqMHrLIM6P8Iir/pJG9uC7bONcspY0enG3vhIMF1OeRKT/4TzykvA== X-Gm-Message-State: AOJu0Yxp9RffJPgWqXF9XsIVx1rZEJJjrb28/8e9l4BvGOMvzbLhlJ8z 6NOiLSY7zqls7VXZAp6iQyxcO1xUIqqdJkrSrxfBqpcXw0J77QpjeJ+0xkn3GKI62/XhuuwNuQP cJORktl3MPUtLL3LGdYahCu1Wz7zZag== X-Google-Smtp-Source: AGHT+IEpxUWTaA9crFiE/yr9Wl0S4NZpcMH6VvGcQut/PViQ8+XZRoPoWvjdV5CSly70p//eOyXEZ2IYykFO9mrjdCc= X-Received: by 2002:a19:431e:0:b0:51b:d636:a75b with SMTP id q30-20020a19431e000000b0051bd636a75bmr8308612lfa.68.1715089882752; Tue, 07 May 2024 06:51:22 -0700 (PDT) MIME-Version: 1.0 References: <20240507134705.3819956-1-jwakely@redhat.com> In-Reply-To: <20240507134705.3819956-1-jwakely@redhat.com> From: Ville Voutilainen Date: Tue, 7 May 2024 16:51:11 +0300 Message-ID: Subject: Re: [PATCH] libstdc++: Rewrite std::variant comparisons without macros To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 7 May 2024 at 16:47, Jonathan Wakely wrote: > > I don't think using a macro for these really saves us much, we can do > this to avoid duplication instead. And now it's not a big, multi-line > macro that's a pain to edit. > > Any objections? No, that's beautiful, ship it.