From: "Daniel Krügler" <daniel.kruegler@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "François Dumont" <frs.dumont@gmail.com>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] 2/2 Remove debug/array
Date: Thu, 3 Dec 2020 18:14:26 +0100 [thread overview]
Message-ID: <CAGNvRgAjij7WRvLn+tHjdRrGgKga7Gy6dp2wGBFgEd6YjwWC-Q@mail.gmail.com> (raw)
In-Reply-To: <20201203170924.GV2309743@redhat.com>
Am Do., 3. Dez. 2020 um 18:10 Uhr schrieb Jonathan Wakely via
Libstdc++ <libstdc++@gcc.gnu.org>:
>
[..]
> >>Ok to commit ?
> >
> >Yes, this is a nice simplification, thanks.
>
> This broke the C++11 constexpr support in std::array. Fixed with this
> patch. Tested x86_64-linux, committed to trunk.
Wouldn't a transformation into a comma expression, such as
return __glibcxx_requires_subscript(__n), _AT_Type::_S_ref(_M_elems, __n);
realize the same thing but would still keep the assertion-like thing?
(Untested, just out of my head)
- Daniel
next prev parent reply other threads:[~2020-12-03 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 14:27 François Dumont
2020-11-09 13:07 ` Jonathan Wakely
2020-12-03 17:09 ` Jonathan Wakely
2020-12-03 17:14 ` Daniel Krügler [this message]
2020-12-03 17:21 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGNvRgAjij7WRvLn+tHjdRrGgKga7Gy6dp2wGBFgEd6YjwWC-Q@mail.gmail.com \
--to=daniel.kruegler@gmail.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).