From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 30CB3389367A; Tue, 12 Jan 2021 17:44:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 30CB3389367A Received: by mail-wm1-x32c.google.com with SMTP id i63so2657064wma.4; Tue, 12 Jan 2021 09:44:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Gz1Ly6vDSC16wV27qtOhIMSGL8XvVaaAmY+g62yMfyo=; b=lV7S5FMxSMWoI/9s8HaHgDnOuPrMr/JaCWr400sfMUqOwvyyO7tjTtzs3NseFoB/Jb xESHJvHs7gXVHhRxUgTeqIMetdbblk6yqU3nPqcr7pnC+tb5u2qPj1HkXmx2PWUCqQCy OwPQUPDJXxnEUMGPgUGIwGXCIt9Q+mCRKOzqZwlX1OmU0hTkp4wsFBUegPwvZEaAjkcW O/q6nSdLqnHVd5S6hQNV5Bgr01XX5mOnIeQpK10Plj4cRki7bLxGUsXmqQ9bdR14/Vxh xG6bCh+Cw3aIMkpQUAQH6KigJxVkTiHZ0a1flw1oy+XOJ8XmCPuGJihkCEdlsBq4jg+B zrVg== X-Gm-Message-State: AOAM531RlKO2iU3WuTwFJTr4uKl3Ps8MCq1WL6VXThK1ot5D854UWs2G 2gOVWZuoxb7Mey/jceSHL7zXoioPHKofRD7NpQw= X-Google-Smtp-Source: ABdhPJz4KyhmaCsrnhx8+5roZd+np1qfiIZl6H52Fn/X48oE+U2yXP/Ea404mGrmofuz5IwFoW4atex2YpQJ+jTiMOg= X-Received: by 2002:a1c:bc57:: with SMTP id m84mr335113wmf.163.1610473490290; Tue, 12 Jan 2021 09:44:50 -0800 (PST) MIME-Version: 1.0 References: <20210111154058.GB21410@redhat.com> <20210112152505.GE21410@redhat.com> In-Reply-To: From: David Edelsohn Date: Tue, 12 Jan 2021 12:44:38 -0500 Message-ID: Subject: Re: [PATCH] libstdc++: implement locale support for AIX To: Rainer Orth Cc: Jonathan Wakely , "libstdc++@gcc.gnu.org" , David Edelsohn via Gcc-patches , "CHIGOT, CLEMENT" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 17:44:52 -0000 On Tue, Jan 12, 2021 at 12:41 PM Rainer Orth wrote: > > Hi Jonathan, > > >> On 12/01/21 15:14 +0000, CHIGOT, CLEMENT wrote: > >>>Hi everyone,=C3=82 > >>> > >>>I've reworked the patch to merged dragonfly and AIX > >>>models into the new one named "ieee_1003.1-2008".=C3=82 > >>>It seems okay on the AIX part but if someone can test > >>>on Dragonfly and Freebsd I would be glad.=C3=82 Configure > >>>needs to be regenerated, first. > >> > >> Presumably it could also be tested on GNU/Linux and Solaris, since > >> they implement the POSIX 2008 APIs needed. > > > > I'll give the patch a whirl on Solaris. However, we will need to > > distinguish between 11.3 (which is XPG6 only) and 11.4 (which support > > XPG7). > > as almost expected, a build on Solaris 11.4 failed miserably due to the > use of the various BSD extensions (localeconv_l, mbstowcs_l, strtod_l, > strtof_l, strtold_l, wcsftime_l), whose use or fallback implementations > are currently guarded by _AIX. Should those be used in a directory > supposed to conform to POSIX.1-2008 at all? OTOH, almost duplicating > the code into a separate bsd (or whatever, it's certainly not only > DragonflyBSD) directory for this sole reason would be a shame. Hi, Rainer Thanks for testing. I agree that #ifdef's are not the correct approach, but, if you enable the fallbacks for Solaris, does everything then work? Are those fallbacks portable and we solely need a better mechanism to enable them on platforms that require them? Thanks, David