From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34048 invoked by alias); 5 Dec 2017 18:36:10 -0000 Mailing-List: contact libstdc++-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libstdc++-owner@gcc.gnu.org Received: (qmail 34004 invoked by uid 89); 5 Dec 2017 18:36:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HCc:D*verizon.net, airy_ai, UD:check_nan.cc, check_nan.cc X-Spam-User: qpsmtpd, 3 recipients X-HELO: mail-qt0-f195.google.com Received: from mail-qt0-f195.google.com (HELO mail-qt0-f195.google.com) (209.85.216.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Dec 2017 18:36:06 +0000 Received: by mail-qt0-f195.google.com with SMTP id w10so3051450qtb.10; Tue, 05 Dec 2017 10:36:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vAC2WlxNcA2H3UmVf2JD3yuHoxNzHRf+TuWOVVB03Tw=; b=SthrL27POAUS+CuIOJZLkb858a7nM4VJSLQRHJv+oYEAqDZUG8d07aNosYjjuV9VUV fO+yEEEFTetoYTXZc/GsmFrUatMCgBzdeSxKQ2FxPgF3kvIkwwv4exNdkoBmAHKXk3oI D9xQaxeaMYLC39sFXuxuyrTB0vIumZE+9ZddcRPuzsriGVtngdwyoazTTGXniMCTm1f1 7k0kA8NC+D/HEl8XSLiwoajOSsPldEMYig6zuYcQeVQOl/7aTlmc0TG+nftsnaDW679r +RNA9MODI5Qr2GLI9Olc/uMbsKklXn7X/lsx+ws738IcXl3UlwzZEQC0385VqvaZ04HA cyhg== X-Gm-Message-State: AKGB3mJfE0Bj3YarUQLZy8MWlxVw5fdFzHIS1kGTe3fnSkg77ivm4Phe ww27s09eJmlhzm/HQ9XEtlKWRKENHXEUZ/TCayo= X-Google-Smtp-Source: AGs4zMaxb6nR/R37wTAsn90Da5w57o0EQbBTvmOVhektsXt7UDR2mVEnpur9upufEzlrdSSsc77jn8Ypg4UvGcWwE+o= X-Received: by 10.200.49.29 with SMTP id g29mr2830348qtb.215.1512498965122; Tue, 05 Dec 2017 10:36:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.196.134 with HTTP; Tue, 5 Dec 2017 10:36:04 -0800 (PST) In-Reply-To: <20171120215136.GJ31922@redhat.com> References: <20171120210154.GH31922@redhat.com> <20171120210747.GI31922@redhat.com> <20171120215136.GJ31922@redhat.com> From: David Edelsohn Date: Tue, 05 Dec 2017 18:36:00 -0000 Message-ID: Subject: Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values To: Jonathan Wakely Cc: Christophe Lyon , Ed Smith-Rowland <3dw4rd@verizon.net>, "libstdc++@gcc.gnu.org" , gcc-patches , Jonathan Wakely , redi@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-12/txt/msg00021.txt.bz2 On Mon, Nov 20, 2017 at 4:51 PM, Jonathan Wakely wrote: > On 20/11/17 21:07 +0000, Jonathan Wakely wrote: >> >> On 20/11/17 21:01 +0000, Jonathan Wakely wrote: >>> >>> On 20/11/17 21:43 +0100, Christophe Lyon wrote: >>>> >>>> On 20 November 2017 at 17:02, David Edelsohn wrote: >>>>> >>>>> This patch has introduced new regressions on at least PowerPC and >>>>> AArch64. >>>>> >>>>> FAIL: ext/special_functions/hyperg/check_value.cc execution test >>>>> FAIL: >>>>> tr1/5_numerical_facilities/special_functions/17_hyperg/check_value.cc >>>>> execution test >>>>> >>>>> Thanks, David >>>> >>>> >>>> On AArch64 and ARM, I have also noticed >>>> FAIL: special_functions/18_riemann_zeta/check_value.cc (test for excess >>>> errors) >>>> UNRESOLVED: special_functions/18_riemann_zeta/check_value.cc >>>> compilation failed to produce executable >>>> because: >>>> >>>> /libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc: >>>> In function 'void test(const testcase_riemann_zeta (&)[Num], >>>> Ret)': >>>> >>>> /libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:292: >>>> error: 'riemann_zeta' is not a member of 'std' >>>> >>>> /libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:292: >>>> note: suggested alternative: 'remainder' >>>> compiler exited with status 1 >>> >>> >>> The problem is that { dg-addition-options } was changed to dg-options, >>> and so the first dg-options that enables the special functions is not >>> used: >>> >>> --- >>> a/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc >>> +++ >>> b/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc >>> @@ -21,7 +21,7 @@ >>> // riemann_zeta >>> >>> // This can take long on simulators, timing out the test. >>> -// { dg-additional-options "-DMAX_ITERATIONS=5" { target simulator } } >>> +// { dg-options "-DMAX_ITERATIONS=5" { target simulator } } >>> >> >> >> I have a script to check dejagnu directives, and it says: >> >> >> testsuite/tr1/5_numerical_facilities/special_functions/20_riemann_zeta/check_value_neg.cc >> has multiple dg-options directives >> testsuite/ext/special_functions/airy_ai/check_nan.cc has dg-options after >> dg-add-options >> testsuite/ext/special_functions/hyperg/check_nan.cc has dg-options after >> dg-add-options >> testsuite/ext/special_functions/conf_hyperg/check_nan.cc has dg-options >> after dg-add-options >> testsuite/ext/special_functions/airy_bi/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/02_assoc_legendre/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/14_expint/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/12_ellint_2/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/09_cyl_bessel_k/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/21_sph_neumann/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/15_hermite/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/19_sph_bessel/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/05_comp_ellint_2/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/11_ellint_1/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/17_legendre/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/10_cyl_neumann/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/06_comp_ellint_3/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/06_comp_ellint_3/pr66689.cc has dg-options >> after dg-add-options >> testsuite/special_functions/01_assoc_laguerre/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/16_laguerre/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/13_ellint_3/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/13_ellint_3/pr66689.cc has dg-options after >> dg-add-options >> testsuite/special_functions/07_cyl_bessel_i/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/18_riemann_zeta/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/18_riemann_zeta/check_value.cc has multiple >> dg-options directives >> testsuite/special_functions/08_cyl_bessel_j/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/04_comp_ellint_1/check_nan.cc has dg-options >> after dg-add-options >> testsuite/special_functions/03_beta/check_nan.cc has dg-options after >> dg-add-options >> testsuite/special_functions/20_sph_legendre/check_nan.cc has dg-options >> after dg-add-options >> >> For now I'll just fix the multiple dg-options one causing the FAILs. > > > > I've committed this patch, which should help for Christophe's cases. > It won't help the AIX execution FAILs. Ed, What is the progress with fixing the new execution fail regressinos that were introduced with the patch? Thanks, David