From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 5779F384640F; Mon, 11 Jan 2021 22:20:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5779F384640F Received: by mail-wm1-x334.google.com with SMTP id c124so193181wma.5; Mon, 11 Jan 2021 14:20:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qRWmTbbjDRNfIHunuKqRHhW2UXdxXNSB2PCvNWqq7O8=; b=uj3j2V2bzahGxG/zx96Jzze2yK9ASB/aRrjXU/ckVglurdlPQmSkKBrbEAT8GKvIMp 8OruC4Mrep4oQcteTUWo9RxzFhYJu23P4jXjm+ECCUo+Ulx+dodmQ2GEPZkR+FU/K47E 64asLi+dO0Yae3ZUbmVmXmw5Y0sP3ZiJFBZjiD6KNplJUjT0rl5T1Sb4Ka/eG2LyxZls kdySY/Smwnd6XZWIMKjdAa7jBiVLxSvwehTXUDIwDhT3SYZqQ1dixLqFLWFIxbBZDwsA AgREdthwZt4lrCalxVGMq1YakxjcYGgrp0igi1vpVBIwiJMYi8Rg2a+KF8CnlbgJkWn2 UqeA== X-Gm-Message-State: AOAM530ikM2w2qBYwShuy6g6yD0wqjeUF6jUTRX+iepTEOLXWRf8lXoC K7W18wzZeoe8udZlc/9L9iUJHhkqtY9Eiwei6es= X-Google-Smtp-Source: ABdhPJzVlA7fCKLXX0MsfeI7OoUdcALQgSP8fpO0F2LcZWJFA6jnBIvkj5QXUTGMEga9bgOAIURe07bCn/4pgHFkmHg= X-Received: by 2002:a7b:cc94:: with SMTP id p20mr763642wma.22.1610403618503; Mon, 11 Jan 2021 14:20:18 -0800 (PST) MIME-Version: 1.0 References: <20210111154058.GB21410@redhat.com> In-Reply-To: From: David Edelsohn Date: Mon, 11 Jan 2021 17:20:07 -0500 Message-ID: Subject: Re: [PATCH] libstdc++: implement locale support for AIX To: "CHIGOT, CLEMENT" Cc: Jonathan Wakely , Rainer Orth , David Edelsohn via Gcc-patches , "libstdc++@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 22:20:21 -0000 On Mon, Jan 11, 2021 at 10:56 AM CHIGOT, CLEMENT wrote: > > >> Hi David, Clement, > >> > >>> The patch is local to libstdc++ AIX support, so I believe that I can = approve it. > >> > >>have you considered merging the dragonfly and aix trees? I'm asking > >>because it seems prudent to try and avoid creating more and more > >>almost-but-not-quite-similar configurations (Solaris might be able to > >>use the same code, at least in 11.4 which has XPG7 support). > > > >Agreed. > > > >See also https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%= 2F%2Fgcc.gnu.org%2Fbugzilla%2Fshow_bug.cgi%3Fid%3D57585&data=3D04%7C01%= 7Cclement.chigot%40atos.net%7Cb9820136976149e643b408d8b64756c2%7C33440fc6b7= c7412cbb730e70b0198d5a%7C0%7C0%7C637459764803442555%7CUnknown%7CTWFpbGZsb3d= 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&= amp;sdata=3DqinNdbwsbyUdvijD76PanMf0Y1iSfn1FhRAt2T2dl%2B0%3D&reserved= =3D0 > > I haven't thought about that. It should be possible. > The main problem with AIX are the few missing locale functions > (strtof_l, localeconv_l, etc). I've defined some in c_locale.h, some > are simply wrapped by uselocale in the code itself. > The question is if we merged dragonfly, aix and allow others OS > to use this new locale support, what should go in c_locale.h ? > Do we want it to define all missing functions or do we rather > have some #ifdef wrapping "uselocale" when a *_l function > is missing ? > Both ways, I'm fearing there will be a lot of #ifdef. The OS-specific definitions could be placed in config/os/XXX/os_defines.h. And the DragonFly locale files could include to obtain the definitions. I'm not certain where to place the uselocale changes. Either #ifdefs or move part of the files to config/os/XXX/... Thanks, David