From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dje.gcc@gmail.com>
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [IPv6:2a00:1450:4864:20::134])
 by sourceware.org (Postfix) with ESMTPS id 1970C3838030;
 Wed, 21 Apr 2021 14:23:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1970C3838030
Received: by mail-lf1-x134.google.com with SMTP id j18so67168042lfg.5;
 Wed, 21 Apr 2021 07:23:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=S0ywumwzfXYcIGCJP8z1rqDEdDflC182kn5DKUUDVEg=;
 b=nyAs3l3B+9o6s22rY1O478z/SNsSODlIsQ7qAXZT9d/qTdirTIpIGvwr3/Ep6DXRAh
 qkV0qibYXwiI6oxvhUpTspFyuz0FoDpM97W4pYHG+0o+Z2g0fY8nYS4OcXumjENAd0l6
 pPGZ2gBdRe3PteKLIXi42AjVudLg4SxHxoTSE3tJjASTjE+wSyEzoVAL0Mqy0uUzorr3
 es5Jyi/vSLS5VgIjEvdthfKpyCbvToUCod/ZVxXz/awHuXqffM+xdJSO8wyGHl2MXXI6
 j647xyQiN24FOKACfWCWye0F7WxeZBuXsL6geE54cThKgFJ6qqrl9gNjlSXsnHkfW1Up
 ViMw==
X-Gm-Message-State: AOAM533QEXYPCMU3OP/x/KRPNeRyY5HwznhAM2OfwehngIi5RaQDWezn
 B+t+oL/ufgI9JCkzvvL/qTY6yv6n3/bMGiCe7Ow=
X-Google-Smtp-Source: ABdhPJwMuThb4RlxVd3G7UfIJUlyfNiudoeXyBRbmQzXjtTn/ENhGJE+UPgx5wFSmeeOEJ9JQJCoiUDEh+fQQ8CdYP8=
X-Received: by 2002:a05:6512:308a:: with SMTP id
 z10mr19663152lfd.15.1619014994670; 
 Wed, 21 Apr 2021 07:23:14 -0700 (PDT)
MIME-Version: 1.0
References: <20210420152439.GR1179226@tucnak>
 <CAGWvnykjEBYoK=poyfSWy84Eix__GJ-NJ50QSc99ji-UM8n+Wg@mail.gmail.com>
 <6ac731c557415b46b04613d9b908df2f@appliantology.com>
 <CAGWvnymcuXzvrBEm6rrTvXzRyoCYgx0vUm2nUBMWA29aQZc4uQ@mail.gmail.com>
 <a69622f7cc24e6e311d5099b9899e798@appliantology.com>
 <CAGWvnykWuuxtDKen5AXfX5k__UsChmvJAhp5-vC6O5LFnhqjBQ@mail.gmail.com>
 <CAGWvnykNJ0VqcMcFfBrQUTTFOk_J2PVj2Ci5jNZu55sbnc7Y9w@mail.gmail.com>
 <45de03629a536c0000c9b47bb79d6601@appliantology.com>
 <20210421113804.GU3008@redhat.com>
 <20210421121218.GV3008@redhat.com>
In-Reply-To: <20210421121218.GV3008@redhat.com>
From: David Edelsohn <dje.gcc@gmail.com>
Date: Wed, 21 Apr 2021 10:23:03 -0400
Message-ID: <CAGWvnyn2oC2x=5Ex9MbHjX9WfeHcZjrWNhy1Q0a6=qAZaNaj4Q@mail.gmail.com>
Subject: Re: GCC 11.1 Release Candidate available from gcc.gnu.org
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Thomas Rodgers <rodgert@appliantology.com>,
 Jakub Jelinek <jakub@redhat.com>, 
 GCC Patches <gcc-patches@gcc.gnu.org>, "libstdc++" <libstdc++@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2021 14:23:22 -0000

Hi, Jonathan

Thanks for the further investigation.  I definitely encountered the
missing _M_try_acquire in __platform_semaphore.

Thanks, David

On Wed, Apr 21, 2021 at 8:12 AM Jonathan Wakely <jwakely@redhat.com> wrote:
>
> On 21/04/21 12:38 +0100, Jonathan Wakely wrote:
> >On 20/04/21 22:12 -0700, Thomas Rodgers wrote:
> >>@@ -86,6 +88,24 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> >>      }
> >>    }
> >>
> >>+    _GLIBCXX_ALWAYS_INLINE bool
> >>+    _M_try_acquire() noexcept
> >>+    {
> >>+      for (;;)
> >>+     {
> >>+       auto __err = sem_trywait(&_M_semaphore);
> >>+       if (__err && (errno == EINTR))
> >>+         continue;
> >>+       else if (__err && (errno == EAGAIN))
> >>+         return false;
> >>+       else if (__err)
> >>+         std::terminate();
> >>+       else
> >>+         break;
> >>+     }
> >>+      return true;
> >>+    }
> >>+
> >>    _GLIBCXX_ALWAYS_INLINE void
> >>    _M_release(std::ptrdiff_t __update) noexcept
> >>    {
> >
> >Please just commit this part to trunk and gcc-11, not the macro
> >renaming (as that's been fixed by Jakub already).
>
> I think on trunk I'd prefer to do the attached. WDYT?
>
>