From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id B672F3858D1E; Sat, 18 Nov 2023 08:43:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B672F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B672F3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700297006; cv=none; b=vBOCUD3xdDjHanKs+hrox+9OK0B0ikPBlUWfnjizyw+QIgIpxzVj8E1iLvHf2fZWVmph6BInc+W3xzFXpCO+m7SbdPWbW4VQ/Uyl6dZRRXSIKdsDRgXQxLo0RbXpnP1xhKBrVKZuthkB+gIOd48EzmHN6cEjDM36XLJoJXSjP/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700297006; c=relaxed/simple; bh=eNL/LFGd9fTonHL3H8pOXE78w+LHZsEua6VneoRv4Ec=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=GLwAuu8PxLCZKFoV+EQIwwF95fvAHgsxxl8+TcRja/xZxAOlZBCz4SzPk3zipSHQMpRMSAWtkaMxk1almNNN8P7LF4S16xsJqRDO9ezoi74K2MG60pqT7K5kRfrUqByGEZTgSi7F4IG3yb/YTXP11fANujTqbj2NYxq8K+xCKhs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9c41e95efcbso379457766b.3; Sat, 18 Nov 2023 00:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700297003; x=1700901803; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Dxq8x9Fy8ZaMf1Jj5fmXpDIZHltcgE0CcWXAMJBQ59U=; b=c68o/prngj4eZzIM5oGVBrK9PtpJNWOOhiSGhTu9IesIQ0hH4wtDtec3WtayFHuU7b gChpub+ABLH0MMVcDSvB0zh6TU57BQ+m8zudHlavIJIcvBZr1H3XOvFGoR1SGNNHwUsI 97C3VZrbpvh+wVsFV/e3YLUhzmmdy3aTBP0/W9ZijFoSt45Bf+z+uqhbisvKTVpzNW/y s2gmGWsxZnzjcut4nd8QNt14wKfwOWtx3p4Y47JLZddgLyMdigIF09vNV0Q1UMg8xKAx 4ZaYBy+vaLzLwqFtiBqmbDtoVVwaeO3pzczlwxi9TKVuDLKhmvl0Gtx5gtMRQSezGWeE 8Beg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700297003; x=1700901803; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dxq8x9Fy8ZaMf1Jj5fmXpDIZHltcgE0CcWXAMJBQ59U=; b=dcD/4s8gALcuOWM92NrqqB+ME3pQAjjei+R7u3oyLbyDMsSi+Yp4zXWGgFZ8tXoQdo jGs0SfjIDTBsghDdqsHe0FG3CaX4tTd1kVYA4A5SIPLSl3Ptvzbsw9qzq5i15XzuZlEN QZCaRjoalz88pgRR//cibShha7MrE4Klisk6BydbvdptVvF42fAWCZrbXEEdcT+0Vl44 c3OLhR6TgXT85HYx1+JGtUxw1QLyr5rWlsOH8XWQqSgCW8PMfLQO9CuC0LGhEPsVxMi0 JH1R9Cpr9o4gbIWIojpbftB3C7Y6XevKEWyJhKcmXtSMnvatRv+DqNkK9uZF6L1Uuj1o VTGg== X-Gm-Message-State: AOJu0YwGOuB49BpfqM8kyHUHyCoBsvep8N+GY8iJ1F6Gc5N3N52sO5S8 EnQnPISqE16uxZPfB8N4MVayAmmy4PdopYM01Y3nkeNA X-Google-Smtp-Source: AGHT+IFfG5WHQVD9lG9miqU5Rn+MGaSyAaPELEFwsJdfJO/v5FL8WVMoiYBxsQSGqzbSO7gVh5ssnCfjExX+Y7kpYy4= X-Received: by 2002:a17:906:d6:b0:9e7:3af8:1fcb with SMTP id 22-20020a17090600d600b009e73af81fcbmr1174832eji.58.1700297002579; Sat, 18 Nov 2023 00:43:22 -0800 (PST) MIME-Version: 1.0 References: <20231108102507.674091-1-fanpeng@loongson.cn> In-Reply-To: <20231108102507.674091-1-fanpeng@loongson.cn> From: Jonathan Wakely Date: Sat, 18 Nov 2023 08:43:10 +0000 Message-ID: Subject: Re: [PATCH] LoongArch: Add libstdc++ check-abi support. To: Peng Fan Cc: libstdc++@gcc.gnu.org, gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Libstdc++ patches need to be CC'd to the gcc-patches list as well. On Wed, 8 Nov 2023 at 10:26, Peng Fan wrote: > > libstdc++-v3: > > * configure.host: Add abi_baseline_pair for LoongArch. > * config/abi/post/riscv64-linux-gnu: New directory. > * config/abi/post/riscv64-linux-gnu/baseline_symbols.txt: New file. Looks like the wrong filename here. > > Signed-off-by: Peng Fan > --- > libstdc++-v3/ChangeLog | 6 + > .../baseline_symbols.txt | 12023 ++++++++++++++++ > libstdc++-v3/configure.host | 7 +- > 3 files changed, 12035 insertions(+), 1 deletion(-) > create mode 100644 libstdc++-v3/config/abi/post/loongarch64-linux-gnu/ba= seline_symbols.txt > > diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog > index 9b9a48c833a..3158519031d 100644 > --- a/libstdc++-v3/ChangeLog > +++ b/libstdc++-v3/ChangeLog Please don't include the ChangeLog in the patch. ChangeLog files are auto-generated by a script every night, so you should not edit the file, and yo should not submit changes to it. > @@ -1,3 +1,9 @@ > +2023-11-08 Peng Fan > + > + * configure.host: Add abi_baseline_pair for LoongArch. > + * config/abi/post/loongarch64-linux-gnu: New directory. > + * config/abi/post/loongarch64-linux-gnu/baseline_symbols.txt: New fi= le. > + > 2023-11-07 Fran=C3=A7ois Dumont > > * include/bits/hashtable_policy.h > +TLS:8:_ZSt11__once_call > +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11 > +TLS:8:_ZSt15__once_callable > +TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11 Does this target support TLS unconditionally? These TLS symbols are not included in the baseline symbols for x86_64-pc-linux-gnu, for example. Are you sure the ABI is final and ready to not change again?