From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 6D5EE3857341; Fri, 9 Sep 2022 18:27:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D5EE3857341 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62e.google.com with SMTP id r17so5913711ejy.9; Fri, 09 Sep 2022 11:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=y4m0+at1g5tcWAcJ04L7RLETAJGNo7Fa7IK6UtItU9U=; b=pN+vAI4kI6iY8/8C+R+6e69F8CqcatUrct8v8/W6hAwjnTBnGsm617kqvw8/ZWhWRs UHyM/LxwytU1IBJVYVCS81Z80l6YnUPv5P4b1by8Yenc3mDxHJjtw5Ktg2FQif06gEfK 8HU2k+PWvClvlffcM0CwrNixrfiEBN6Oyp2xgF5sFfnl3uHLYVmj86dVs/xJx81hOFi3 H0enA4BHBf9iNFXl/bFRyml3VI6viNWj73hzVE3SCd+BcO8c17d1tYLddGeEw1ortOfq W1QAkygMSSBIKxUdSZD1orJVFsvu6uahSBwnpWF7aWuF9qvYHbhsibRXsCH4jENVY9ew SiVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=y4m0+at1g5tcWAcJ04L7RLETAJGNo7Fa7IK6UtItU9U=; b=IfxCOE2gtPtRfrHWUqz+9k1oWcpJCIwxLKAkeVlQhzf99ZgmdEMhMfokP19vJc0v01 Eol/J/HraKzkceqgREh0zIernVLbeFWZu3bCirn0bACwKbdz0/g7Gz7FltSNG89o3Hpn dGBcVm0habCs/T0EgUzQpNHxGHjLRraC758lSap/hojPQ+oCW1Bk++TpfzLb10aod4E6 je9Lzpgfmtw7ibjhCKD/bs94WbYwreH/qg0m88LrWdxNzA22DGk0tLOJE69AvlzgdKk/ X8AmB8ELDArC1Gw/Gh1HNirHUhK9zR8vX93QlH8X0dMBkqoOSD1W5Wn1GuG52Sq7DVJa 7NGg== X-Gm-Message-State: ACgBeo16zA3lMld1k2FgX6GEHvHtD0vE65+/Sw1Hbkeviro3d4P2FWI3 gUxir8phWMMDXXgSwo+Ej20a1Li0Z34NQ9+tTkg= X-Google-Smtp-Source: AA6agR4e45g+Adsh6iklaO+MgxcNB+nfX+E8YJJikqssVbQbib+Slms1YB65tcdBfOlL71YT73eBH/CiYug6Wwr5iYw= X-Received: by 2002:a17:906:fd8a:b0:75d:c79a:47c8 with SMTP id xa10-20020a170906fd8a00b0075dc79a47c8mr10365281ejb.389.1662748028250; Fri, 09 Sep 2022 11:27:08 -0700 (PDT) MIME-Version: 1.0 References: <20220909172446.1546805-1-ppalka@redhat.com> <20220909172446.1546805-2-ppalka@redhat.com> In-Reply-To: <20220909172446.1546805-2-ppalka@redhat.com> From: Jonathan Wakely Date: Fri, 9 Sep 2022 19:26:56 +0100 Message-ID: Subject: Re: [PATCH 2/3] libstdc++: Fix typo in adjacent_view::_Iterator [PR106798] To: Patrick Palka Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000932df705e842b17f" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000932df705e842b17f Content-Type: text/plain; charset="UTF-8" On Fri, 9 Sep 2022, 18:25 Patrick Palka via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > PR libstdc++/106798 > > libstdc++-v3/ChangeLog: > > * include/std/ranges (adjacent_view::_Iterator::_Iterator): Fix > typo. > * testsuite/std/ranges/adaptors/adjacent/1.cc (test04): New test. > OK, thanks. --- > libstdc++-v3/include/std/ranges | 2 +- > .../testsuite/std/ranges/adaptors/adjacent/1.cc | 12 ++++++++++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/libstdc++-v3/include/std/ranges > b/libstdc++-v3/include/std/ranges > index 2b8fec3c386..37ad80ad3de 100644 > --- a/libstdc++-v3/include/std/ranges > +++ b/libstdc++-v3/include/std/ranges > @@ -5239,7 +5239,7 @@ namespace views::__adaptor > requires _Const && convertible_to, > iterator_t<_Base>> > { > for (size_t __j = 0; __j < _Nm; ++__j) > - _M_current[__j] = std::move(__i[__j]); > + _M_current[__j] = std::move(__i._M_current[__j]); > } > > constexpr auto > diff --git a/libstdc++-v3/testsuite/std/ranges/adaptors/adjacent/1.cc > b/libstdc++-v3/testsuite/std/ranges/adaptors/adjacent/1.cc > index 9829f79364f..443c1fbf450 100644 > --- a/libstdc++-v3/testsuite/std/ranges/adaptors/adjacent/1.cc > +++ b/libstdc++-v3/testsuite/std/ranges/adaptors/adjacent/1.cc > @@ -101,10 +101,22 @@ test03() > return true; > } > > +constexpr bool > +test04() > +{ > + // PR libstdc++/106798 > + auto r = views::single(0) | views::lazy_split(0) | views::pairwise; > + decltype(ranges::cend(r)) s = r.end(); > + VERIFY( r.begin() == s ); > + > + return true; > +} > + > int > main() > { > static_assert(test01()); > static_assert(test02()); > static_assert(test03()); > + static_assert(test04()); > } > -- > 2.37.3.518.g79f2338b37 > > --000000000000932df705e842b17f--