From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id A6AE33858D32; Tue, 16 Apr 2024 06:37:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6AE33858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A6AE33858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713249460; cv=none; b=R0SP+/Kdia+J/483+I9qpXrTQnIAbX2m9YyFo80HE4/xNTrV//L4G7BpOW0+lLDJD//dI+EYsiis8vjgNBJ6iuCqR1jWPD8dE+SbvRfmZvDXuerLqcBdMrBwY6rVK0OQUFhUSd9EIpmgilx73GtEF0pR4CE/9NJ2LKcsyn0SKho= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713249460; c=relaxed/simple; bh=6lcKQ55DdHAPP7ZW7LtGG7FZNgnluwQ2Pgn57c9WdX8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=rQgJGL5F3JaFlGX8uXTQ5rUr8QWvDCpMHQ2myijoamDeOMcJw50rR4GbU5/P1GhjbMloMu/GvkfOIzIuimmYHIkMOFrjwou8MAfCvUlfXFRS134SUV+iq7coL2Gi7gYxIFGUJXOB5MYdvtAZAEFY3wMQCrucywPjDi1Y56mSWss= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-56fd7df9ea9so4635241a12.0; Mon, 15 Apr 2024 23:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713249456; x=1713854256; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VrZD0++ldgnrn5AJXcPsPebuLXQA0/9Pgq9swNCnZlQ=; b=KegtbQIJsOK2yTQ5wgyavXhZ3MmUV2MCBKxWWLPwnGYp0AlrmP9ta3nmow46+lA0+1 RptUNafJDlEy628KYqJ6ICBqbCdREmKI85NzpFKikMFVbQQvPcJmAUzWqGWqjMFZp9F3 dmB7wr3PUU+iTLHzSii3KDfK3OTQ5mIuZ9UbiHBwfmGQFmESofAl0GnSF6TDDl1u3ymb xIYSVeT5XXdqOc5UU95eC43pTkjuH5PKx1qYqjfkR9YhrxN9fuXeMQvVU6EyCGCUKdew ucrskxA0+HE/jxZAZ6DQuRAMivgtkenJ95RLMThtDcr4HAJENuTQTKSiAfDAmRnJ5ZQ1 8joA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713249456; x=1713854256; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VrZD0++ldgnrn5AJXcPsPebuLXQA0/9Pgq9swNCnZlQ=; b=h81atcz3dJ3Op4hp5QjVM1l5Sxk4ZcG7FeN//ViJga2/haWjm+Low0HlxCrgULm4wQ jB1zpUXBXp588fBbC8DUBwD0LgPlHrz7vdK64Ul588Qry0u0jkv3wb+1G9G+v03VVyRo Rz6/NeSPHVJpD46Ab1n6kN8P9N6fdG9ckUOiUWBF0q+ixsay6r0JzYmjEkkRxsdMPlMI jVMmfVzs3oIunW1rq/6gqMvMwQldO5Ju5zPHrArfvwOzmtOwzpNRuFZcSTeathg/3121 VNXvcHeZCOWun3W1WBO+S9tI2jf8TrorwjLrLR/vuvR3SbtB3qaSVLf2hKrpvC3c6FX9 CDIQ== X-Forwarded-Encrypted: i=1; AJvYcCVPGQ8251XwClXk97BSd/zMimDh5wtFISR/90KS+f+NFtSuCTaQ89Ikx2FDg+eufN5CtxyfaDPmrwHrmB+1uIDtEV3ca7I= X-Gm-Message-State: AOJu0Yxh8gazwJCuMu09olhGxgDXmSc4Z0jnt5ZvdGykvRSd9cuSzExS v7MysQ8AMSW1H9iYrSB6ScgGVOy4GWpRimPem62FOKl6J5utkkZKNKP2ya0dKVZ/XD67q1W5wep 4WgMtf3OAGGtCPH4JrzjfWBDcl+SbgQ== X-Google-Smtp-Source: AGHT+IEx5O4VOnGnklxwSmGQf+ZqTxTfaI144A+sYuO7/Rp553YLn/NeZ48M0nfByvNpAMf4EKnS5s8Obo1yGv1UFqQ= X-Received: by 2002:a17:907:2ce5:b0:a51:cbd5:1fb5 with SMTP id hz5-20020a1709072ce500b00a51cbd51fb5mr9833242ejc.36.1713249456037; Mon, 15 Apr 2024 23:37:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Tue, 16 Apr 2024 07:37:23 +0100 Message-ID: Subject: Re: [PATCH] [libstdc++] define zoneinfo_dir_override on vxworks To: Alexandre Oliva Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="0000000000003d2644061630f93b" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003d2644061630f93b Content-Type: text/plain; charset="UTF-8" On Tue, 16 Apr 2024, 04:17 Alexandre Oliva, wrote: > > VxWorks fails to load kernel-mode modules with weak undefined symbols. > In RTP mode modules, that undergo final linking, weak undefined > symbols are not a problem. > > This patch adds kernel-mode VxWorks multilibs to the set of targets > that don't support weak undefined symbols without special flags, in > which tzdb's zoneinfo_dir_override is given a weak definition. > > Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-, > aarch64-, x86- and x86_64-vxworks7r2. Ok to install? > OK, thanks. > > for libstdc++-v3/ChangeLog > > * src/c++20/tzdb.cc (__gnu_cxx::zoneinfo_dir_override): Define > on VxWorks non-RTP. > --- > libstdc++-v3/src/c++20/tzdb.cc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libstdc++-v3/src/c++20/tzdb.cc > b/libstdc++-v3/src/c++20/tzdb.cc > index 890a4c53e2d44..639d1c440ba16 100644 > --- a/libstdc++-v3/src/c++20/tzdb.cc > +++ b/libstdc++-v3/src/c++20/tzdb.cc > @@ -70,8 +70,9 @@ namespace __gnu_cxx > #else > [[gnu::weak]] const char* zoneinfo_dir_override(); > > -#if defined(__APPLE__) || defined(__hpux__) > - // Need a weak definition for Mach-O. > +#if defined(__APPLE__) || defined(__hpux__) \ > + || (defined(__VXWORKS__) && !defined(__RTP__)) > + // Need a weak definition for Mach-O et al. > [[gnu::weak]] const char* zoneinfo_dir_override() > { > #ifdef _GLIBCXX_ZONEINFO_DIR > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive > --0000000000003d2644061630f93b--