From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id B39953858C2C; Mon, 27 Sep 2021 21:06:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B39953858C2C Received: by mail-wm1-x331.google.com with SMTP id b192so1609125wmb.2; Mon, 27 Sep 2021 14:06:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=koYDBT6PRgNcKV9mif96qs4y+UNtMdGnAEADV3eKlrQ=; b=zTyny+8Z0zjZ8ehdufQLocVxBEIcZZGIt/vtpv55W1l0zbnsVGMV+4QUSgUognk4Rk nin7KT8M/fRL/+oFaJesbn8ZzdobFC21Pb7uSCxC0uTOA8jt56l1bgbpri0X3vb1C/hP 7rgOoK62UbAbywr7bX4RAn4eNPQ2JE6JJobIATsXpFQw3wPIDEbvPiTlrWwibEkT0pW8 qPxN+0Y2u+zhHtasMirl18fUA7JBdlBU76brkmt0K6ITWYuhhuoOvGk7wWRBCTb2ah7P A+4gVuI+ohiGoRuQCVVcAwgyOwYAEUdPhGr0MDHuYokInYup84o6aoZf/FdEbva2leP6 sntA== X-Gm-Message-State: AOAM532bPXl8yg7/CtZqxgkvv+Aa4TE6WgSTFbMs/uIS7DaqKtTcdBgF XghBtdJzr1xr0Lh/LkUrJGkbHeEgUDoG5d7oyP0= X-Google-Smtp-Source: ABdhPJxG9Cjitk9bRlydPsebUaSVOpkn+n+rLmIIOHTwv+IeIGFmURmv6MtZaK0sP3u4qU3ULVFHmQesLhpM03aXs30= X-Received: by 2002:a7b:cb04:: with SMTP id u4mr1160966wmj.176.1632776788818; Mon, 27 Sep 2021 14:06:28 -0700 (PDT) MIME-Version: 1.0 References: <5e13b454-0722-01ef-8e62-e88654fe9021@gmail.com> In-Reply-To: <5e13b454-0722-01ef-8e62-e88654fe9021@gmail.com> From: Jonathan Wakely Date: Mon, 27 Sep 2021 22:06:17 +0100 Message-ID: Subject: Re: Fix 48631_neg test in _GLIBCXX_VERSION_NAMESPACE mode To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 21:06:30 -0000 On Mon, 27 Sept 2021 at 21:26, Fran=C3=A7ois Dumont via Libstdc++ wrote: > > Here is a small patch to fix a test which fails in > _GLIBCXX_VERSION_NAMESPACE mode. > > IMHO it would be better to avoid putting content in > versioned namespace, no ? > > There is of course more work to do, so for now here is the simpler approa= ch. > > Ok to commit ? Leaving the pattern ending with just "struct" isn't very useful. Wouldn't it be better to do: // { dg-prune-output "no type named 'type' in" } or just: // { dg-prune-output "enable_if" } ? Either of those is OK to commit.