From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] [libstdc++] [testsuite] disable SRA for compare_exchange_padding
Date: Tue, 16 Apr 2024 07:44:37 +0100 [thread overview]
Message-ID: <CAH6eHdQD-UUgvdq1q0DJ8LwSUEuhOnEdzkbj=qXNibdKOnk+Kw@mail.gmail.com> (raw)
In-Reply-To: <orsezmc6h3.fsf@lxoliva.fsfla.org>
On Tue, 16 Apr 2024 at 04:49, Alexandre Oliva <oliva@adacore.com> wrote:
>
>
> On arm-vx7r2, the uses of as.load() as initializer get SRAed, so the
> padding bits in the tests are not what we might expect from full-word
> struct copies.
Aha, I was wondering why this was failing on ARM!
> I tried adding a function to perform bitwise copying, but even taking
> the as.load() argument by const&, we'd still construct a temporary
> with SRAed field-wise copying. Unable to find another way to ensure
> we wouldn't get a temporary, I went for disabling SRA.
>
> Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-,
> aarch64-, x86- and x86_64-vxworks7r2. Ok to install?
Yes, thanks.
>
>
> for libstdc++-v3/ChangeLog
>
> * testsuite/29_atomics/atomic/compare_exchange_padding.cc:
> Disable SRA.
> ---
> .../29_atomics/atomic/compare_exchange_padding.cc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/libstdc++-v3/testsuite/29_atomics/atomic/compare_exchange_padding.cc b/libstdc++-v3/testsuite/29_atomics/atomic/compare_exchange_padding.cc
> index 2f18d426e7f7e..a6081968ca869 100644
> --- a/libstdc++-v3/testsuite/29_atomics/atomic/compare_exchange_padding.cc
> +++ b/libstdc++-v3/testsuite/29_atomics/atomic/compare_exchange_padding.cc
> @@ -1,6 +1,7 @@
> // { dg-do run { target c++20 } }
> // { dg-require-atomic-cmpxchg-word "" }
> // { dg-add-options libatomic }
> +// { dg-additional-options "-fno-tree-sra" }
>
> #include <atomic>
> #include <cstring>
> @@ -26,10 +27,10 @@ main ()
> s.s = 42;
>
> std::atomic<S> as{ s };
> - auto ts = as.load();
> + auto ts = as.load(); // SRA might prevent copying of padding bits here.
> VERIFY( !compare_struct(s, ts) ); // padding cleared on construction
> as.exchange(s);
> - auto es = as.load();
> + auto es = as.load(); // SRA might prevent copying of padding bits here.
> VERIFY( compare_struct(ts, es) ); // padding cleared on exchange
>
> S n;
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> More tolerance and less prejudice are key for inclusion and diversity
> Excluding neuro-others for not behaving ""normal"" is *not* inclusive
prev parent reply other threads:[~2024-04-16 6:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 3:49 Alexandre Oliva
2024-04-16 6:44 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdQD-UUgvdq1q0DJ8LwSUEuhOnEdzkbj=qXNibdKOnk+Kw@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).