From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Avoid hard error in ranges::unique_copy [PR100770]
Date: Wed, 26 May 2021 18:28:16 +0100 [thread overview]
Message-ID: <CAH6eHdQDSrOoyA2cZAsDj5He0+ohw+-ocsbOmeTv+wWz0_5xpQ@mail.gmail.com> (raw)
In-Reply-To: <20210526164541.1701738-1-ppalka@redhat.com>
On Wed, 26 May 2021 at 18:00, Patrick Palka via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> When input_iterator<_Out> isn't satisfied, we need to avoid substituting
> into iter_value_t<_Out> because the latter isn't necessarily
> well-formed in that case. To that end, this patch rewrites the
> problematic condition in ranges::unique_copy into a nested requirement
> which has the correct short-circuiting behavior.
>
> Tested on x86_64-pc-linux-gnu, does this look OK?
OK, thanks.
prev parent reply other threads:[~2021-05-26 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 16:45 Patrick Palka
2021-05-26 17:27 ` Tim Song
2021-05-26 18:43 ` Patrick Palka
2021-05-26 19:07 ` Tim Song
2021-05-27 13:50 ` Patrick Palka
2021-06-03 11:54 ` Jonathan Wakely
2021-05-26 19:55 ` Jonathan Wakely
2021-05-27 0:38 ` Tim Song
2021-05-26 17:28 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH6eHdQDSrOoyA2cZAsDj5He0+ohw+-ocsbOmeTv+wWz0_5xpQ@mail.gmail.com \
--to=jwakely.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).