From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 5089B3858D20; Mon, 20 Mar 2023 09:14:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5089B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52b.google.com with SMTP id y4so43918667edo.2; Mon, 20 Mar 2023 02:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679303651; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pcIJJBiIA/RrPv9+tP6FG7Xt7FosD/V/rKXGXdAijCY=; b=e93GFEvF5iF8kMba+x4+sSRm+vSvKlGlGhywfOAXFDqzwIXcBF8yGB+KK/hm6CIeIM CmnMfRCQf3tKOQNMMj4CkvPKF4ysJ7bnvsj+Y9URHrCmXDaNK4Cc3dSbTVP1YK1lB3ik vW+uFapdhHLF5sycdbA+79JdgIu9/lboXF163BKGHXK2J24j3WBpVYj00zxDbqHhW2vd wXgbTfPWvUruEUF3wEk8JLKD/sxXFs0B/55EbUP9CP/XMRD3PG3OjCvT/dxXvsmAwhoN iOQH4N4/8Wihkl2/1kKxff+cfCTQPKcTJveZk1ZQv71809b2z8F2An3azgnIfEoiyyOc Jn0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679303651; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pcIJJBiIA/RrPv9+tP6FG7Xt7FosD/V/rKXGXdAijCY=; b=CzEoO1xQ0Mrnfe5purfSNuJdw1LTk/gND6yjq+95b1wbgjdLY2tDqkfnR9gQ+HH2Wf kRBHyJBB/CGeffki4dIWLMMqFh56e/09W+87k2beFfxKDR2ex8ujj8Ozf8KQ3KeqkQbD HSeQLgSa0dNfV8CDaDR8h+lGrA6pgoPh7xVGy4QyeiOwYuTQvmcMJbtt8FsGhOKfWP3q o3VSVJuc9/w86LB1OMBsaMkfuItltU0wWdvJDCa8Y2ypcqpiq9ZU+R1U+M/jIuhlsSJt OnBG1eSpiQ09kQ03SDAiCUSSWb6pWZyoN+uQu27n//W2wp+ni5KbtMkd8PfMxZlbZAir gWJA== X-Gm-Message-State: AO0yUKWRf8GfT7lSK5gsLheGHT+8AhQkmvKzowZNnpWuB7O6mAMDqPem JtHZSicGhrAXfsPwMiCADj2N8zUYdw5ZHT7qd2t/olLX X-Google-Smtp-Source: AK7set/XAqNjaXiCIBeXrLHnj+etObfYRH1UxKlL5apjlF8D1eq1pyxP1P1iKJ361snMfxhxtNqcCaif92wHHltBFdQ= X-Received: by 2002:a17:906:6a89:b0:8b1:780d:e43d with SMTP id p9-20020a1709066a8900b008b1780de43dmr3686423ejr.13.1679303651184; Mon, 20 Mar 2023 02:14:11 -0700 (PDT) MIME-Version: 1.0 References: <45e80ead7387ef50026922c217a33719bfc66a4a.camel@xry111.site> <830648d9293be2e7895e0b40ccac9cce16858aa3.camel@xry111.site> In-Reply-To: <830648d9293be2e7895e0b40ccac9cce16858aa3.camel@xry111.site> From: Jonathan Wakely Date: Mon, 20 Mar 2023 09:14:00 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: use new built-in trait __is_reference To: Xi Ruoyao Cc: Ken Matsui , gcc-patches@gcc.gnu.org, Patrick Palka , libstdc++@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 20 Mar 2023 at 08:08, Xi Ruoyao via Libstdc++ wrote: > > On Mon, 2023-03-20 at 01:03 -0700, Ken Matsui wrote: > > Oops, I assumed those were my email... Thank you for your heads up and > > your comments! > > > > > Bad ChangeLog format. You should have a tab (not 4 or 8 spaces, nor > > > nothing) to indent the ChangeLog content. > > > > Do you mean like the following? > > > > ``` > > libstdc++-v3/ChangeLog: > > > > [TAB]* include/std/type_traits (is_reference): Use __is_reference > > built-in > > trait. > > ``` > > Yep. > > > > Is there any benefit to use a builtin, instead of the existing > > > implementation? I can see no but maybe I'm stupid. > > > > My patches are based on the GSoC project "C++: Implement compiler > > built-in traits for the standard library traits". These built-in > > traits basically make the compilation faster. > > > > https://gcc.gnu.org/wiki/SummerOfCode > > Ok, to me making compilation faster is a valid reason. Does it actually make compilation faster though? Has it been measured? > > > The patch fails to apply. It seems because your mail client inserted an > > > additional newline before "b/". Try to use git-send-email or configure > > > the mail client properly. > > > > Let me try to use git-send-email instead. I stupidly don't understand > > how to use them, so I was making my patches manually... > > Or adjust the mail client correctly. You can send the patch to yourself > first and see if it's not "mangled" by the mail client when you debug > such an issue... > > But when you finally end up sending 10 patches in a series you'll find > git send-email much easier :). Figuring out how to generate proper patches is an important part of contributing to GCC, so part of any GSoC project.