From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 6CBAD3858402; Thu, 28 Sep 2023 18:52:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CBAD3858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9ae2cc4d17eso1758482766b.1; Thu, 28 Sep 2023 11:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695927163; x=1696531963; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PHFXYuyjDHO9ah5O1vuxwHowTS4u9wst+SPgMgZQDE8=; b=Etj+ZiC4SdeKByb+mLn5k/FMEQN0YcEBKHJegWxyuwoUUvirMcfTY/vmD5v1h3TYwd J2AXrSWpGwHGGekcdhmfHgsFXBguXcH3rxXIoxnmCnykWGP6hHJzy4jGhixelkh5Wjm1 3JrgBNKhvymogKM2piYCnrQt2QHEGfhRdqUTZpUN1Q54oWkLEb3jWNUVLeqp8M5DNRjG twcS9G921O2um5UwqjNMl3O8J4KjpJIjWymMy0UDpOHGnNHb0aByVlMD58ZjCUfl8Mvj JACUTf3W4nnO9DqaVudMCY3j0wN3WXx7t8Ow6zuT1K2PVO3RjfKz+Nkh1mG/N717Xcvf novA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695927163; x=1696531963; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PHFXYuyjDHO9ah5O1vuxwHowTS4u9wst+SPgMgZQDE8=; b=O6M7bBnMPQIxYIqhWvPZJE1vGQQMABmUUlpUMnRpyZPWIqkdcvBlEIDwebHeEtOMBT OcgTeeb+onHMmCwYpdtq+XoZw0EHCBDcudp6I8bZS9l96lN8EaPeNNnSx8Wrw/NnP+ka Zu1/prz2Iy3oHWSOkuWss/Kpkjyr1hufjT9otNKmWEhwLXsMCE+607LHA/4CNT/aVCFA uDLB1Dl3p5UJ45sYMfLYyM2rlMFiWHeZ/pNHONmgjHDo8F99uZDH1bjaBvEeD/FSWWGI zMQZOA7wXoJEX7vCH7fykPoAgMUMbG4cPCM/C6r5SVA/42qa95hsYssQmZCpe5kI2oLd ShEA== X-Gm-Message-State: AOJu0Yyi+3Qd7TtAdkVd9ceQs1FAuYSoB7o/sa8xipv0qeCNVAc3b8lt Jv99Yv6YD3a2y8RZx28wQTQfhDJjaDXFBTl2mfM= X-Google-Smtp-Source: AGHT+IHLuOvfDitH0q7KnJXH2G8o+P1hDa7Qb2Qx/yizPl4pr0oom4CxSog69g/Kc9aNPv2HT+8HivqGsYR8hevFjys= X-Received: by 2002:a17:906:738f:b0:9ae:3f69:9b89 with SMTP id f15-20020a170906738f00b009ae3f699b89mr2039332ejl.7.1695927162948; Thu, 28 Sep 2023 11:52:42 -0700 (PDT) MIME-Version: 1.0 References: <20230928174630.4004388-1-tromey@adacore.com> <20230928174630.4004388-8-tromey@adacore.com> In-Reply-To: <20230928174630.4004388-8-tromey@adacore.com> From: Jonathan Wakely Date: Thu, 28 Sep 2023 19:52:31 +0100 Message-ID: Subject: Re: [PATCH 7/7] libstdc++: Use Python "not in" operator To: Tom Tromey Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="0000000000001cd18c06066fd0da" X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001cd18c06066fd0da Content-Type: text/plain; charset="UTF-8" On Thu, 28 Sept 2023, 18:54 Tom Tromey via Libstdc++, wrote: > flake8 warns about code like > > not something in "whatever" > > Ordinarily in Python this should be written as: > > something not in "whatever" > > This patch makes this change. > OK, thanks. > libstdc++-v3/ChangeLog: > > * python/libstdcxx/v6/printers.py (Printer.add_version) > (add_one_template_type_printer) > (FilteringTypePrinter.add_one_type_printer): Use Python > "not in" operator. > --- > libstdc++-v3/python/libstdcxx/v6/printers.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py > b/libstdc++-v3/python/libstdcxx/v6/printers.py > index d125236b777..380426cd41e 100644 > --- a/libstdc++-v3/python/libstdcxx/v6/printers.py > +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py > @@ -2321,7 +2321,7 @@ class Printer(object): > # Add a name using _GLIBCXX_BEGIN_NAMESPACE_VERSION. > def add_version(self, base, name, function): > self.add(base + name, function) > - if _versioned_namespace and not '__cxx11' in base: > + if _versioned_namespace and '__cxx11' not in base: > vbase = re.sub('^(std|__gnu_cxx)::', r'\g<0>%s' % > _versioned_namespace, base) > self.add(vbase + name, function) > @@ -2494,7 +2494,7 @@ def add_one_template_type_printer(obj, name, > defargs): > printer = TemplateTypePrinter('std::__debug::'+name, defargs) > gdb.types.register_type_printer(obj, printer) > > - if _versioned_namespace and not '__cxx11' in name: > + if _versioned_namespace and '__cxx11' not in name: > # Add second type printer for same type in versioned namespace: > ns = 'std::' + _versioned_namespace > # PR 86112 Cannot use dict comprehension here: > @@ -2589,7 +2589,7 @@ class FilteringTypePrinter(object): > def add_one_type_printer(obj, template, name, targ1=None): > printer = FilteringTypePrinter('std::' + template, 'std::' + name, > targ1) > gdb.types.register_type_printer(obj, printer) > - if _versioned_namespace and not '__cxx11' in template: > + if _versioned_namespace and '__cxx11' not in template: > ns = 'std::' + _versioned_namespace > printer = FilteringTypePrinter(ns + template, ns + name, targ1) > gdb.types.register_type_printer(obj, printer) > -- > 2.40.1 > > --0000000000001cd18c06066fd0da--