From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 8B2843858D32; Tue, 16 Apr 2024 06:38:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B2843858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B2843858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713249515; cv=none; b=FYWryqYn4QGQAYvM+FaUQZ5ULYD10ddArBe73DtgdZ+/h7NT815j790anhk6l5/E0FG8WxzzakGTO5yNKDcpl9pdqO6kO1nrgzH2m/1Vk641O90LXam0V+xA/EAN3ubm3iVvxcdThvertNzq97cuJrfVSDsKC9xYRvcDAYzVDD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713249515; c=relaxed/simple; bh=5/arDoj4fbxXZDMKhbWTak8zadZtVNHkA9YKwM2baMM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=GiSoM2LufC65ex7mIVcNuASICUY8t/AyEX/O/zVjCcmSivAv8/RA/FM+4int4S0glX9zMHOBb+O+fgwoTnkV97+9iBYx5HRB8WyPJY8K4bZYyVjoFkmQ4gvKkn8VWMUxXzGjeBRLdD8iRWyVrtVvhjtJB9slbVti5wGKNjWQTfc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-56e6a1edecfso6309684a12.1; Mon, 15 Apr 2024 23:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713249511; x=1713854311; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4EwYbNrxxg2lj3dXxPuJxtteun+LIV4nBlFaPCPtf/0=; b=IZ22GVHCQ1V+cb9LrMqA0bVoW1+dpbnH6ZyBwBkJ6j6XA2RNyNKbGWB+h7QXi0NQgL iAG1zkfPw/MfUYNHkzmZR54yXijGMpSigkyqYD+S+msBNc2Gk3zK+5kbXL8ohOjbp55p /IxyWfSn7rgrYh8YSzsphNy0ITFit3dLS5sPxlLQweGOfS4st5uxKYUYlzFSUHlLzRnf qNTePENfF89BjYdEUBV9FHLUq3ErMtHX8yYK5UczdItQA3UWWFAPNw5iux50dvLUl6B+ lRhfOtb1kJjFMDePHnl71wvREr7EjctSFQRAJ1IQ7PClq/Kce8qWb/SQOmRXdaqTbJ3u AN/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713249511; x=1713854311; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4EwYbNrxxg2lj3dXxPuJxtteun+LIV4nBlFaPCPtf/0=; b=h6aYjhbvUk1yu9NpVB/OAKqaIDNzUXKG+8iaDV1AwpsyEfL0quoSVl+XzaGC8aV+Jg zW+x9xHOcSOCDhXnAg3o7OMCwCofU5GOUEB5wNRe/P420cYkvfjKRTFeEqh4cYbxRBgY oxhEOYR88eqkzz2NqpfglOcGSuX7Pl2MgInJCCbHR6GOj2rIeFUFjoR2zaduuJZ/5t5f vTO61r552SvN/WBjzqSf4XNEH7D7HMWC0WCejq14quoIF2PlH6iaz9peSYKJE9CT++75 UcoJ85JBxT/4bOZ68IdJBCzSJkCeYl1OrGeIgM3sXsnXyrniVeljriiq6EY46ozP28SE URLQ== X-Forwarded-Encrypted: i=1; AJvYcCU4MphxvJ81sdw/7smjjawsqNdNa2+sfw0omvvDOtI9DU46az5s1h9iXAf+C2gQxLy/S3VRpEfrrNlZ6ytzdTSaGNPPejo= X-Gm-Message-State: AOJu0YwvGaETq7Epqt6SekrgNaiIhRVqKFKA91S9GV5FuGL2DuPtpKOH 1FPe/SZlPwZZvI207T8V3pHB43IqdNhzxRmKvg5NzEkpvsdzOVmrL5652Ci+r0nIF/wGOBFnocT yp0XwdifsVa1a0vtKPMYzyGIduQGHPg== X-Google-Smtp-Source: AGHT+IEcU8vbHdp7c/9p/2dzwzWmm8NCdGD0CSKhIPeXm+VmcvrAyli1KmBzw8C/IspTc+SYuik39olxO2VvCS7Vxws= X-Received: by 2002:a17:906:d54c:b0:a51:9416:4c9d with SMTP id cr12-20020a170906d54c00b00a5194164c9dmr9980816ejc.46.1713249511167; Mon, 15 Apr 2024 23:38:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Tue, 16 Apr 2024 07:38:19 +0100 Message-ID: Subject: Re: [PATCH] [libstdc++] [testsuite] xfail double-prec from_chars for float128_t To: Alexandre Oliva Cc: gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000865e3a061630fcc6" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000865e3a061630fcc6 Content-Type: text/plain; charset="UTF-8" On Tue, 16 Apr 2024, 04:19 Alexandre Oliva, wrote: > > Tests 20_util/from_chars/4.cc and 20_util/to_chars/long_double.cc were > adjusted about a year ago to skip long double on some targets, because > the fastfloat library was limited to 64-bit doubles. > > The same problem comes up in similar float128_t tests on > aarch64-vxworks. This patch adjusts them similarly. > > Unlike the earlier tests, that got similar treatment for > x86_64-vxworks, these haven't failed there. > > Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-, > aarch64-, x86- and x86_64-vxworks7r2. Ok to install? > OK, thanks > > for libstdc++-v3/ChangeLog > > * testsuite/20_util/from_chars/8.cc: Skip float128_t testing > on aarch64-vxworks. > * testsuite/20_util/to_chars/float128-c++23.cc: Xfail run on > aarch64-vxworks. > --- > libstdc++-v3/testsuite/20_util/from_chars/8.cc | 3 ++- > .../testsuite/20_util/to_chars/float128_c++23.cc | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libstdc++-v3/testsuite/20_util/from_chars/8.cc > b/libstdc++-v3/testsuite/20_util/from_chars/8.cc > index ee60d88c332db..a6343422c5a91 100644 > --- a/libstdc++-v3/testsuite/20_util/from_chars/8.cc > +++ b/libstdc++-v3/testsuite/20_util/from_chars/8.cc > @@ -17,6 +17,7 @@ > > // { dg-do run { target c++23 } } > // { dg-add-options ieee } > +// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target > aarch64-*-vxworks* } } > > #include > #include > @@ -343,7 +344,7 @@ test06() > #if defined(__STDCPP_FLOAT64_T__) && > defined(_GLIBCXX_DOUBLE_IS_IEEE_BINARY64) > test_max_mantissa(); > #endif > -#if defined(__GLIBCXX_TYPE_INT_N_0) \ > +#if defined(__GLIBCXX_TYPE_INT_N_0) && !defined SKIP_LONG_DOUBLE \ > && defined(__STDCPP_FLOAT128_T__) && > defined(_GLIBCXX_LDOUBLE_IS_IEEE_BINARY128) > test_max_mantissa(); > #endif > diff --git a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc > b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc > index 547632817b4bb..ca00761ee7c98 100644 > --- a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc > +++ b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc > @@ -19,6 +19,7 @@ > // { dg-require-effective-target ieee_floats } > // { dg-require-effective-target size32plus } > // { dg-add-options ieee } > +// { dg-xfail-run-if "from_chars limited to double-precision" { > aarch64-*-vxworks* } } > > #include > #include > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive > --000000000000865e3a061630fcc6--