From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 1AFD638582AE for ; Tue, 6 Sep 2022 10:56:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1AFD638582AE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62b.google.com with SMTP id dc5so2443276ejb.9 for ; Tue, 06 Sep 2022 03:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5joSIlEBU56O3BAMaH26dt3jjM9Bj16Z4vGPiFV+ZpU=; b=qXw7xwae4mrro1IQa5L8rluhnFecBdKqivMDuyrLRa1AedlsHwL5imc1SDNwz3ZyvU BWqYBFFvgzhcAygwhdi6Q3BX0t0EGqPo3gZsw1HlzBVV88mcR0zsFfg9nC9H2xgJtxt/ 3YHdsh2TTlcw2NrBRSfixtjTpxWFtIVd95InI/WPQEEL9tycOEKiu65qNUtKfqmjfDAr iWkQ+bnEITh9DAAPevOB1vgF+FjWa1AJ+9rM8uSdTSvlS/kYt9V2mt/xZiCZeuUsOWXh YSjoJ0g/3BvJaKzFfMiV4fSU4IluXx1dXzr0TO+H0yLI9Y/AdEwLq6IyFdj7nPUHXPkT PAmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5joSIlEBU56O3BAMaH26dt3jjM9Bj16Z4vGPiFV+ZpU=; b=sJSClb+1YNcxWLpgTm5dJ1CVjzDIfIwCJykf+wNxvmK3C02k3JG8TN73FG6qOL2joW q6PIX+c94EsCsktnChryGE1AjEbk74G/pjnIdVA7slEF8esRtzEw76luQ+z2jQ/rGJ8G 1RMRHnFedgSseKbkV01DC+2ogdu+4Ppdo3uzAnmocKOvvIke7DgniyAMQmxCPhbEQFvq mJ4fZN0CNVL/9yHL9O+ol0Oa03qMBi/KyNKyHgozmowMFwni1aRd2GLQUI55u8jm242o UQusQAkbOsNe7kyFpUHlxvscOscfrHNM3UKspZ7ynkXjPOR+9M2h6/nLxTWrOcmkCXTw mWCA== X-Gm-Message-State: ACgBeo1EZUppeIBeLC/kvqdHeP3lUVj6QFjn7aJQQgK8AbDuZhjWTS43 fmpLqoWPQamQFdRILm1+D0xSDIMiMb5K+lxWkFM= X-Google-Smtp-Source: AA6agR4+W5qJGYsutDRmHe2Q4udoRzS1ENdA7hpNBrmr1bM4NSyDSzZn+wJGb+0ojxKSs/AWR9rb4Jyhq4il66salTk= X-Received: by 2002:a17:906:fd8a:b0:75d:c79a:47c8 with SMTP id xa10-20020a170906fd8a00b0075dc79a47c8mr10257555ejb.389.1662461790724; Tue, 06 Sep 2022 03:56:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Tue, 6 Sep 2022 11:56:19 +0100 Message-ID: Subject: Re: GPL carve-out missing for barrier To: Tom James Cc: "libstdc++" , Moritz Kreutzer , "Jones, Philip" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 6 Sept 2022 at 11:29, Tom James wrote: > > Hi, > > I'm working on a closed-source c++ project that compiles with gcc 11.2. We > need to ship the GNU 11.2 run-time alongside our product, and it looks like > the std::barrier header is missing the GPL3 carve-out for shipping > run-times. Ouch, I'm pretty sure that's unintentional. I'll go back through my email to confirm that. > For the purposes of comparison, let's look at algorithm: > https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/algorithm > > Lines 16-18 read as follows: > // Under Section 7 of GPL version 3, you are granted additional > // permissions described in the GCC Runtime Library Exception, version > // 3.1, as published by the Free Software Foundation. > > These lines are necessary to prevent the GPL infecting our closed-source > code. What exactly are you shipping? There is no code from in libstdc++.so so unless your own code is including the header and odr-using the inline functions and templates in that header, I think your compiled code will not be affected by the license of . If you are including that header in the works you propagate, or shipping it to customers for compiling their own works which they will propagate, then the license exception matters. > The barrier header appears to be missing these lines: > https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/barrier > > > Would it be possible to please make the following changes? > 1. Add these lines to the master branch, > 2. Backport these lines to gnu 11.2 (which is the most recent version > supported by our toolchain). No, we can't backport anything to 11.2 because that's already been released. I'll add it to the master, gcc-12, and gcc-11 branches, which will mean it's present for 11.4, 12.3 and 13.1 (and all releases that follow them). If you are producing a combined work that includes the code, then unless/until you're able to wait for 11.4 and use that, you could copy the fixed header into your own GCC 11.2 that you distribute.