From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 6C7103858D1E; Sat, 24 Dec 2022 12:07:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C7103858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x533.google.com with SMTP id u18so8822553eda.9; Sat, 24 Dec 2022 04:07:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZXxjQvltCdzqhCFIkilv0X24KPzZzqUMcgfBUCNtm7I=; b=oRUdl72HkOi7qogAKnFgZq1nIDYW/5K1XBwf4rXGbywtSsRKINVYu6rNdi4/QrSDZe 8wPyafp2OEK2RaaMSIVmde2ZoTrMjfsoU0O37uRKoLUW0RfdPC/AFeWpI2bw1OggOfIW 9q/3UU1QiKGUCyCScyQhlShMG98lQTStYOCHKbPYEZQ+dHerOwZmh3ZDa05RI3wB3lVg 1Dl6hnGBgom8MNsoBtAwNJXyFHvanK+Nxo7ui/Tepy9lb3GVWK0h3Ono2uX2kyuhF94J NxWMvOFaoNbtVx4MtKehvMTZBJgGJgS7YR6DBr1+aL2rYt2h5TjaiIRrAKATZd/KW9+v N6fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZXxjQvltCdzqhCFIkilv0X24KPzZzqUMcgfBUCNtm7I=; b=uv5hPXewPkhG3MLTAq8lbnqHf/OriGq35JmhKpVXDzdmyfZEmpumZPNioQr0iPinwx Y+HzsMTWJGM9RDoUzsFWDLT4kGaDz+6jwo6SMvE4bIvEV+7AG/cMc5Dfk7ItXPR+fb61 9+g33U5AOar7lF1SZJ/CZPHBeE7dOXpvneG0Jn4KPg+EQ93WawsDNNK32DNLbv/qc/ym fBZ+8AQHmGVG1te7v6usyrc25UbTRc97b9kFrqhecwP9hpbHYfid9R/TB/Yxm3jurw1o vxUeRhDjsIVUdEPBblnuk6YX538+KG8ln4FoGCFUdwjr0eutHJrcmbMtbkKWeycxE8PM 7Z6Q== X-Gm-Message-State: AFqh2krAStee7aaCSu3PyGC61UN+vGdeuOfYSRnUbTMv5r6voTV/GiZJ LQwKTMkjSRtNdXz+afLDKPghg/Kqgi5kNN1bSIon0i4y X-Google-Smtp-Source: AMrXdXs5RaPxjrJfodIRFP8rKnG58a2ajpSY8FfUI4Cct698upAXY8rNsUl1b4bZLItQlVbc8qtTD7MGMAEUIm8kBi8= X-Received: by 2002:a05:6402:2993:b0:46c:af80:636c with SMTP id eq19-20020a056402299300b0046caf80636cmr1280987edb.129.1671883657210; Sat, 24 Dec 2022 04:07:37 -0800 (PST) MIME-Version: 1.0 References: <20221224114234.20419-1-iain@sandoe.co.uk> In-Reply-To: <20221224114234.20419-1-iain@sandoe.co.uk> From: Jonathan Wakely Date: Sat, 24 Dec 2022 12:07:25 +0000 Message-ID: Subject: Re: [PATCH] libstdc++, testsuite: Correct an init. To: Iain Sandoe Cc: "libstdc++" , gcc-patches , Iain Sandoe Content-Type: multipart/alternative; boundary="0000000000007e706905f091bfa1" X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007e706905f091bfa1 Content-Type: text/plain; charset="UTF-8" On Sat, 24 Dec 2022, 11:43 Iain Sandoe via Libstdc++, wrote: > Noticed while debugging tz info support on Darwin, unless I miss > some other reasoning... > OK for trunk? > Doh, thanks. OK for trunk. Iain > > --- 8< --- > > in leap_seconds.cc, we are testing to see if the function that > overrides the default zoneinfo directory has been called. That > is implemented with a static boolean that needs to be initialized > to false. > > Signed-off-by: Iain Sandoe > > libstdc++-v3/ChangeLog: > > * testsuite/std/time/tzdb/leap_seconds.cc: Initialize the > override_used test var to false. > --- > libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc > b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc > index 82303e8bdf0..2b289436583 100644 > --- a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc > +++ b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc > @@ -7,7 +7,7 @@ > #include > #include > > -static bool override_used = true; > +static bool override_used = false; > > namespace __gnu_cxx > { > -- > 2.37.1 (Apple Git-137.1) > > --0000000000007e706905f091bfa1--