From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely.gcc@gmail.com>
Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com
 [IPv6:2a00:1450:4864:20::32f])
 by sourceware.org (Postfix) with ESMTPS id 5DADE3858407;
 Sun, 13 Feb 2022 22:15:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DADE3858407
Received: by mail-wm1-x32f.google.com with SMTP id
 az26-20020a05600c601a00b0037c078db59cso5255223wmb.4; 
 Sun, 13 Feb 2022 14:15:37 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=LCBfCaUnZNa0vVji5zjQmSJXPxOg7enanjLgFi34gtA=;
 b=4lHMUtjBRh1swWUH9ZB6//n4erQHBrC2fsu0xayRb3gD4gNsHG7d1BTms6pyc5RkuE
 8RUD8cNNFnpikxETqmhIuUgw05bidjJ8SBGdPD4sVvphOlnVGs3sQ5Fi6LP7lo1NNjAf
 adVq2AkqIFYwHlONnLWgFDltzCO60+1+8lWGbB4RILREUJ+ZrqDdnBkuVb2HjulDnKKr
 t2Tcl0xwOwOFnaePOtNe5VwrpoYb89btjTqhwylfu3yu1sIXbPL4Le0kQP4wto3+NyU4
 jYivOhFdODGM2ZpRDkWucgkWHkGAq8mYURMXQgl65pyx4PGEweV8ginjAFN7cgk3gOmb
 89sw==
X-Gm-Message-State: AOAM532y0MbjPZLrgXoYfcx8Y8w2BIxY3NsCQzXVfEv9c0xCem3OGhvV
 l4DlOGEQ7FRwSDGcC0PKzJcOWv9x7toA/fjlnpE=
X-Google-Smtp-Source: ABdhPJwl0C9r3hjTI3Kndw3YZMTw+5faJDIz7/SfzHeYZxCZnGGosaRQFXVAYQ0ch4Vw1lbSoym2X5YegHkYbC5a7RM=
X-Received: by 2002:a05:600c:4ca1:: with SMTP id
 g33mr8845426wmp.108.1644790536204; 
 Sun, 13 Feb 2022 14:15:36 -0800 (PST)
MIME-Version: 1.0
References: <20220211221551.3383447-1-jwakely@redhat.com>
 <alpine.BSF.2.20.16.2202131614530.10262@arjuna.pair.com>
In-Reply-To: <alpine.BSF.2.20.16.2202131614530.10262@arjuna.pair.com>
From: Jonathan Wakely <jwakely.gcc@gmail.com>
Date: Sun, 13 Feb 2022 22:15:20 +0000
Message-ID: <CAH6eHdR6RSb7jNCExgLRwNi8Hxz4tytYa2-QfSh0DPTYP8_csw@mail.gmail.com>
Subject: Re: [committed] libstdc++: Fix test failures at -O0
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: Jonathan Wakely <jwakely@redhat.com>, "libstdc++" <libstdc++@gcc.gnu.org>, 
 gcc-patches <gcc-patches@gcc.gnu.org>
X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: libstdc++@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libstdc++ mailing list <libstdc++.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/libstdc++/>
List-Post: <mailto:libstdc++@gcc.gnu.org>
List-Help: <mailto:libstdc++-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/libstdc++>,
 <mailto:libstdc++-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Feb 2022 22:15:39 -0000

On Sun, 13 Feb 2022, 21:21 Hans-Peter Nilsson, <hp@bitrange.com> wrote:

> On Fri, 11 Feb 2022, Jonathan Wakely via Gcc-patches wrote:
> > diff --git
> a/libstdc++-v3/testsuite/20_util/unsynchronized_pool_resource/allocate.cc
> b/libstdc++-v3/testsuite/20_util/unsynchronized_pool_resource/allocate.cc
> > index c81344a20e4..25e5ce63b58 100644
> > ---
> a/libstdc++-v3/testsuite/20_util/unsynchronized_pool_resource/allocate.cc
> > +++
> b/libstdc++-v3/testsuite/20_util/unsynchronized_pool_resource/allocate.cc
> > @@ -281,10 +281,13 @@ test07()
> >    std::pmr::unsynchronized_pool_resource upr(&cr);
> >    try
> >    {
> > +#pragma GCC diagnostic push
> > +#pragma GCC diagnostic ignored "-Walloc-size-larger-than="
> >      // Try to allocate a ridiculous size (and use a large extended
> alignment
> >      // so that careful_resource::do_allocate can distinguish this
> allocation
> >      // from any required for the pool resource's internal data
> structures):
> >      void* p = upr.allocate(std::size_t(-2), 1024);
> > +#pragma GCC distinguish pop
>
> Isn't it a bug that you (presumably) didn't get an error for
> that misspelling?  Or a diagnostic to distinguish it?  8-}
>


Oh! I guess I typed di then ctrl-p to complete it (a vim shortcut).

I think it should warn with -Wunknown-pragma or whatever the option is, but
we probably don't use that for the libstdc++ tests.

I'll fix that in the morning, thanks for spotting it.