From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 399D23857C6D; Tue, 19 Oct 2021 18:48:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 399D23857C6D Received: by mail-wm1-x32c.google.com with SMTP id b189-20020a1c1bc6000000b0030da052dd4fso4868480wmb.3; Tue, 19 Oct 2021 11:48:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oq3WR4+lDY91QAr2ryJfeXGELajcF5zBOgspfuUhRrs=; b=Irxpm1Jtozmh6n7WKp4LjIUFmUclRAY16SWLRjbTKpXknV5jl/kzfObGUeLzBZu/rN ABT+LHMKns973KV63Kn/AZ2PDqMN/qz3ZgakqgCDOMDcmD+HxBXmxqpY4NMIo75QJW57 J5V3bux8YWYAQ3gBotQE379kcWY045U3lmWhtXsxNYB6UY4zV94vU9fyb907AaGtWowL mPwkD9FrO5TInuAYZxjOD8CXj2OMkpWFC/J/l3vlfdJXpWSfsa+NC0C6gTseUJOUOcpJ a3SSOs08gNcGRszD8VgK4cmzVLVISKSLx7DxazOd2LbXQNJ7yHbp/JV2kclcTIXGsfdN yeKg== X-Gm-Message-State: AOAM5329mOJVtqvYKee9nk5/S3gVq3bW0euFBq02XO98gQuCmIdpIJbG ZA5645u1CIcDxo2khRwyQ1Tk139Phm30KxX1W+H3jRAM X-Google-Smtp-Source: ABdhPJxRxf1sc9UWjHvW6NXwmoUHX1hXUSvD4l7SXF8vKGX7kL2LjlqjgG+bLw5lYqBhn3UOCwLNdkvkvAAeqybUojY= X-Received: by 2002:a7b:c442:: with SMTP id l2mr8101295wmi.131.1634669280376; Tue, 19 Oct 2021 11:48:00 -0700 (PDT) MIME-Version: 1.0 References: <20211019182939.1694113-1-ppalka@redhat.com> In-Reply-To: <20211019182939.1694113-1-ppalka@redhat.com> From: Jonathan Wakely Date: Tue, 19 Oct 2021 19:47:49 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Implement LWG 3568 change to ranges::basic_istream_view To: Patrick Palka Cc: gcc-patches , "libstdc++" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 18:48:02 -0000 On Tue, 19 Oct 2021, 19:31 Patrick Palka via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > Yes, thanks. (The branches don't have P2325R3.) > > libstdc++-v3/ChangeLog: > > * include/std/ranges (basic_istream_view::_M_object): Value > initialize as per LWG 3568. > --- > libstdc++-v3/include/std/ranges | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libstdc++-v3/include/std/ranges > b/libstdc++-v3/include/std/ranges > index 5e18c98eb2f..4a90f115d2f 100644 > --- a/libstdc++-v3/include/std/ranges > +++ b/libstdc++-v3/include/std/ranges > @@ -711,7 +711,7 @@ namespace views > > private: > basic_istream<_CharT, _Traits>* _M_stream; > - _Val _M_object; > + _Val _M_object = _Val(); > > struct _Iterator > { > -- > 2.33.1.711.g9d530dc002 > >