public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Jonathan Yong <10walls@gmail.com>
Cc: "Hugo Beauzée-Luyssen" <hugo@beauzee.fr>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	libstdc++ <libstdc++@gcc.gnu.org>,
	NightStrike <nightstrike@gmail.com>, lh_mouse <lh_mouse@126.com>
Subject: Re: [PATCH] libstdc++-v3: Check for TLS support on mingw
Date: Wed, 1 Sep 2021 10:52:48 +0100	[thread overview]
Message-ID: <CAH6eHdRD7+V6yp3f1XvDA+NksYMVkRURVnJ4hskPKsf_LsixZA@mail.gmail.com> (raw)
In-Reply-To: <e2fd83e2-fb62-44d9-44ad-fa3f89a6b170@gmail.com>

On Wed, 1 Sept 2021 at 02:44, Jonathan Yong <10walls@gmail.com> wrote:
>
> On 8/31/21 9:02 AM, Jonathan Wakely wrote:
> > It looks like my questions about this patch never got an answer, and
> > it never got applied.
> >
> > Could somebody say whether TLS is enabled for native *-*-mingw*
> > builds? If it is, then we definitely need to add GCC_CHECK_TLS to the
> > cross-compiler config too.
> >
> > For a linux-hosted x86_64-w64-mingw32 cross compiler I see TLS is not enabled:
> >
> > /* Define to 1 if the target supports thread-local storage. */
> > /* #undef _GLIBCXX_HAVE_TLS */
> >
> >
> >
> >
> > On Mon, 19 Feb 2018 at 08:59, Hugo Beauzée-Luyssen <hugo@beauzee.fr> wrote:
> >>
> >> libstdc++-v3: Check for TLS support on mingw
> >>
> >> 2018-02-16  Hugo Beauzée-Luyssen  <hugo@beauzee.fr>
> >>
> >>      * crossconfig.m4: Check for TLS support on mignw
> >>      * configure: regenerate
> >>
> >> Index: libstdc++-v3/crossconfig.m4
> >> ===================================================================
> >> --- libstdc++-v3/crossconfig.m4 (revision 257730)
> >> +++ libstdc++-v3/crossconfig.m4 (working copy)
> >> @@ -197,6 +197,7 @@ case "${host}" in
> >>       GLIBCXX_CHECK_LINKER_FEATURES
> >>       GLIBCXX_CHECK_MATH_SUPPORT
> >>       GLIBCXX_CHECK_STDLIB_SUPPORT
> >> +    GCC_CHECK_TLS
> >>       ;;
> >>     *-netbsd*)
> >>       SECTION_FLAGS='-ffunction-sections -fdata-sections'
>
> According to MSYS2 native from
> https://mirror.msys2.org/mingw/ucrt64/mingw-w64-ucrt-x86_64-gcc-10.3.0-5-any.pkg.tar.zst:
>
> x86_64-w64-mingw32/bits/c++config.h:#define _GLIBCXX_HAVE_TLS 1
>
> So yes.

Thanks! I'll test the patch on a cross-compiler and apply it soon then.

(Thanks also to LH for the answer)

  reply	other threads:[~2021-09-01  9:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19  8:59 Hugo Beauzée-Luyssen
2018-02-26 21:05 ` Jonathan Wakely
2021-08-31  9:02 ` Jonathan Wakely
2021-08-31 14:29   ` lhmouse
2021-09-01  1:46   ` Jonathan Yong
2021-09-01  9:52     ` Jonathan Wakely [this message]
2021-09-15  8:53       ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH6eHdRD7+V6yp3f1XvDA+NksYMVkRURVnJ4hskPKsf_LsixZA@mail.gmail.com \
    --to=jwakely.gcc@gmail.com \
    --cc=10walls@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hugo@beauzee.fr \
    --cc=lh_mouse@126.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=nightstrike@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).