From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=T0aN=4C=gmail.com=jwakely.gcc@sourceware.org>
Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e])
	by sourceware.org (Postfix) with ESMTPS id A005E385188B;
	Sun,  4 Dec 2022 12:34:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A005E385188B
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ed1-x52e.google.com with SMTP id i15so4100263edf.2;
        Sun, 04 Dec 2022 04:34:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=4AUgmzD+1aAwv/Vi+jaxgIYRQ0pYdAYKZ/Pxgir8XjM=;
        b=lYRQQfMjDbptEwM9Z5ls+G/zWfnLl5zVbCtHjAMsVkSUJ3gXKTVBGoEVPA+lYjdAnW
         tvtROIx07c1wjQOmux/ADrTc9RtaGbfV6RFaZJRXbvAhzh+2QmpT5BILlCfXAn9aQQl5
         qsgTlGQ7nfjJXUFs+xyA+TYO1KG4OH8FEFambtqhfhhgQG+CMC9J5PFMHNhdHAI+k1vO
         nywawUJf9n1slmcWlbztiFuCo0bWOjp9ysqZyoSqMXMVinB31rG+ObRNwzrOcA6FIygU
         FWJWtkjEEKSBoYM1m/TXl231quvdVJs77ooLm5zUcoW1TUn1ri947kSIDQOyzD1GXMe9
         OmTQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=4AUgmzD+1aAwv/Vi+jaxgIYRQ0pYdAYKZ/Pxgir8XjM=;
        b=n4zTFeAxb/kW8CY3TPZ44jlM+uBtZ9tNxMdQYk/iA/sia8fVeaEtu1qXp43DXEUFSD
         ljWryImcCbnCNIPTaVkTC9jauF8fM2desO3VW2SlU1qWlvHPNk2Z3/pPgXo2/mPfBbNh
         GjdsrhZEsP6/S0iUtTFCdoeeQ34L1tSbjU1KFSAb8YSItirCYMKd7EoKzH5JsbM0hGCw
         /w6owLT1e87vjr8rX+d3TR4BZcPu3/tEmUNjq8TYHFyxGLc76JWjkaux/Gu4J5hLnMM1
         +/5IwI6mYbrCjfIkmLGMtJKuwIHdHKYEutcgWeJKoZxRAflA4PVQyPfh2+ophEPtJ0MD
         feXA==
X-Gm-Message-State: ANoB5pkjNBiglvf81sWC9N60fQ9OLe4XbvoH8bSCL/VdbfjhpDAVg69m
	TO2F/Om3b7nVgb5PVZpBXOMG24aBJRmUeFzk83s=
X-Google-Smtp-Source: AA0mqf5uuQ7/y476QE4MdpgkGSgEeKmt6UMqCYGG4/O3IpJ7urAzz7JsXrPzgH0CsDFHYpKFGneX38FwxNEK/0tiXwE=
X-Received: by 2002:aa7:dbc7:0:b0:45f:b80f:1fe8 with SMTP id
 v7-20020aa7dbc7000000b0045fb80f1fe8mr67332890edt.118.1670157268227; Sun, 04
 Dec 2022 04:34:28 -0800 (PST)
MIME-Version: 1.0
References: <20221204105345.33234-1-iain@sandoe.co.uk>
In-Reply-To: <20221204105345.33234-1-iain@sandoe.co.uk>
From: Jonathan Wakely <jwakely.gcc@gmail.com>
Date: Sun, 4 Dec 2022 12:34:16 +0000
Message-ID: <CAH6eHdREMSvGW8Tqf7HJQ+O8id4T4R23Z=jsLM_iSJxisZU57w@mail.gmail.com>
Subject: Re: [pushed] libstdc++, Darwin: Fix weak attribute to use __weak__
 instead of weak.
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: "libstdc++" <libstdc++@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>, 
	Iain Sandoe <iains.gcc@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000b11d8405eeffcab6"
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>

--000000000000b11d8405eeffcab6
Content-Type: text/plain; charset="UTF-8"

On Sun, 4 Dec 2022, 10:54 Iain Sandoe via Libstdc++, <libstdc++@gcc.gnu.org>
wrote:

> As pointed out on irc by Jonathan, the Darwin os_defines contains a "weak"
> attribute where we should use '__weak__'.  Fixed thus, tested on i686,
> x86_64
> Darwin and x86_64 Linux, pushed to master, thanks,
> Iain


> -- >8 --
>

I wanted to be sure this wouldn't conflict with the __weak keyword for
obj-C so thanks for taking care of it.

--000000000000b11d8405eeffcab6--