From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 1FC7D383B428; Mon, 7 Jun 2021 15:30:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1FC7D383B428 Received: by mail-wm1-x333.google.com with SMTP id v206-20020a1cded70000b02901a586d3fa23so272511wmg.4; Mon, 07 Jun 2021 08:30:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WJLUICRQzxc6QJbBYoE50SrRoeIcDnBgSR0TsvDf9EI=; b=RRjvzhsyDaq4LoQV/gstYo5OEkxpHOeVklmu4LKr22TNtaOEycKSK0Ct8O/i6QwnZD spqqKMRj7ECP6yUG6HTwVV9mQo001pxeEwZYXPsATC15RiArgwH1f+6/jJZFZRciBfUa z3b3ybRfgoUMl1HSpVVJYRO4Sm827pG08GZ5F3NP+zsvFBk0mbl0N9leyVIIm6/FOMqw YOsuSApFX7MxjgaYGxup/py4Zbw+8VxlKWwE4gd6w1ETOkuwxUBZnwWP0j2a8F8+v+AR scY406+oVQEXvoLPHobtV3ucR1HcVruHm1lmmcL+n6md2WSyINMSo32uwt7rnCCSljmN rtNw== X-Gm-Message-State: AOAM531BEZ3oS2/mWZs9o/aSnI4jdT/MKbTfdKwY4CDcRjKw4Vi44XpX 5qjOuXK19T0KSgBhHpolCxolIo/dUromFRdwxZk= X-Google-Smtp-Source: ABdhPJyqegvuCYaR38RBIDgm+eqh6kBlfC9nBOrm/hKjHOjKBa2mFJH2q/DZ9FVOZWrFzfYX6hYuuRipyKe3dkC0EHY= X-Received: by 2002:a05:600c:4a29:: with SMTP id c41mr17858359wmp.17.1623079808023; Mon, 07 Jun 2021 08:30:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Mon, 7 Jun 2021 16:29:55 +0100 Message-ID: Subject: Re: [PATCH] PR libstdc++/98842: Fixed Constraints on operator<=>(optional, U) To: Jonathan Wakely Cc: "Seija K." , "libstdc++@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary="00000000000066ae5f05c42eb774" X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 15:30:12 -0000 --00000000000066ae5f05c42eb774 Content-Type: text/plain; charset="UTF-8" On Fri, 4 Jun 2021 at 21:41, Jonathan Wakely wrote: > > On Thu, 3 Jun 2021 at 17:27, Seija K. via Libstdc++ > wrote: > > > The original operator was underconstrained. _Up needs to fulfill > > compare_three_way_result, > > as mentioned in this bug report > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98842 > > > > Thanks, I'll get the patch applied next week. The patch causes testsuite failures. I fixed it with the attached change instead, including a workaround for an apparent C++20 defect. Pushed to trunk so far. --00000000000066ae5f05c42eb774 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kpmrruzm0 Y29tbWl0IGFkZWMxNDgxMTcxNGUyMmE2YzFmN2YwMTk5YWRjMDUzNzBmMGQ4YjAKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBNb24gSnVuIDcgMTM6 MDI6MTUgMjAyMQoKICAgIGxpYnN0ZGMrKzogQ29uc3RyYWluIHRocmVlLXdheSBjb21wYXJpc29u IGZvciBzdGQ6Om9wdGlvbmFsIFtQUiA5ODg0Ml0KICAgIAogICAgVGhlIG9wZXJhdG9yPD0+KGNv bnN0IG9wdGlvbmFsPFQ+JiwgY29uc3QgVSYpIG9wZXJhdG9yIGlzIHN1cHBvc2VkIHRvIGJlCiAg ICBjb25zdHJhaW5lZCB3aXRoIHRocmVlX3dheV9jb21wYXJhYmxlX3dpdGg8VSwgVD4gc28gdGhh dCBpdCBjYW4gb25seSBiZQogICAgdXNlZCB3aGVuIFQgYW5kIFUgYXJlIHdlYWtseS1lcXVhbGl0 eS1jb21wYXJhYmxlIGFuZCBhbHNvIHRocmVlLXdheQogICAgY29tcGFyYWJsZS4KICAgIAogICAg QWRkaW5nIHRoYXQgY29uc3RyYWluIGNvbXBsZXRlbHkgYnJlYWtzIHN0ZDo6b3B0aW9uYWwgY29t cGFyaXNvbnMsCiAgICBiZWNhdXNlIGl0IGNhdXNlcyBjb25zdHJhaW50IHJlY3Vyc2lvbi4gVG8g YXZvaWQgdGhhdCwgYW4gYWRkaXRpb25hbAogICAgY2hlY2sgdGhhdCBVIGlzIG5vdCBhIHNwZWNp YWxpemF0aW9uIG9mIHN0ZDo6b3B0aW9uYWwgaXMgbmVlZGVkLiBUaGF0CiAgICBhcHBlYXJzIHRv IGJlIGEgZGVmZWN0IGluIHRoZSBzdGFuZGFyZCBhbmQgc2hvdWxkIGJlIHJlcG9ydGVkIHRvIExX Ry4KICAgIAogICAgU2lnbmVkLW9mZi1ieTogSm9uYXRoYW4gV2FrZWx5IDxqd2FrZWx5QHJlZGhh dC5jb20+CiAgICAKICAgIGxpYnN0ZGMrKy12My9DaGFuZ2VMb2c6CiAgICAKICAgICAgICAgICAg UFIgbGlic3RkYysrLzk4ODQyCiAgICAgICAgICAgICogaW5jbHVkZS9zdGQvb3B0aW9uYWwgKG9w ZXJhdG9yPD0+KGNvbnN0IG9wdGlvbmFsPFQ+JiBjb25zdCBVJikpOgogICAgICAgICAgICBBZGQg bWlzc2luZyBjb25zdHJhaW50IGFuZCBhZGQgd29ya2Fyb3VuZCBmb3IgdGVtcGxhdGUKICAgICAg ICAgICAgcmVjdXJzaW9uLgogICAgICAgICAgICAqIHRlc3RzdWl0ZS8yMF91dGlsL29wdGlvbmFs L3JlbG9wcy90aHJlZV93YXkuY2M6IENoZWNrIHRoYXQKICAgICAgICAgICAgdHlwZSB3aXRob3V0 IGVxdWFsaXR5IGNvbXBhcmlzb24gY2Fubm90IGJlIGNvbXBhcmVkIHdoZW4gd3JhcHBlZAogICAg ICAgICAgICBpbiBzdGQ6Om9wdGlvbmFsLgoKZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9pbmNs dWRlL3N0ZC9vcHRpb25hbCBiL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9vcHRpb25hbAppbmRl eCA4YjllMDM4ZTZlNS4uNDE1ZjhjNDllZjQgMTAwNjQ0Ci0tLSBhL2xpYnN0ZGMrKy12My9pbmNs dWRlL3N0ZC9vcHRpb25hbAorKysgYi9saWJzdGRjKystdjMvaW5jbHVkZS9zdGQvb3B0aW9uYWwK QEAgLTEyMzQsNyArMTIzNCwxNCBAQCBfR0xJQkNYWF9CRUdJTl9OQU1FU1BBQ0VfVkVSU0lPTgog ICAgIHsgcmV0dXJuICFfX3JocyB8fCBfX2xocyA+PSAqX19yaHM7IH0KIAogI2lmZGVmIF9fY3Bw X2xpYl90aHJlZV93YXlfY29tcGFyaXNvbgorICB0ZW1wbGF0ZTx0eXBlbmFtZSBfVHA+CisgICAg aW5saW5lIGNvbnN0ZXhwciBib29sIF9faXNfb3B0aW9uYWxfdiA9IGZhbHNlOworICB0ZW1wbGF0 ZTx0eXBlbmFtZSBfVHA+CisgICAgaW5saW5lIGNvbnN0ZXhwciBib29sIF9faXNfb3B0aW9uYWxf djxvcHRpb25hbDxfVHA+PiA9IHRydWU7CisKICAgdGVtcGxhdGU8dHlwZW5hbWUgX1RwLCB0eXBl bmFtZSBfVXA+CisgICAgcmVxdWlyZXMgKCFfX2lzX29wdGlvbmFsX3Y8X1VwPikKKyAgICAgICYm IHRocmVlX3dheV9jb21wYXJhYmxlX3dpdGg8X1RwLCBfVXA+CiAgICAgY29uc3RleHByIGNvbXBh cmVfdGhyZWVfd2F5X3Jlc3VsdF90PF9UcCwgX1VwPgogICAgIG9wZXJhdG9yPD0+KGNvbnN0IG9w dGlvbmFsPF9UcD4mIF9feCwgY29uc3QgX1VwJiBfX3YpCiAgICAgeyByZXR1cm4gYm9vbChfX3gp ID8gKl9feCA8PT4gX192IDogc3Ryb25nX29yZGVyaW5nOjpsZXNzOyB9CmRpZmYgLS1naXQgYS9s aWJzdGRjKystdjMvdGVzdHN1aXRlLzIwX3V0aWwvb3B0aW9uYWwvcmVsb3BzL3RocmVlX3dheS5j YyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMjBfdXRpbC9vcHRpb25hbC9yZWxvcHMvdGhyZWVf d2F5LmNjCmluZGV4IDk1M2JlZjRhMWVhLi41ZmM1ZWVjNWFiZiAxMDA2NDQKLS0tIGEvbGlic3Rk YysrLXYzL3Rlc3RzdWl0ZS8yMF91dGlsL29wdGlvbmFsL3JlbG9wcy90aHJlZV93YXkuY2MKKysr IGIvbGlic3RkYysrLXYzL3Rlc3RzdWl0ZS8yMF91dGlsL29wdGlvbmFsL3JlbG9wcy90aHJlZV93 YXkuY2MKQEAgLTE1LDggKzE1LDggQEAKIC8vIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZp bGUgQ09QWUlORzMuICBJZiBub3Qgc2VlCiAvLyA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2Vz Lz4uCiAKLS8vIHsgZGctb3B0aW9ucyAiLXN0ZD1nbnUrKzJhIiB9Ci0vLyB7IGRnLWRvIGNvbXBp bGUgeyB0YXJnZXQgYysrMmEgfSB9CisvLyB7IGRnLW9wdGlvbnMgIi1zdGQ9Z251KysyMCIgfQor Ly8geyBkZy1kbyBjb21waWxlIHsgdGFyZ2V0IGMrKzIwIH0gfQogCiAjaW5jbHVkZSA8b3B0aW9u YWw+CiAKQEAgLTc0LDMgKzc0LDIxIEBAIHRlc3QwMigpCiAgIHN0YXRpY19hc3NlcnQoIG51bGxv cHQgPD0gT3t9ICk7CiAgIHN0YXRpY19hc3NlcnQoIG51bGxvcHQgPD0gT3sxfSApOwogfQorCit0 ZW1wbGF0ZTx0eXBlbmFtZSBUPgorICBjb25jZXB0IGhhc19zcGFjZXNoaXAgPSByZXF1aXJlcyAo Y29uc3QgVCYgdCkgeyB0IDw9PiB0OyB9OworCit2b2lkCit0ZXN0MDMoKQoreworICBzdHJ1Y3Qg RQorICB7CisgICAgYXV0byBvcGVyYXRvcjw9Pihjb25zdCBFJikgY29uc3QgeyByZXR1cm4gc3Rk OjpzdHJvbmdfb3JkZXJpbmc6OmVxdWFsOyB9CisgIH07CisgIHN0YXRpY19hc3NlcnQoICFzdGQ6 OnRocmVlX3dheV9jb21wYXJhYmxlPEU+ICk7IC8vIG5vdCBlcXVhbGl0eSBjb21wYXJhYmxlCisg IHVzaW5nIE8gPSBzdGQ6Om9wdGlvbmFsPEU+OworICBzdGF0aWNfYXNzZXJ0KCAhc3RkOjp0aHJl ZV93YXlfY29tcGFyYWJsZTxPPiApOworICBzdGF0aWNfYXNzZXJ0KCAhIGhhc19zcGFjZXNoaXA8 Tz4gKTsgLy8gUFIgbGlic3RkYysrLzk4ODQyCisgIHN0cnVjdCBVIDogTyB7IH07CisgIHN0YXRp Y19hc3NlcnQoICEgaGFzX3NwYWNlc2hpcDxVPiApOworfQo= --00000000000066ae5f05c42eb774--