From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 1DE6A3987978; Thu, 17 Jun 2021 18:15:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DE6A3987978 Received: by mail-wm1-x330.google.com with SMTP id t4-20020a1c77040000b029019d22d84ebdso6976015wmi.3; Thu, 17 Jun 2021 11:15:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ik8CQaAFFKWuyjLuCUkWO25WkZ8YHumnYjnaOCGOlbY=; b=qUoNzOCLb102xBo1cI7w+UyOMzgowGHI4eWB39mc8jY7/fEhLmJWCHGVkucAhO1Q3w mhFFHBZRwRNYrzuZhKP/bGMGerVcoR+GUcqU8JesOYNAHeV+tdOsp6XtCgnO/B8kiky4 CsDba0VJstOT2b49o4cyeRQJ+MYSLa0VbhSeXFGpuasyQy2xQcnjNQuRlfDv76xq/Rzv Fl+cesd85hA9GY+RML+oai8dcmMcdaDNf2oPC2QTz9SZTrhfJDip8ZiPM1zUCZHRGhZw a4o2pREld3YJaXK+T3IZ0s/DWGoVxQcbXdSml4kg2ImwzXGpJp0730+IJJ5YscG9pGns n1Jg== X-Gm-Message-State: AOAM533db9f3+dpxwrdzGWIpB5xPsa3ENXbVHre1y1SKC0iA19CvacSo V93mviggU2jx4NiotihAjqKE87t+OW13d1BPIpo= X-Google-Smtp-Source: ABdhPJxQN3ur/zaE0gsWSWd0gqmh/sI5NlLgvAHH+LfdlcFLgBcA85Q+n69BvXsQSlE9kXmRMj4DiVlZ1buPtbIpA5o= X-Received: by 2002:a7b:c189:: with SMTP id y9mr6621409wmi.106.1623953700176; Thu, 17 Jun 2021 11:15:00 -0700 (PDT) MIME-Version: 1.0 References: <20210617152206.1408001-1-ppalka@redhat.com> <20210617152206.1408001-2-ppalka@redhat.com> In-Reply-To: <20210617152206.1408001-2-ppalka@redhat.com> From: Jonathan Wakely Date: Thu, 17 Jun 2021 19:14:47 +0100 Message-ID: Subject: Re: [PATCH 2/5] libstdc++: Move ranges algos used by into ranges_util.h To: Patrick Palka Cc: gcc-patches , "libstdc++" X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 18:15:02 -0000 On Thu, 17 Jun 2021, 16:47 Patrick Palka via Libstdc++, < libstdc++@gcc.gnu.org> wrote: > The header defines simplified copies of some ranges algorithms > in order to avoid including the entirety of ranges_algo.h. A subsequent > patch is going to want to use ranges::search in as well, but > that algorithm is more complicated compared to the other copied ones. > > So rather than additionally copying ranges::search into , this > patch splits out all the ranges algos used by (including > ranges::search) from ranges_algo.h to ranges_util.h, and deletes the > simplified copies in . This seems like the best place for > these algorithms, as ranges_util.h is included only from and > ranges_algo.h. > OK, thanks.